Re: [ros-dev] Status Meeting (May 2018)

Hi!<br>
<br>
To that I see one solution, that has actually already been proposed in the PR:<br>
we make an external package (a la Wine gecko) that one can download during installation, or later through RAPPS.<br>
Then this package (possibly together with other heavy core ones?) could be hosted in some GitHub sub-repo or elsewhere...<br>
Closing the PR now would definitely not be the right solution.<br>
<br>
Best,<br>
H.<span style="font-family:arial,helvetica,sans-serif; font-size:12px">‌</span>

<div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Colin Finck"<br>
A : [e-mail]<br>
Envoyé: mercredi 30 mai 2018 18:21<br>
Objet : Re: [ros-dev] Status Meeting (May 2018)<br>
&nbsp;
<div class="gl_quoted">Am 30.05.2018 um 13:26 schrieb Ged Murphy:<br>
&gt; Potential problems are:<br>
&gt; 4) something else?<br>
<br>
I've been struggling with e.g. https://github.com/reactos/reactos/pull/276<br>
<br>
On the one hand, we definitely need official support for Chinese,<br>
Korean, and Japanese character sets.<br>
On the other hand, this must not bloat up ReactOS by default, and just<br>
dropping a 12 MB font into the repository definitely does.<br>
So what is the ideal solution? I don't even know myself.<br>
<br>
- I could leave the PR open and hope that the submitter addresses my<br>
comments and comes up with a better solution. That hasn't happened in<br>
the last months.<br>
<br>
- I could close the PR right away. That would give the submitter no<br>
chance to address my comments and may even look disrespectful. And the<br>
original problem tends to be forgotten.<br>
<br>
- I could close the PR and open a JIRA issue describing the problem.<br>
If we decide on that as a general rule, we would put another burden on<br>
every reviewer. Additionally, such general JIRA issues tend to rot in<br>
our database as well.<br>
<br>
I think we often have this situation where the submitted PR is wrong,<br>
but we don't know the right solution either, and therefore keep the PR<br>
open. If we can better deal with these cases, the number of open PRs may<br>
decrease significantly.<br>
<br>
<br>
- Colin<br>
<br>
_______________________________________________ Ros-dev mailing list [e-mail] http://www.reactos.org/mailman/listinfo/ros-dev</div>

<div class="gl_quoted">&nbsp;</div>
</div>

[Robert Naumann]

I would think about something like CORE-9525

[e-mail] schrieb am Mi., 30. Mai 2018, 19:24:
> Hi!
>
> To that I see one solution, that has actually already been proposed in the
> PR:
> we make an external package (a la Wine gecko) that one can download during
> installation, or later through RAPPS.
> Then this package (possibly together with other heavy core ones?) could be
> hosted in some GitHub sub-repo or elsewhere...
> Closing the PR now would definitely not be the right solution.
>
> Best,
> H.‌
> De : "Colin Finck"
> A : [e-mail]
> Envoyé: mercredi 30 mai 2018 18:21
> Objet : Re: [ros-dev] Status Meeting (May 2018)
>
> Am 30.05.2018 um 13:26 schrieb Ged Murphy:
> > Potential problems are:
> > 4) something else?
>
> I've been struggling with e.g. https://github.com/reactos/reactos/pull/276
>
> On the one hand, we definitely need official support for Chinese,
> Korean, and Japanese character sets.
> On the other hand, this must not bloat up ReactOS by default, and just
> dropping a 12 MB font into the repository definitely does.
> So what is the ideal solution? I don't even know myself.
> I could leave the PR open and hope that the submitter addresses my
>
> comments and comes up with a better solution. That hasn't happened in
> the last months.
> I could close the PR right away. That would give the submitter no
>
> chance to address my comments and may even look disrespectful. And the
> original problem tends to be forgotten.
> I could close the PR and open a JIRA issue describing the problem.
>
> If we decide on that as a general rule, we would put another burden on
> every reviewer. Additionally, such general JIRA issues tend to rot in
> our database as well.
>
> I think we often have this situation where the submitted PR is wrong,
> but we don't know the right solution either, and therefore keep the PR
> open. If we can better deal with these cases, the number of open PRs may
> decrease significantly.
> Colin
>
> _______________________________________________ Ros-dev mailing list
> [e-mail] http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev