Release Candidate, Test coordinator, ...

[Martin Fuchs]

OK, there have been a few misunderstandings, which lead to the current problems
and all this partly quite angry discussions.
Let's go on and see what to do now. I recommend the following steps:
1.) Fix the console bug in question, and put a new tested release
candidate on the web.
2.) update the release procedure
  (http://www.reactos.org/wiki/index.php/Release_Management_Overview)
  to include the test coordinator
  Of course this includes a discussion about the new content on the
mailing list.
3.) make an official vote for the test coordinator and new release procedure.
And Alex - I hope your break period will not last too long.
Regards,
     Martin

[Ge van Geldorp]

>   From: Martin Fuchs
>  1.) Fix the console bug in question, and put a new tested
>  release candidate on the web. 
I've been trying to reproduce the bug on the hardware available to me (5
different PCs), but I can't (yes, I unplugged the PS/2 mouse).
If we can't fix it, maybe we should put the pre-i8042prt code back and use
that for now? Would that cause major other problems (e.g. PnP issues)?
Gé van Geldorp.

[Martin Fuchs]

>   I've been trying to reproduce the bug on the
> hardware available to me (5
>  different PCs), but I can't (yes, I unplugged the PS/2 mouse). 
Well, I have only one machine to test ReactOS on real hardware.
And I also don't see the problem.
So the following statement ("...most real hardware") in Bug 688 is
very questionable:
BZ> The addition of i8042prt created some changes in console allocation during
BZ> text-mode setup, which leads to AllocConsole failing (for unknown reasons
BZ> there). This stops installation on most real hardware.
>   If we can't fix it, maybe we should put the
> pre-i8042prt code back and use
>  that for now? Would that cause major other problems (e.g. PnP issues)? 
There is a comment in the related Bug 682, which may be a helpful idea:
BZ> When I started ros install (boot cd) I switched my keyboard and
monitor to other
BZ> computer and when setup started to scan for devices it didn't find
keyboard and
BZ> gave a blue screen. So maybe we should implement some kind of fallback
BZ> system so that if for example keyboard isn't found it will
fallback to a basic
BZ> keyboard and use that.
If I understand correctly the problem lies in the mouse detection code.
On some hardware the detection goes wrong. So let's at least disable the
mouse, but avoid to stop the setup. Using the keyboard without the mouse
should be enough in this stage.
Regards,
    Martin

[Ge van Geldorp]

While looking over the i8042prt code, what scared me a bit was that we're
hapilly mixing STATUS_TIMEOUT and STATUS_IO_TIMEOUT. Note that
NT_SUCCESS(STATUS_TIMEOUT) will return TRUE (!!!), while
NT_SUCCESS(STATUS_IO_TIMEOUT) will return FALSE.
Take for example this loop in I8042BasicDetect:
Counter = 3;
do {
    Status = I8042ReadDataWait(DevExt, &Value);
} while ((Counter--) && (STATUS_TIMEOUT == Status));
If my reading of the code is correct, I8042ReadDataWait can either return
STATUS_SUCCESS or STATUS_IO_TIMEOUT, it will never return the STATUS_TIMEOUT
which is tested here.
I'd like to change all the STATUS_TIMEOUT occurences to STATUS_IO_TIMEOUT, I
get the impression that a timeout is an error condition in i8042prt so we
want NT_SUCCESS() to return FALSE if a timeout occurred. Anyone out there
seeing this AllocConsole bug who would be willing to test?
Gé van Geldorp.

[Hartmut Birr]

Ge van Geldorp wrote:
>   Anyone out there
>  seeing this AllocConsole bug who would be willing to test?
>   
I'm get the following line if I boot my test machine without a PS/2 mouse:
(drivers\input\i8042prt\i8042prt.c:562) Basic keyboard detection failed: c00000b5
- Hartmut

[Magnus Olsen]

Hi Hartmut
Only computer I can think of why (drivers\input\i8042prt\i8042prt.c:562)
 Basic keyboard detection failed. It is on a compac. I have done a small
patch for i8042prt it remove keyboard self test, for if u execute standard
keyboard self test it should not found the keyboard.  And I think also
it solv u problem keyboard not found can u tested. if it works
be free to commit it.
----- Original Message -----
From: "Hartmut Birr" <osexpert(a)gmail.com>
To: "ReactOS Development List" <ros-dev(a)reactos.org>
Sent: den 18 October 2005 18:05
Subject: Re: [ros-dev] AllocConsole bug
>   Ge van Geldorp wrote:
> >   Anyone out there
> >  seeing this AllocConsole bug who would be willing to test?
> >  
>  I'm get the following line if I boot my test machine without a PS/2 mouse:
>  (drivers\input\i8042prt\i8042prt.c:562) Basic keyboard detection failed: 
c00000b5
>  - Hartmut
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  --
>  No virus found in this incoming message.
>  Checked by AVG Anti-Virus.
>  Version: 7.0.344 / Virus Database: 267.12.2/137 - Release Date: 2005-10-16
>