Doubts about the header changes in r29178

[Colin Finck]

Hello,

Hervé added some Standard C library headers to the "include/crt" directory
in r29178.
Now some people noticed that these changes broke building ReactOS components
with MSVC using the ReactOS headers ("Debug - ReactOS headers" or "Release -
ReactOS headers" configuration).

I have some general doubts about these changes.
> From my knowledge, the headers added in this commit, are compiler-specific

and target-independent. You can easily see that they are specific to
GCC/mingw as for example "stdio.h" includes a "_mingw.h" file with
mingw-specific stuff.
"stdarg.h" even leads to compilation problems with non-GCC-compilers (like
MSVC), because it defines a type based on the __builtin_va_list type, and
this built-in type only exists for GCC.

In my opinion, this commit should be reverted.
This way every compiler will use its own Standard C library headers and MSVC
should be able to build ReactOS components using the ReactOS Win32 headers
again.

Regards,

Colin

[Magnus Olsen]

Hervé change are correct, if we whant build of other platfrom from our tree
we need own header for it. His change are correct, our header need be
fixed msvc and gcc comptaible. is the correct way to take
I using ros own headers allot to build reactos part with MSVS
before Hervé changes. and some part have header issue with ms vs
and they are need be fixed. and I did fix few of thuse issuse some
year ago. But never had time finish that work, thanks to other
thing are more need it.

----- Original Message ----- 
From: "Colin Finck" [e-mail]
To: "'ReactOS Development List'" [e-mail]
Sent: Monday, October 15, 2007 2:42 PM
Subject: [ros-dev] Doubts about the header changes in r29178

Hello,

Hervé added some Standard C library headers to the "include/crt" directory
in r29178.
Now some people noticed that these changes broke building ReactOS components
with MSVC using the ReactOS headers ("Debug - ReactOS headers" or "Release -
ReactOS headers" configuration).

I have some general doubts about these changes.
> From my knowledge, the headers added in this commit, are compiler-specific

and target-independent. You can easily see that they are specific to
GCC/mingw as for example "stdio.h" includes a "_mingw.h" file with
mingw-specific stuff.
"stdarg.h" even leads to compilation problems with non-GCC-compilers (like
MSVC), because it defines a type based on the __builtin_va_list type, and
this built-in type only exists for GCC.

In my opinion, this commit should be reverted.
This way every compiler will use its own Standard C library headers and MSVC
should be able to build ReactOS components using the ReactOS Win32 headers
again.

Regards,

Colin

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev