Re: [ros-dev] [ros-diffs] [akhaldi] 64151: [XDK][DDK] * Handle the rest of cases about the order of pragma and symbol declaration.

[Jérôme Gardou]

This breaks KDGDB compilation (and most probable KDCOM too if one would 
want to compile it using GCC)

drivers/base/kdgdb/gdb_send.c:77: référence indéfinie vers « 
__imp__KdDebuggerNotPresent »

Le 14/09/2014 17:49, [e-mail] a écrit :
> Author: akhaldi
> Date: Sun Sep 14 15:49:35 2014
> New Revision: 64151
>
> URL: http://svn.reactos.org/svn/reactos?rev=64151&view=rev
> Log:
> [XDK][DDK]
> Handle the rest of cases about the order of pragma and symbol declaration.
>
> Modified:
>      trunk/reactos/include/ddk/ntddk.h
>      trunk/reactos/include/ddk/ntifs.h
>      trunk/reactos/include/ddk/wdm.h
>      trunk/reactos/include/xdk/fsrtlfuncs.h
>      trunk/reactos/include/xdk/haltypes.h
>      trunk/reactos/include/xdk/kdfuncs.h
>      trunk/reactos/include/xdk/ketypes.h
>      trunk/reactos/include/xdk/mmtypes.h
>      trunk/reactos/include/xdk/ntifs.template.h
>
> Modified: trunk/reactos/include/ddk/ntddk.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntddk.h?rev=641...
> ==============================================================================
> --- trunk/reactos/include/ddk/ntddk.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/ddk/ntddk.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -1670,8 +1670,8 @@
>   extern HAL_DISPATCH HalDispatchTable;
>   #define HALDISPATCH (&HalDispatchTable)
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(HalDispatchTable)
>   extern PHAL_DISPATCH HalDispatchTable;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(HalDispatchTable)
>   #define HALDISPATCH HalDispatchTable
>   #endif
>
> Modified: trunk/reactos/include/ddk/ntifs.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=641...
> ==============================================================================
> --- trunk/reactos/include/ddk/ntifs.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/ddk/ntifs.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -8396,8 +8396,8 @@
>   extern const UCHAR * const FsRtlLegalAnsiCharacterArray;
>   #define LEGAL_ANSI_CHARACTER_ARRAY FsRtlLegalAnsiCharacterArray
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(FsRtlLegalAnsiCharacterArray)
>   extern const UCHAR * const *FsRtlLegalAnsiCharacterArray;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(FsRtlLegalAnsiCharacterArray)
>   #define LEGAL_ANSI_CHARACTER_ARRAY (*FsRtlLegalAnsiCharacterArray)
>   #endif
>
> @@ -10993,8 +10993,8 @@
>   extern PUSHORT NlsOemLeadByteInfo;
>   #define NLS_OEM_LEAD_BYTE_INFO NlsOemLeadByteInfo
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(NlsOemLeadByteInfo)
>   extern PUSHORT *NlsOemLeadByteInfo;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(NlsOemLeadByteInfo)
>   #define NLS_OEM_LEAD_BYTE_INFO (*NlsOemLeadByteInfo)
>   #endif
>
> Modified: trunk/reactos/include/ddk/wdm.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=64151...
> ==============================================================================
> --- trunk/reactos/include/ddk/wdm.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/ddk/wdm.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -1661,8 +1661,8 @@
>   #elif (NTDDI_VERSION >= NTDDI_WINXP)
>   extern NTSYSAPI CCHAR KeNumberProcessors;
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(KeNumberProcessors)
>   extern PCCHAR KeNumberProcessors;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(KeNumberProcessors)
>   #endif
>
> @@ -1815,8 +1815,8 @@
>   } MM_SYSTEMSIZE;
>
> #ifndef _NTSYSTEM_
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(Mm64BitPhysicalAddress)
>   extern PBOOLEAN Mm64BitPhysicalAddress;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(Mm64BitPhysicalAddress)
>   #endif
>   extern NTKERNELAPI PVOID MmBadPointer;
>
> Modified: trunk/reactos/include/xdk/fsrtlfuncs.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/fsrtlfuncs.h?re...
> ==============================================================================
> --- trunk/reactos/include/xdk/fsrtlfuncs.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/fsrtlfuncs.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -1584,8 +1584,8 @@
>   extern const UCHAR * const FsRtlLegalAnsiCharacterArray;
>   #define LEGAL_ANSI_CHARACTER_ARRAY FsRtlLegalAnsiCharacterArray
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(FsRtlLegalAnsiCharacterArray)
>   extern const UCHAR * const *FsRtlLegalAnsiCharacterArray;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(FsRtlLegalAnsiCharacterArray)
>   #define LEGAL_ANSI_CHARACTER_ARRAY (*FsRtlLegalAnsiCharacterArray)
>   #endif
>
> Modified: trunk/reactos/include/xdk/haltypes.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/haltypes.h?rev=...
> ==============================================================================
> --- trunk/reactos/include/xdk/haltypes.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/haltypes.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -273,8 +273,8 @@
>   extern HAL_DISPATCH HalDispatchTable;
>   #define HALDISPATCH (&HalDispatchTable)
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(HalDispatchTable)
>   extern PHAL_DISPATCH HalDispatchTable;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(HalDispatchTable)
>   #define HALDISPATCH HalDispatchTable
>   #endif
>
> Modified: trunk/reactos/include/xdk/kdfuncs.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/kdfuncs.h?rev=6...
> ==============================================================================
> --- trunk/reactos/include/xdk/kdfuncs.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/kdfuncs.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -125,11 +125,11 @@
>   extern BOOLEAN KdDebuggerNotPresent;
>   #define KD_DEBUGGER_NOT_PRESENT KdDebuggerNotPresent
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(KdDebuggerEnabled)
>   extern BOOLEAN *KdDebuggerEnabled;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(KdDebuggerEnabled)
>   #define KD_DEBUGGER_ENABLED (*KdDebuggerEnabled)
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(KdDebuggerNotPresent)
>   extern BOOLEAN *KdDebuggerNotPresent;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(KdDebuggerNotPresent)
>   #define KD_DEBUGGER_NOT_PRESENT (*KdDebuggerNotPresent)
>   #endif
>
> Modified: trunk/reactos/include/xdk/ketypes.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/ketypes.h?rev=6...
> ==============================================================================
> --- trunk/reactos/include/xdk/ketypes.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/ketypes.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -986,8 +986,8 @@
>   #elif (NTDDI_VERSION >= NTDDI_WINXP)
>   extern NTSYSAPI CCHAR KeNumberProcessors;
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(KeNumberProcessors)
>   extern PCCHAR KeNumberProcessors;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(KeNumberProcessors)
>   #endif
>
> $endif (_WDMDDK_)
>
> Modified: trunk/reactos/include/xdk/mmtypes.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/mmtypes.h?rev=6...
> ==============================================================================
> --- trunk/reactos/include/xdk/mmtypes.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/mmtypes.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -148,8 +148,8 @@
>   } MM_SYSTEMSIZE;
>
> #ifndef _NTSYSTEM_
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(Mm64BitPhysicalAddress)
>   extern PBOOLEAN Mm64BitPhysicalAddress;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(Mm64BitPhysicalAddress)
>   #endif
>   extern NTKERNELAPI PVOID MmBadPointer;
>
> Modified: trunk/reactos/include/xdk/ntifs.template.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/ntifs.template....
> ==============================================================================
> --- trunk/reactos/include/xdk/ntifs.template.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/xdk/ntifs.template.h	[iso-8859-1] Sun Sep 14 15:49:35 2014
> @@ -1128,8 +1128,8 @@
>   extern PUSHORT NlsOemLeadByteInfo;
>   #define NLS_OEM_LEAD_BYTE_INFO NlsOemLeadByteInfo
>   #else
> +__CREATE_NTOS_DATA_IMPORT_ALIAS(NlsOemLeadByteInfo)
>   extern PUSHORT *NlsOemLeadByteInfo;
> -__CREATE_NTOS_DATA_IMPORT_ALIAS(NlsOemLeadByteInfo)
>   #define NLS_OEM_LEAD_BYTE_INFO (*NlsOemLeadByteInfo)
>   #endif