Thomas Weidenmueller wrote:
Alex Ionescu wrote:
Please revert these "fixes". They are
incorrect.
Could you please elaborate on what and why they're incorrect?
I'll add some comments:
The change to NtQueueThreadApc:
To see the most obvious way that change is incorrect, see the documented
behaviour of this function, present in even the function comment.
"This function is used to queue an APC from user-mode".
It seems you spotted this quite soon, and SVN is now again correct. Well,
almost. I'm not sure about the switch from KeGetPreviousMode to
ExGetPreviousMode.
Could use a PAGED_CODE macro.
NtAlertThread:
The change to use previous mode even for the call to KeAlertThread seems
correct to me. Only thing I see missing for that function is a PAGED_CODE
macro, and removal of the comment with the question of that very change. :-)
NtSetDefaultHardErrorPort:
Could use a PAGED_CODE macro.
/Mike