Re: [ros-svn] [weiden] 13576: 1. a few previous mode fixes

[Alex Ionescu]

[e-mail] wrote:
> a few previous mode fixes
>
> Updated files:
> trunk/reactos/ntoskrnl/ke/alert.c
> trunk/reactos/ntoskrnl/ke/apc.c
> trunk/reactos/ntoskrnl/ke/error.c

Please revert these "fixes". They are incorrect.

Best regards,
Alex Ionescu

[Thomas Larsen]

RosMine Missing uploader could anybody be ******* nice to upload this for me

I Got Improved Sound Support - Included sounds
New Icons better look
Improved Code
Help System

Send Your E-mail and i would send it to U.....

Thomas

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com

[Gunnar Dalsnes]

Make a unified diff of modified files, zip it together with any new 
files you created, create a new "bug" in bugzilla 
(http://reactos.com/bugzilla) using "Patches" as component. Add an 
attachement to the "bug", attaching your zipped diff. Then mail the link 
to the "bug" to this list. Then you dont pollute the list with big(?) 
attachments and anyone who wants, can take a look at your patch with ease.

Gunnar

Thomas Larsen wrote:
> RosMine Missing uploader could anybody be ******* nice to upload this for me
>
> I Got Improved Sound Support - Included sounds
> New Icons better look
> Improved Code
> Help System
>
> Send Your E-mail and i would send it to U.....
>
> Thomas
>
> __________________________________ 
> Do you Yahoo!? 
> The all-new My Yahoo! - What will yours do?
> http://my.yahoo.com
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[Thomas Weidenmueller]

Alex Ionescu wrote:
> Please revert these "fixes". They are incorrect.

Could you please elaborate on what and why they're incorrect?

Best Regards
Thomas

[Mike Nordell]

Thomas Weidenmueller wrote:
> Alex Ionescu wrote:
> > Please revert these "fixes". They are incorrect.
>
> Could you please elaborate on what and why they're incorrect?

I'll add some comments:

The change to NtQueueThreadApc:
To see the most obvious way that change is incorrect, see the documented
behaviour of this function, present in even the function comment.
"This function is used to queue an APC from user-mode".
It seems you spotted this quite soon, and SVN is now again correct. Well,
almost. I'm not sure about the switch from KeGetPreviousMode to
ExGetPreviousMode.
Could use a PAGED_CODE macro.

NtAlertThread:
The change to use previous mode even for the call to KeAlertThread seems
correct to me. Only thing I see missing for that function is a PAGED_CODE
macro, and removal of the comment with the question of that very change. :-)

NtSetDefaultHardErrorPort:
Could use a PAGED_CODE macro.

/Mike