Re: [ros-dev] [ros-diffs] [tfaber] 64695: [ROSAUTOTEST] - DbgPrint expects a format string! ROSTESTS-145 #resolve

[Colin Finck]

tfaber(a)svn.reactos.org wrote:
>   -                DbgPrint(DbgString);
>  +                OutputDebugStringA(DbgString); 
FYI, we had OutputDebugStringA there in the first place, but I changed
it to DbgPrint in r40147.
IIRC, output from DbgPrint was directly sent to the debug port while
OutputDebugStringA buffers the data first. This is especially bad, when
a test crashes the OS and we lose several kilobytes of log data before
they are printed out.

Probably, a DbgPrint("%s", DbgString) is the better alternative here.


- Colin

[Thomas Faber]

On 2014-10-12 21:37, Colin Finck wrote:
>   tfaber(a)svn.reactos.org wrote:
> >   -                DbgPrint(DbgString);
> >  +                OutputDebugStringA(DbgString); 
>  
>  FYI, we had OutputDebugStringA there in the first place, but I changed
>  it to DbgPrint in r40147.
>  IIRC, output from DbgPrint was directly sent to the debug port while
>  OutputDebugStringA buffers the data first. This is especially bad, when
>  a test crashes the OS and we lose several kilobytes of log data before
>  they are printed out.
>  
>  Probably, a DbgPrint("%s", DbgString) is the better alternative here. 
Yeah that's the other alternative; however it doesn't seem needed?
Testbot is looking fine from what I see, and in a quick look at the
implementation I don't see any of the buffering you mention. Maybe
that's changed as well in the meantime?
I'm happy to change it if there are any problems with OutputDebugString.