Re: [ros-dev] [ros-diffs] [sgasiorek] 74179: [DXG] DdHmgLock - use PLONG instead of PBYTE.

[Kay Dohmann]

This looks wrong to me since both lines produce different results. For
example:
    (PBYTE)0x00000000 + 4 == (PBYTE)0x00000004
but
    (PLONG)0x00000000 + 4 == (PLONG)0x00000010


>        if ( Index < gcMaxDdHmgr )
>       {
>  -        pEntry = (PDD_ENTRY)((PBYTE)gpentDdHmgr + (sizeof(DD_ENTRY) * Index));
>  +        pEntry = (PDD_ENTRY)((PLONG)gpentDdHmgr + (sizeof(DD_ENTRY) * Index));
>   
>           if ( VerifyObjectOwner(pEntry) )
>           {
>
>

[Sebastian Gąsiorek]

Kay,

Thanks for spotting this. I will fix it on next update.

2017-03-22 15:15 GMT+01:00 Kay Dohmann <k.dohmann(a)gmx.net>et>:

>   This looks wrong to me since both lines produce
> different results. For
>  example:
>      (PBYTE)0x00000000 + 4 == (PBYTE)0x00000004
>  but
>      (PLONG)0x00000000 + 4 == (PLONG)0x00000010
>
>
> >        if ( Index < gcMaxDdHmgr )
> >       {
> >  -        pEntry = (PDD_ENTRY)((PBYTE)gpentDdHmgr + (sizeof(DD_ENTRY) * 
>  Index));
> >   +        pEntry = (PDD_ENTRY)((PLONG)gpentDdHmgr
> > + (sizeof(DD_ENTRY) * 
>  Index));
> >  
> >           if ( VerifyObjectOwner(pEntry) )
> >           {
> >
> >  
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev