RE: [ros-dev] Hardcoded strings

[Murphy, Ged (Bolton)]

David Hinz wrote:

>   Somewhere in reactos/lib/cabinet I found sourcecode
> calling functions
>  like err, and the strings it gave to these functions looked like
>  something output to the user e.g. errormessages like file * couldn't
>  be found or something like this, so I wondered, if this should be
>  translatable.
>  As I don't know what kind of stings should be translatable, I 
>  just asked. 
You need to understand the context in which the message is used. If it's
system debug message, it will normally be hardcoded in. If it's a generic
Win32 error message it should be picked up with FormatMessage. These will be
output in the users preferred language via the LANG_SYSTEM_DEFAULT or
LANG_USER_DEFAULT flags. Then you have simple MessageBox outputs which can
be picked out of a resource file, but are generally hardcoded in. There are
many other situations and usages, but I'll stop there. 

As already said, becoming a programmer is the only real way of understanding
it all.
 
>   Well, you say I should learn some things like
> structures of resource
>  files, do you have any links for me? 
There are thousands of C tutorials on the net. Here are a few:
Tutorials : http://www.cprogramming.com/tutorial.html
Forgers win32 : http://www.winprog.org/tutorial/


Everyone has their favourite books, but these are probably the most popular
for learning C and Windows programming:
K & R :
http://www.amazon.com/gp/product/0131103628/qid=1135081344/sr=2-1/ref=pd_bbs
_b_2_1/104-6581600-7986334?s=books&v=glance&n=283155

C Primer Plus :
http://www.amazon.com/gp/product/0672326965/qid=1135081234/sr=1-1/ref=sr_1_1
/104-6581600-7986334?s=books&v=glance&n=283155

Petzold :
http://www.amazon.com/gp/product/157231995X/qid=1135081418/sr=1-1/ref=sr_1_1
/104-6581600-7986334?s=books&v=glance&n=283155


Have fun,
Ged.



************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk 
<mailto:[e-mail]> and then delete this message. 

Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com

[Magnus Olsen]

you need have knowlges mage whole program unicode safe and ansic safe.
some part of reactos that using hardcode string are often coding as ansic or
Wchar and u need make sure the whole functions can take care of both.

it is not only to remove one string u need look at the whole program before
u do it. if u want try remove hardcode string then u need have basic
knowlges of programing and lite more.

----- Original Message ----- 
From: "Murphy, Ged (Bolton)" <MurphyG(a)cmpbatteries.co.uk>
To: <fRy2oo5(a)gmail.com>om>; "'ReactOS Development List'"
<ros-dev(a)reactos.org>
Sent: den 20 December 2005 13:51
Subject: RE: [ros-dev] Hardcoded strings


>   David Hinz wrote:
>
> >   Somewhere in reactos/lib/cabinet I found
> > sourcecode calling functions
> >  like err, and the strings it gave to these functions looked like
> >  something output to the user e.g. errormessages like file * couldn't
> >  be found or something like this, so I wondered, if this should be
> >  translatable.
> >  As I don't know what kind of stings should be translatable, I
> >  just asked. 
>  You need to understand the context in which the message is used. If it's
>  system debug message, it will normally be hardcoded in. If it's a generic
>  Win32 error message it should be picked up with FormatMessage. These will 
be
>   output in the users preferred language via the
> LANG_SYSTEM_DEFAULT or
>  LANG_USER_DEFAULT flags. Then you have simple MessageBox outputs which can
>  be picked out of a resource file, but are generally hardcoded in. There 
are
>   many other situations and usages, but I'll stop
> there.
>
>  As already said, becoming a programmer is the only real way of 
understanding
>   it all.
>
> >   Well, you say I should learn some things like
> > structures of resource
> >  files, do you have any links for me? 
>  There are thousands of C tutorials on the net. Here are a few:
>  Tutorials : http://www.cprogramming.com/tutorial.html
>  Forgers win32 : http://www.winprog.org/tutorial/
>
>
>  Everyone has their favourite books, but these are probably the most 
popular
>   for learning C and Windows programming:
>  K & R :
>  
http://www.amazon.com/gp/product/0131103628/qid=1135081344/sr=2-1/ref=pd_bbs
>  
> _b_2_1/104-6581600-7986334?s=books&v=glance&n=283155
>
>  C Primer Plus :
>  
http://www.amazon.com/gp/product/0672326965/qid=1135081234/sr=1-1/ref=sr_1_1
>  
> /104-6581600-7986334?s=books&v=glance&n=283155
>
>  Petzold :
>  
http://www.amazon.com/gp/product/157231995X/qid=1135081418/sr=1-1/ref=sr_1_1
>  
> /104-6581600-7986334?s=books&v=glance&n=283155
>
>
>  Have fun,
>  Ged.
>
>
>
>  ************************************************************************
>  The information contained in this message or any of its
>  attachments is confidential and is intended for the exclusive
>  use of the addressee. The information may also be legally
>  privileged. The views expressed may not be company policy,
>  but the personal views of the originator. If you are not the
>  addressee, any disclosure, reproduction, distribution or other
>  dissemination or use of this communication is strictly prohibited.
>  If you have received this message in error, please contact
>  postmaster(a)exideuk.co.uk
>  <mailto:[e-mail]> and then delete this message.
>
>  Exide Technologies is an industrial and transportation battery
>  producer and recycler with operations in 89 countries.
>  Further information can be found at www.exide.com
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[David Hinz]

Thanks guys, thanks for the help, I will have a look at the links, just 
looked over cabinet, doesn't look, like it needs to be translated, they 
all seem to be debug messages.

Greets,

David Hinz

Magnus Olsen schrieb:
>   you need have knowlges mage whole program unicode safe
> and ansic safe.
>  some part of reactos that using hardcode string are often coding as ansic or
>  Wchar and u need make sure the whole functions can take care of both.
>  
>  it is not only to remove one string u need look at the whole program before
>  u do it. if u want try remove hardcode string then u need have basic
>  knowlges of programing and lite more.
>  
>  ----- Original Message ----- 
>  From: "Murphy, Ged (Bolton)" <MurphyG(a)cmpbatteries.co.uk>
>  To: <fRy2oo5(a)gmail.com>om>; "'ReactOS Development List'"
> <ros-dev(a)reactos.org>
>  Sent: den 20 December 2005 13:51
>  Subject: RE: [ros-dev] Hardcoded strings
>  
>  
> >   David Hinz wrote:
> >
> > >   Somewhere in reactos/lib/cabinet I found
> > > sourcecode calling functions
> > >  like err, and the strings it gave to these functions looked like
> > >  something output to the user e.g. errormessages like file * couldn't
> > >  be found or something like this, so I wondered, if this should be
> > >  translatable.
> > >  As I don't know what kind of stings should be translatable, I
> > >  just asked. 
> >  You need to understand the context in which the message is used. If
> > it's
> >  system debug message, it will normally be hardcoded in. If it's a generic
> >  Win32 error message it should be picked up with FormatMessage. These will 
>  be
> >   output in the users preferred language via the
> > LANG_SYSTEM_DEFAULT or
> >  LANG_USER_DEFAULT flags. Then you have simple MessageBox outputs which can
> >  be picked out of a resource file, but are generally hardcoded in. There 
>  are
> >   many other situations and usages, but I'll
> > stop there.
> >
> >  As already said, becoming a programmer is the only real way of 
>  understanding
> >   it all.
> >
> > >   Well, you say I should learn some things like
> > > structures of resource
> > >  files, do you have any links for me? 
> >  There are thousands of C tutorials on the
> > net. Here are a few:
> >  Tutorials : http://www.cprogramming.com/tutorial.html
> >  Forgers win32 : http://www.winprog.org/tutorial/
> >
> >
> >  Everyone has their favourite books, but these are probably the most 
>  popular
> >   for learning C and Windows programming:
> >  K & R :
> >  
>  http://www.amazon.com/gp/product/0131103628/qid=1135081344/sr=2-1/ref=pd_bbs
> >  
> > _b_2_1/104-6581600-7986334?s=books&v=glance&n=283155
> >
> >  C Primer Plus :
> >  
>  http://www.amazon.com/gp/product/0672326965/qid=1135081234/sr=1-1/ref=sr_1_1
> >  
> > /104-6581600-7986334?s=books&v=glance&n=283155
> >
> >  Petzold :
> >  
>  http://www.amazon.com/gp/product/157231995X/qid=1135081418/sr=1-1/ref=sr_1_1
> > /104-6581600-7986334?s=books&v=glance&n=283155
> >
> >
> > Have fun,
> > Ged.