Re: [ros-dev] [ros-diffs] [fireball] 50967: - Revert 47615. Please fix actual sysreg instead of adding inconsistency between 1st, 2nd and 3rd stages debugging connections. This should fix sysreg3's inability to do backtrace...

[Timo Kreuzer]

Hmm...

I remember I added it to enable the possibility for backtraces in 1st 
stage for sysreg. Why does it now cause the opposite? And why is there 
an inconsistency? In 2nd stage there is an option for debug mode, in 1st 
stage there is none, so using kdserial (which imo is appropriate way to 
do it, I always select it) as default is as consistent as using "normal" 
debug, getting the input from the keyboard driver.

Just my 0,002 ct/kb
Timo

Am 04.03.2011 17:57, schrieb [e-mail]:
> Author: fireball
> Date: Fri Mar  4 16:57:56 2011
> New Revision: 50967
>
> URL: http://svn.reactos.org/svn/reactos?rev=50967&view=rev
> Log:
> Revert 47615. Please fix actual sysreg instead of adding inconsistency between 1st, 2nd and 3rd stages debugging connections. This should fix sysreg3's inability to do backtraces.
>
> See issue #5811 for more details.
>
> Modified:
>      trunk/reactos/boot/bootdata/txtsetup.sif
>
> Modified: trunk/reactos/boot/bootdata/txtsetup.sif
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif?...
> ==============================================================================
> --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Mar  4 16:57:56 2011
> @@ -59,7 +59,7 @@
>   [SetupData]
>   DefaultPath = \ReactOS
>   OsLoadOptions = "/NOGUIBOOT /NODEBUG"
> -DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE /KDSERIAL"
> +DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE"
>   ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=SCREEN"
>   ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS"

[Olaf Siejka]

It causes issues in 1st stage access to kdbg. Simply speaking, instead of
using vbox window focus to type in kdbg commands, those only work with
terminal (like putty) window focus.

2011/3/4 Timo Kreuzer [e-mail]
> Hmm...
>
> I remember I added it to enable the possibility for backtraces in 1st stage
> for sysreg. Why does it now cause the opposite? And why is there an
> inconsistency? In 2nd stage there is an option for debug mode, in 1st stage
> there is none, so using kdserial (which imo is appropriate way to do it, I
> always select it) as default is as consistent as using "normal" debug,
> getting the input from the keyboard driver.
>
> Just my 0,002 ct/kb
> Timo
>
> Am 04.03.2011 17:57, schrieb [e-mail]:
> > Author: fireball
> > Date: Fri Mar  4 16:57:56 2011
> > New Revision: 50967
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=50967&view=rev
> > Log:
> > Revert 47615. Please fix actual sysreg instead of adding inconsistency
> >
> > between 1st, 2nd and 3rd stages debugging connections. This should fix
> > sysreg3's inability to do backtraces.
> > See issue #5811 for more details.
> >
> > Modified:
> >     trunk/reactos/boot/bootdata/txtsetup.sif
> >
> > Modified: trunk/reactos/boot/bootdata/txtsetup.sif
> > URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif?...
> >
> > ==============================================================================
> > --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original)
> > +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Mar  4
> > 16:57:56 2011
> > @@ -59,7 +59,7 @@
> >  [SetupData]
> >  DefaultPath = \ReactOS
> >  OsLoadOptions = "/NOGUIBOOT /NODEBUG"
> > -DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE /KDSERIAL"
> > +DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE"
> >  ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=SCREEN"
> >  ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS"
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Aleksey Bragin]

Yes, throughout all years I used to type into the virtual machine  
window (or real hardware's keyboard) in order to enter kdbg commands  
in 1st, 2nd and 3rd stages. The default way for 2nd and 3rd remains  
the same, but that commit changed default for the 1st stage, and that  
was quite unexpected (there was even a bug report submitted for  
that). Not to say that I didn't notice that commit back then, and was  
wondering why sysreg3 is not able to enter any kdbg commands into  
virtual box window when first stage of setup runs.

On Mar 5, 2011, at 4:34 AM, Olaf Siejka wrote:
> It causes issues in 1st stage access to kdbg. Simply speaking,  
> instead of using vbox window focus to type in kdbg commands, those  
> only work with terminal (like putty) window focus.
>
> 2011/3/4 Timo Kreuzer [e-mail]
>
> Hmm...
>
> I remember I added it to enable the possibility for backtraces in  
> 1st stage for sysreg. Why does it now cause the opposite? And why  
> is there an inconsistency? In 2nd stage there is an option for  
> debug mode, in 1st stage there is none, so using kdserial (which  
> imo is appropriate way to do it, I always select it) as default is  
> as consistent as using "normal" debug, getting the input from the  
> keyboard driver.
>
> Just my 0,002 ct/kb
> Timo
>
> Am 04.03.2011 17:57, schrieb [e-mail]:
> Author: fireball
> Date: Fri Mar  4 16:57:56 2011
> New Revision: 50967
>
> URL: http://svn.reactos.org/svn/reactos?rev=50967&view=rev
> Log:
> Revert 47615. Please fix actual sysreg instead of adding
>
> inconsistency between 1st, 2nd and 3rd stages debugging  
> connections. This should fix sysreg3's inability to do backtraces.
> See issue #5811 for more details.
>
> Modified:
>     trunk/reactos/boot/bootdata/txtsetup.sif
>
> Modified: trunk/reactos/boot/bootdata/txtsetup.sif
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/ 
> txtsetup.sif?rev=50967&r1=50966&r2=50967&view=diff
> ====================================================================== 
> ========
> --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Mar   
> 4 16:57:56 2011
> @@ -59,7 +59,7 @@
>  [SetupData]
>  DefaultPath = \ReactOS
>  OsLoadOptions = "/NOGUIBOOT /NODEBUG"
> -DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE / 
> KDSERIAL"
> +DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=COM1 /FIRSTCHANCE"
>  ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=SCREEN"
>  ;OsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS"

[Timo Kreuzer]

Am 05.03.2011 10:03, schrieb Aleksey Bragin:
> Yes, throughout all years I used to type into the virtual machine 
> window (or real hardware's keyboard) in order to enter kdbg commands 
> in 1st, 2nd and 3rd stages. The default way for 2nd and 3rd remains 
> the same, but that commit changed default for the 1st stage, and that 
> was quite unexpected (there was even a bug report submitted for that). 
> Not to say that I didn't notice that commit back then, and was 
> wondering why sysreg3 is not able to enter any kdbg commands into 
> virtual box window when first stage of setup runs.
>
> On Mar 5, 2011, at 4:34 AM, Olaf Siejka wrote:
> > It causes issues in 1st stage access to kdbg. Simply speaking, 
> > instead of using vbox window focus to type in kdbg commands, those 
> > only work with terminal (like putty) window focus.

I don't consider this an "issue". Its normal behaviour and the way 
RosDbg works and sysreg as well (iirc) and I am used to work with it 
since ages, because it simply sucks to focus one window and have the 
text in another. If something is inconsistent here, then sysreg, using 
VBox window focus in 1st stage and serial in 2nd and 3rd stage. Or does 
the new sysreg suddenly use the window focus everywhere? Or only the one 
for windows while the one on linux still uses serial? That's again 
inconsistency. And please don't mistake your personal preference with 
consistency, for me and everyone using RosDbg its more consistent with 
kdserial :)

Timo

[Olaf Siejka]

I`m not sure if this is the only reason for sysreg3 to not being able to do
bt. It doesnt work in 2nd and later stages either. The real issue seems to
be in regcdtest itself, not within 1st stage kdserial. Just my 5 eurocents.

2011/3/5 Timo Kreuzer [e-mail]
> Am 05.03.2011 10:03, schrieb Aleksey Bragin:
>
> Yes, throughout all years I used to type into the virtual machine window
> > (or real hardware's keyboard) in order to enter kdbg commands in 1st, 2nd
> > and 3rd stages. The default way for 2nd and 3rd remains the same, but that
> > commit changed default for the 1st stage, and that was quite unexpected
> > (there was even a bug report submitted for that). Not to say that I didn't
> > notice that commit back then, and was wondering why sysreg3 is not able to
> > enter any kdbg commands into virtual box window when first stage of setup
> > runs.
> >
> > On Mar 5, 2011, at 4:34 AM, Olaf Siejka wrote:
> >
> > It causes issues in 1st stage access to kdbg. Simply speaking, instead of
> > > using vbox window focus to type in kdbg commands, those only work with
> > > terminal (like putty) window focus.
>
> I don't consider this an "issue". Its normal behaviour and the way RosDbg
> works and sysreg as well (iirc) and I am used to work with it since ages,
> because it simply sucks to focus one window and have the text in another. If
> something is inconsistent here, then sysreg, using VBox window focus in 1st
> stage and serial in 2nd and 3rd stage. Or does the new sysreg suddenly use
> the window focus everywhere? Or only the one for windows while the one on
> linux still uses serial? That's again inconsistency. And please don't
> mistake your personal preference with consistency, for me and everyone using
> RosDbg its more consistent with kdserial :)
>
> Timo
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Aleksey Bragin]

Maybe, but as for sysreg, I copied original behaviour to sysreg3, and  
it was sending keyboard scancodes to the virtual machine.

On Mar 5, 2011, at 2:00 PM, Olaf Siejka wrote:
> I`m not sure if this is the only reason for sysreg3 to not being  
> able to do bt. It doesnt work in 2nd and later stages either. The  
> real issue seems to be in regcdtest itself, not within 1st stage  
> kdserial. Just my 5 eurocents.
>
> 2011/3/5 Timo Kreuzer [e-mail]
> Am 05.03.2011 10:03, schrieb Aleksey Bragin:
>
> Yes, throughout all years I used to type into the virtual machine  
> window (or real hardware's keyboard) in order to enter kdbg  
> commands in 1st, 2nd and 3rd stages. The default way for 2nd and  
> 3rd remains the same, but that commit changed default for the 1st  
> stage, and that was quite unexpected (there was even a bug report  
> submitted for that). Not to say that I didn't notice that commit  
> back then, and was wondering why sysreg3 is not able to enter any  
> kdbg commands into virtual box window when first stage of setup runs.
>
> On Mar 5, 2011, at 4:34 AM, Olaf Siejka wrote:
>
> It causes issues in 1st stage access to kdbg. Simply speaking,  
> instead of using vbox window focus to type in kdbg commands, those  
> only work with terminal (like putty) window focus.
>
> I don't consider this an "issue". Its normal behaviour and the way  
> RosDbg works and sysreg as well (iirc) and I am used to work with  
> it since ages, because it simply sucks to focus one window and have  
> the text in another. If something is inconsistent here, then  
> sysreg, using VBox window focus in 1st stage and serial in 2nd and  
> 3rd stage. Or does the new sysreg suddenly use the window focus  
> everywhere? Or only the one for windows while the one on linux  
> still uses serial? That's again inconsistency. And please don't  
> mistake your personal preference with consistency, for me and  
> everyone using RosDbg its more consistent with kdserial :)
>
> Timo