Re: [ros-dev] [ros-diffs] [fireball] 23005: [FORMATTING] / [AUDIT] - Cleanup a big coding-style mess - Add UNIMPLEMENTED macro in empty functions (otherwise we will never know if they are being called by a 3rd-party driver) - Add proper debug headers inclusion in every file - Add documentation headers into almost every file (except mcb.c and context.c - will be added later) - Standardize per-file headers (some files still lack contributors names, they will be added later too) No code change except for addin

[Alex Ionescu]

fireball(a)svn.reactos.org wrote:
>   Author: fireball
>  Date: Tue Jul 11 01:03:26 2006
>  New Revision: 23005
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=23005&view=rev
>  Log:
>  [FORMATTING] / [AUDIT]
>  - Cleanup a big coding-style mess
>  - Add UNIMPLEMENTED macro in empty functions (otherwise we will never know if they are
> being called by a 3rd-party driver)
>  - Add proper debug headers inclusion in every file
>  - Add documentation headers into almost every file (except mcb.c and context.c - will be
> added later)
>  - Standardize per-file headers (some files still lack contributors names, they will be
> added later too)
>  
>  No code change except for adding UNIMPLEMENTED macros in the code. Name.c unlocked
> because the implementations of functions are trivial and in fact could be derived from
> their names. Not documented functions will be further reviewed.
>   
Good work... two things:

1) I think Brandon wrote a tool which does documentation headers using
TinyKRNL syntax. Since ROS's is the same (afaik), maybe you could talk
to him about it instead of doing everything by hand :).

2) Most of the functions are documented in te IFS, I'm not aware of any
undocumented FsRtl stuff... Captive also has implementations for nearly
all of them, and Captive was clean-roomed.

Best regards,
Alex Ionescu