RE: [ros-diffs] [mbosma] 20543: fix typos.

[Murphy, Ged (Bolton)]

This should really be

while( GetMessage( &msg, NULL, 0, 0 ) > 0 )

as GetMessage returns <0 on failure.
It will then break on failure or WM_QUIT

Just being anal though as GetMessage should never really fail  ;)

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: 03 January 2006 11:50
To: [e-mail]
Subject: [ros-diffs] [mbosma] 20543: fix typos.

+	while(GetMessage(&msg,NULL,0,0))
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
[e-mail] 
mailto:[e-mail] and then delete this message.

Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com

[Thomas Weidenmueller]

Murphy, Ged (Bolton) wrote:
> This should really be
>
> while( GetMessage( &msg, NULL, 0, 0 ) > 0 )
>
> as GetMessage returns <0 on failure.
> It will then break on failure or WM_QUIT
>
> Just being anal though as GetMessage should never really fail  ;)

See
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/WinUI...

The loop shouldn't be broken if GetMessage returns -1.

- Thomas

[Maarten Bosma]

BTW: I don't know what ros-diff did here. I just changed one line in main.c.

Maarten Bosma

Murphy, Ged (Bolton) wrote:
> This should really be
>
> while( GetMessage( &msg, NULL, 0, 0 ) > 0 )
>
> as GetMessage returns <0 on failure.
> It will then break on failure or WM_QUIT
>
> Just being anal though as GetMessage should never really fail  ;)
>
> -----Original Message-----
> *From:* [e-mail] [mailto:[e-mail]]
> *Sent:* 03 January 2006 11:50
> *To:* [e-mail]
> *Subject:* [ros-diffs] [mbosma] 20543: fix typos.
> while(GetMessage(&msg,NULL,0,0))