Re: [ros-dev] [ion] 54323: [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs).

[Aleksey Bragin]

I'm getting questions, if it's "just formatting and no code changes", 
why author names are removed for good and not readded in the new file?

WBR,
Aleksey Bragin.

On 07.11.2011 3:01, [e-mail] wrote:
> Author: ion
> Date: Sun Nov  6 23:01:04 2011
> New Revision: 54323
>
> URL: http://svn.reactos.org/svn/reactos?rev=54323&view=rev
> Log:
> [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs).
> Removed: trunk/reactos/dll/win32/kernel32/client/file/curdir.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/f...
> ==============================================================================
> --- trunk/reactos/dll/win32/kernel32/client/file/curdir.c [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/kernel32/client/file/curdir.c (removed)
> @@ -1,388 +1,0 @@
> -/* $Id$
> COPYRIGHT:       See COPYING in the top level directory
> PROJECT:         ReactOS system libraries
> FILE:            lib/kernel32/file/curdir.c
> PURPOSE:         Current directory functions
> PROGRAMMER:      Eric Kohl
>              Filip Navara
>              Steven Edwards
>              Thomas Weidenmueller
>              Gunnar Andre' Dalsnes
> UPDATE HISTORY:
>              Created 30/09/98
> */

[Alex Ionescu]

You do realize that the author names on top of 99% of the files in kernel32 are stale, right?

Would you like me to go over each file and add the current up-to-date author information? I don't mind...

As a side note, all those APIs were then rewritten in the new file in a further commit.

--
Best regards,
Alex Ionescu

On 2011-11-15, at 7:01 AM, Aleksey Bragin wrote:
> I'm getting questions, if it's "just formatting and no code changes", why author names are removed for good and not readded in the new file?
>
> WBR,
> Aleksey Bragin.
>
> On 07.11.2011 3:01, [e-mail] wrote:
> > Author: ion
> > Date: Sun Nov  6 23:01:04 2011
> > New Revision: 54323
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=54323&view=rev
> > Log:
> > [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs).
> > Removed: trunk/reactos/dll/win32/kernel32/client/file/curdir.c
> > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/f...
> > ==============================================================================
> > --- trunk/reactos/dll/win32/kernel32/client/file/curdir.c [iso-8859-1] (original)
> > +++ trunk/reactos/dll/win32/kernel32/client/file/curdir.c (removed)
> > @@ -1,388 +1,0 @@
> > -/* $Id$
> > COPYRIGHT:       See COPYING in the top level directory
> > PROJECT:         ReactOS system libraries
> > FILE:            lib/kernel32/file/curdir.c
> > PURPOSE:         Current directory functions
> > PROGRAMMER:      Eric Kohl
> >              Filip Navara
> >              Steven Edwards
> >              Thomas Weidenmueller
> >              Gunnar Andre' Dalsnes
> > UPDATE HISTORY:
> >              Created 30/09/98
> > */
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Aleksey Bragin]

On 15.11.2011 20:56, Alex Ionescu wrote:
> You do realize that the author names on top of 99% of the files in kernel32 are stale, right?

Nope, and I guess 99% of those who look there don't realize either.
> Would you like me to go over each file and add the current up-to-date author information? I don't mind...

I think it would be a waste of your time. I would be very grateful if 
you just make it up to date for the files you change, and those which 
remain - I will find someone to dig through the SVN blame information, 
pick major contributors and put them into the headers.
> As a side note, all those APIs were then rewritten in the new file in a further commit.

That's what I supposed to be the reason.
> --
> Best regards,
> Alex Ionescu
>
> On 2011-11-15, at 7:01 AM, Aleksey Bragin wrote:
> > I'm getting questions, if it's "just formatting and no code changes", why author names are removed for good and not readded in the new file?
> >
> > WBR,
> > Aleksey Bragin.
> >
> > On 07.11.2011 3:01, [e-mail] wrote:
> > > Author: ion
> > > Date: Sun Nov  6 23:01:04 2011
> > > New Revision: 54323
> > >
> > > URL: http://svn.reactos.org/svn/reactos?rev=54323&view=rev
> > > Log:
> > > [KERNEL32]: Move the "curdir.c" APIs into path.c as well, as they are Path APIs. No code changes (just formatting and moving to DPRINTs).
> > > Removed: trunk/reactos/dll/win32/kernel32/client/file/curdir.c
> > > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/f...
> > > ==============================================================================
> > > --- trunk/reactos/dll/win32/kernel32/client/file/curdir.c [iso-8859-1] (original)
> > > +++ trunk/reactos/dll/win32/kernel32/client/file/curdir.c (removed)
> > > @@ -1,388 +1,0 @@
> > > -/* $Id$
> > > COPYRIGHT:       See COPYING in the top level directory
> > > PROJECT:         ReactOS system libraries
> > > FILE:            lib/kernel32/file/curdir.c
> > > PURPOSE:         Current directory functions
> > > PROGRAMMER:      Eric Kohl
> > >              Filip Navara
> > >              Steven Edwards
> > >              Thomas Weidenmueller
> > >              Gunnar Andre' Dalsnes
> > > UPDATE HISTORY:
> > >              Created 30/09/98
> > > */