Re: [ros-dev] [ros-diffs] [greatlrd] 25794: patch from Physicus, implement TOOLTIPS_NotifyFormat, it now retrurn the type of the string if it unicode or ansi. before it did not return any type at all. it did a heap crash from downloader mangers when it try figout what type of sting the toolstips use. it is tested in 0.3.1 and not whole implemnent is tested yet. it should be right for all case.

[Ged Murphy]

[e-mail] wrote:
> URL: http://svn.reactos.org/svn/reactos?rev=25794&view=rev
> Log:
> patch from Physicus,

Did anyone actually bother to read Thomas' last email about keeping our 
comctl32 in line with Wines?

[James Tabor]

Hi All!

Ged Murphy wrote:
> [e-mail] wrote:
> > URL: http://svn.reactos.org/svn/reactos?rev=25794&view=rev
> > Log:
> > patch from Physicus,
>
> Did anyone actually bother to read Thomas' last email about keeping our 
> comctl32 in line with Wines?

Anyone can give that a try. But,,, If the patch was tested with ReactOS and
given to wine. I know there is one chance in hell, the wineries will except it.

Good luck,
James

[Ged Murphy]

James Tabor wrote:
> Hi All!
>
> Ged Murphy wrote:
> > [e-mail] wrote:
> >
> > Did anyone actually bother to read Thomas' last email about keeping our 
> > comctl32 in line with Wines?
>
> Anyone can give that a try. But,,, If the patch was tested with ReactOS and
> given to wine. I know there is one chance in hell, the wineries will except it.

IIRC, Julliard stated that if test cases were submitted along with the 
patch, he would accept code.

[Saveliy Tretiakov]

Ged Murphy пишет:
> IIRC, Julliard stated that if test cases were submitted along with the 
> patch, he would accept code.

No, not always. My rpc code with testcases was not accepted, because it 
was from reactos.

[Aleksey Bragin]

I really suggest Timo should submit a patch to Wine, it'll be easier  
to sync later and avoid conflicts.

Will it be accepted or not, this is Alexandre's decision, but Timo  
should give it a try.

WBR,
Aleksey Bragin.

On Feb 14, 2007, at 1:35 AM, Ged Murphy wrote:
> James Tabor wrote:
> > Hi All!
> >
> > Ged Murphy wrote:
> > > [e-mail] wrote:
> > >
> > > Did anyone actually bother to read Thomas' last email about  
> > > keeping our
> > > comctl32 in line with Wines?
> >
> > Anyone can give that a try. But,,, If the patch was tested with  
> > ReactOS and
> > given to wine. I know there is one chance in hell, the wineries  
> > will except it.
>
> IIRC, Julliard stated that if test cases were submitted along with the
> patch, he would accept code.

[Timo Kreuzer]

I am currently working on updating the winetest for comctl to show it. 
And I will update my patch for wine, so it will also handle 
PSN_QUERYINITIALFOCUS. I still have some probs to get the winetest work 
as I want it to:
The test creates a modeless PropSheet with one Page and does not handle 
system messages. PSN_QUERYINITIALFOCUS is only sent to the first page, 
when an edit control is present, second page does not recieve that 
notification. I tried a second thread to handle messages and wait using 
system("PAUSE"), but no change. Can someone tell me how to write a 
testcase that will handle all that messages and still return when all 
tests are finished?

That was about the first patch. The second one: It was only a quick 
suggestion. Never tested it, not even sure if this one is fully correct. 
It was simply an enhancment to GreatLord's hack (so I leave it up to 
GreatLord to provide a testcase) ;-) He said it would fix the problem 
with downloader, but it doesn't seem to work for me. (And if it does it 
is still not the real problem, as downloader should not crash (or 
freeze) ROS when a usermode function is not implemented.) Can anyone 
acknowledge, that (even after the patch) it freezes ROS? Maybe it's only 
me. I used 0.3.1 iso from GreatLord with VMWare Server 1.0.1. It happens 
most of the time sometimes I start ROS and downloader works without any 
probs several times. I think we should fix that bug before releasing, if 
possible.

When I have finished the test and updated the patch, can someone with 
better contact to wine submit that patch, maybe someone who reads wine 
mailing lists etc.?

Aleksey Bragin schrieb:
> I really suggest Timo should submit a patch to Wine, it'll be easier  
> to sync later and avoid conflicts.
>
> Will it be accepted or not, this is Alexandre's decision, but Timo  
> should give it a try.
>
> WBR,
> Aleksey Bragin.