Revert this change it is incorrect change u have made. I told u do not change it and it is not a bug in the apps,
you are hidding the real bug with this that u did found with your consle apps calc and other apps working in ros.
revert this changes as ASAP
DS_SHELLLFONT is a EXSTYLE EXSTYLE DS_SHELLFONT have same value as EXSTYLE WS_EX_TOPMOST | WS_EX_MDICHILD and posible some others types as well.
Revision: 22742 Author: janderwald Date: 20:04:00, den 1 juli 2006 Message: * DS_SHELLFONT is an style not an EXSTYLE. ---- Modified : /trunk/reactos/base/applications/calc/Cz.rc Modified : /trunk/reactos/base/applications/calc/De.rc Modified : /trunk/reactos/base/applications/calc/En.rc Modified : /trunk/reactos/base/applications/calc/Es.rc Modified : /trunk/reactos/base/applications/calc/Fr.rc Modified : /trunk/reactos/base/applications/calc/Hu.rc Modified : /trunk/reactos/base/applications/calc/It.rc Modified : /trunk/reactos/base/applications/calc/Ja.rc Modified : /trunk/reactos/base/applications/calc/Nl.rc Modified : /trunk/reactos/base/applications/calc/Pt.rc Modified : /trunk/reactos/base/applications/calc/Ru.rc Modified : /trunk/reactos/base/applications/calc/Sv.rc Modified : /trunk/reactos/base/applications/calc/Uk.rc Modified : /trunk/reactos/base/applications/control/control.c Modified : /trunk/reactos/base/applications/games/solitaire/de.rc Modified : /trunk/reactos/base/applications/games/solitaire/en.rc Modified : /trunk/reactos/base/applications/games/winemine/De.rc Modified : /trunk/reactos/base/applications/games/winemine/En.rc Modified : /trunk/reactos/base/applications/games/winemine/Fr.rc Modified : /trunk/reactos/base/applications/games/winemine/Nl.rc Modified : /trunk/reactos/base/applications/games/winemine/Pl.rc Modified : /trunk/reactos/base/applications/getfirefox/De.rc Modified : /trunk/reactos/base/applications/getfirefox/En.rc Modified : /trunk/reactos/base/applications/getfirefox/Fr.rc Modified : /trunk/reactos/base/applications/getfirefox/Hu.rc Modified : /trunk/reactos/base/applications/getfirefox/Nl.rc Modified : /trunk/reactos/base/applications/getfirefox/Ru.rc Modified : /trunk/reactos/base/applications/getfirefox/Sv.rc Modified : /trunk/reactos/base/applications/getfirefox/Uk.rc Modified : /trunk/reactos/base/applications/ibrowser/De.rc Modified : /trunk/reactos/base/applications/ibrowser/En.rc Modified : /trunk/reactos/base/applications/ibrowser/Nl.rc Modified : /trunk/reactos/base/applications/imagesoft/En.rc Modified : /trunk/reactos/base/applications/msconfig/De.rc Modified : /trunk/reactos/base/applications/msconfig/En.rc Modified : /trunk/reactos/base/applications/msconfig/Fr.rc Modified : /trunk/reactos/base/applications/msconfig/Hu.rc Modified : /trunk/reactos/base/applications/msconfig/Nl.rc Modified : /trunk/reactos/base/applications/msconfig/No.rc Modified : /trunk/reactos/base/applications/notepad/res/Cs.rc Modified : /trunk/reactos/base/applications/notepad/res/Da.rc Modified : /trunk/reactos/base/applications/notepad/res/De.rc Modified : /trunk/reactos/base/applications/notepad/res/En.rc Modified : /trunk/reactos/base/applications/notepad/res/Es.rc Modified : /trunk/reactos/base/applications/notepad/res/Fi.rc Modified : /trunk/reactos/base/applications/notepad/res/Fr.rc Modified : /trunk/reactos/base/applications/notepad/res/Gr.rc Modified : /trunk/reactos/base/applications/notepad/res/Hu.rc Modified : /trunk/reactos/base/applications/notepad/res/It.rc Modified : /trunk/reactos/base/applications/notepad/res/Ja.rc Modified : /trunk/reactos/base/applications/notepad/res/Nl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pt.rc Modified : /trunk/reactos/base/applications/notepad/res/Ru.rc Modified : /trunk/reactos/base/applications/notepad/res/Si.rc Modified : /trunk/reactos/base/applications/notepad/res/Sk.rc Modified : /trunk/reactos/base/applications/notepad/res/Sv.rc Modified : /trunk/reactos/base/applications/notepad/res/Th.rc Modified : /trunk/reactos/base/applications/notepad/res/Uk.rc Modified : /trunk/reactos/base/applications/notepad/res/Wa.rc Modified : /trunk/reactos/base/applications/notepad/res/Zh.rc Modified : /trunk/reactos/base/applications/regedit/Cz.rc Modified : /trunk/reactos/base/applications/regedit/De.rc Modified : /trunk/reactos/base/applications/regedit/En.rc Modified : /trunk/reactos/base/applications/regedit/Es.rc Modified : /trunk/reactos/base/applications/regedit/Fr.rc Modified : /trunk/reactos/base/applications/regedit/Hu.rc Modified : /trunk/reactos/base/applications/regedit/It.rc Modified : /trunk/reactos/base/applications/regedit/Ja.rc Modified : /trunk/reactos/base/applications/regedit/Nl.rc Modified : /trunk/reactos/base/applications/regedit/Pl.rc Modified : /trunk/reactos/base/applications/regedit/Pt.rc Modified : /trunk/reactos/base/applications/regedit/Ru.rc Modified : /trunk/reactos/base/applications/regedit/Si.rc Modified : /trunk/reactos/base/applications/regedit/Sv.rc Modified : /trunk/reactos/base/applications/reporterror/Ja.rc Modified : /trunk/reactos/base/applications/reporterror/Nl.rc Modified : /trunk/reactos/base/applications/reporterror/de.rc Modified : /trunk/reactos/base/applications/reporterror/dk.rc Modified : /trunk/reactos/base/applications/reporterror/en.rc Modified : /trunk/reactos/base/applications/reporterror/hu.rc Modified : /trunk/reactos/base/applications/reporterror/ru.rc Modified : /trunk/reactos/base/applications/reporterror/sv.rc Modified : /trunk/reactos/base/applications/screensavers/matrix/matrix.rc Modified : /trunk/reactos/base/applications/servman/De.rc Modified : /trunk/reactos/base/applications/servman/En.rc Modified : /trunk/reactos/base/applications/servman/Ru.rc Modified : /trunk/reactos/base/applications/sndvol32/Cz.rc Modified : /trunk/reactos/base/applications/sndvol32/De.rc Modified : /trunk/reactos/base/applications/sndvol32/En.rc Modified : /trunk/reactos/base/applications/sndvol32/Fr.rc Modified : /trunk/reactos/base/applications/sndvol32/Hu.rc Modified : /trunk/reactos/base/applications/sndvol32/Ja.rc Modified : /trunk/reactos/base/applications/sndvol32/Nl.rc Modified : /trunk/reactos/base/applications/sndvol32/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Cz.rc Modified : /trunk/reactos/base/applications/taskmgr/De.rc Modified : /trunk/reactos/base/applications/taskmgr/Dk.rc Modified : /trunk/reactos/base/applications/taskmgr/En.rc Modified : /trunk/reactos/base/applications/taskmgr/Es.rc Modified : /trunk/reactos/base/applications/taskmgr/Fr.rc Modified : /trunk/reactos/base/applications/taskmgr/Hu.rc Modified : /trunk/reactos/base/applications/taskmgr/Ja.rc Modified : /trunk/reactos/base/applications/taskmgr/Nl.rc Modified : /trunk/reactos/base/applications/taskmgr/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Uk.rc Modified : /trunk/reactos/base/applications/winefile/Sv.rc Modified : /trunk/reactos/base/applications/winefile/cs.rc Modified : /trunk/reactos/base/applications/winefile/de.rc Modified : /trunk/reactos/base/applications/winefile/en.rc Modified : /trunk/reactos/base/applications/winefile/es.rc Modified : /trunk/reactos/base/applications/winefile/fr.rc Modified : /trunk/reactos/base/applications/winefile/hu.rc Modified : /trunk/reactos/base/applications/winefile/it.rc Modified : /trunk/reactos/base/applications/winefile/nl.rc Modified : /trunk/reactos/base/applications/winefile/pl.rc Modified : /trunk/reactos/base/applications/winefile/pt.rc Modified : /trunk/reactos/base/applications/winefile/ru.rc Modified : /trunk/reactos/base/applications/winefile/si.rc Modified : /trunk/reactos/base/applications/winefile/zh.rc Modified : /trunk/reactos/base/applications/wordpad/En.rc
Sorry janderwald
1. the problem was in the patch from EmuandCo commit to 22668 it has some other issuse as well. Please review a patch before commit a patch from others. EmuandCo patcher have always some issue minnor or biger issue. I am saying sorry to u.
----- Original Message ----- From: Magnus Olsen To: ReactOS Development List Sent: Sunday, July 02, 2006 2:07 AM Subject: [ros-dev] revert Revision: 22742
Revert this change it is incorrect change u have made. I told u do not change it and it is not a bug in the apps,
you are hidding the real bug with this that u did found with your consle apps calc and other apps working in ros.
revert this changes as ASAP
DS_SHELLLFONT is a EXSTYLE EXSTYLE DS_SHELLFONT have same value as EXSTYLE WS_EX_TOPMOST | WS_EX_MDICHILD and posible some others types as well.
Revision: 22742 Author: janderwald Date: 20:04:00, den 1 juli 2006 Message: * DS_SHELLFONT is an style not an EXSTYLE. ---- Modified : /trunk/reactos/base/applications/calc/Cz.rc Modified : /trunk/reactos/base/applications/calc/De.rc Modified : /trunk/reactos/base/applications/calc/En.rc Modified : /trunk/reactos/base/applications/calc/Es.rc Modified : /trunk/reactos/base/applications/calc/Fr.rc Modified : /trunk/reactos/base/applications/calc/Hu.rc Modified : /trunk/reactos/base/applications/calc/It.rc Modified : /trunk/reactos/base/applications/calc/Ja.rc Modified : /trunk/reactos/base/applications/calc/Nl.rc Modified : /trunk/reactos/base/applications/calc/Pt.rc Modified : /trunk/reactos/base/applications/calc/Ru.rc Modified : /trunk/reactos/base/applications/calc/Sv.rc Modified : /trunk/reactos/base/applications/calc/Uk.rc Modified : /trunk/reactos/base/applications/control/control.c Modified : /trunk/reactos/base/applications/games/solitaire/de.rc Modified : /trunk/reactos/base/applications/games/solitaire/en.rc Modified : /trunk/reactos/base/applications/games/winemine/De.rc Modified : /trunk/reactos/base/applications/games/winemine/En.rc Modified : /trunk/reactos/base/applications/games/winemine/Fr.rc Modified : /trunk/reactos/base/applications/games/winemine/Nl.rc Modified : /trunk/reactos/base/applications/games/winemine/Pl.rc Modified : /trunk/reactos/base/applications/getfirefox/De.rc Modified : /trunk/reactos/base/applications/getfirefox/En.rc Modified : /trunk/reactos/base/applications/getfirefox/Fr.rc Modified : /trunk/reactos/base/applications/getfirefox/Hu.rc Modified : /trunk/reactos/base/applications/getfirefox/Nl.rc Modified : /trunk/reactos/base/applications/getfirefox/Ru.rc Modified : /trunk/reactos/base/applications/getfirefox/Sv.rc Modified : /trunk/reactos/base/applications/getfirefox/Uk.rc Modified : /trunk/reactos/base/applications/ibrowser/De.rc Modified : /trunk/reactos/base/applications/ibrowser/En.rc Modified : /trunk/reactos/base/applications/ibrowser/Nl.rc Modified : /trunk/reactos/base/applications/imagesoft/En.rc Modified : /trunk/reactos/base/applications/msconfig/De.rc Modified : /trunk/reactos/base/applications/msconfig/En.rc Modified : /trunk/reactos/base/applications/msconfig/Fr.rc Modified : /trunk/reactos/base/applications/msconfig/Hu.rc Modified : /trunk/reactos/base/applications/msconfig/Nl.rc Modified : /trunk/reactos/base/applications/msconfig/No.rc Modified : /trunk/reactos/base/applications/notepad/res/Cs.rc Modified : /trunk/reactos/base/applications/notepad/res/Da.rc Modified : /trunk/reactos/base/applications/notepad/res/De.rc Modified : /trunk/reactos/base/applications/notepad/res/En.rc Modified : /trunk/reactos/base/applications/notepad/res/Es.rc Modified : /trunk/reactos/base/applications/notepad/res/Fi.rc Modified : /trunk/reactos/base/applications/notepad/res/Fr.rc Modified : /trunk/reactos/base/applications/notepad/res/Gr.rc Modified : /trunk/reactos/base/applications/notepad/res/Hu.rc Modified : /trunk/reactos/base/applications/notepad/res/It.rc Modified : /trunk/reactos/base/applications/notepad/res/Ja.rc Modified : /trunk/reactos/base/applications/notepad/res/Nl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pt.rc Modified : /trunk/reactos/base/applications/notepad/res/Ru.rc Modified : /trunk/reactos/base/applications/notepad/res/Si.rc Modified : /trunk/reactos/base/applications/notepad/res/Sk.rc Modified : /trunk/reactos/base/applications/notepad/res/Sv.rc Modified : /trunk/reactos/base/applications/notepad/res/Th.rc Modified : /trunk/reactos/base/applications/notepad/res/Uk.rc Modified : /trunk/reactos/base/applications/notepad/res/Wa.rc Modified : /trunk/reactos/base/applications/notepad/res/Zh.rc Modified : /trunk/reactos/base/applications/regedit/Cz.rc Modified : /trunk/reactos/base/applications/regedit/De.rc Modified : /trunk/reactos/base/applications/regedit/En.rc Modified : /trunk/reactos/base/applications/regedit/Es.rc Modified : /trunk/reactos/base/applications/regedit/Fr.rc Modified : /trunk/reactos/base/applications/regedit/Hu.rc Modified : /trunk/reactos/base/applications/regedit/It.rc Modified : /trunk/reactos/base/applications/regedit/Ja.rc Modified : /trunk/reactos/base/applications/regedit/Nl.rc Modified : /trunk/reactos/base/applications/regedit/Pl.rc Modified : /trunk/reactos/base/applications/regedit/Pt.rc Modified : /trunk/reactos/base/applications/regedit/Ru.rc Modified : /trunk/reactos/base/applications/regedit/Si.rc Modified : /trunk/reactos/base/applications/regedit/Sv.rc Modified : /trunk/reactos/base/applications/reporterror/Ja.rc Modified : /trunk/reactos/base/applications/reporterror/Nl.rc Modified : /trunk/reactos/base/applications/reporterror/de.rc Modified : /trunk/reactos/base/applications/reporterror/dk.rc Modified : /trunk/reactos/base/applications/reporterror/en.rc Modified : /trunk/reactos/base/applications/reporterror/hu.rc Modified : /trunk/reactos/base/applications/reporterror/ru.rc Modified : /trunk/reactos/base/applications/reporterror/sv.rc Modified : /trunk/reactos/base/applications/screensavers/matrix/matrix.rc Modified : /trunk/reactos/base/applications/servman/De.rc Modified : /trunk/reactos/base/applications/servman/En.rc Modified : /trunk/reactos/base/applications/servman/Ru.rc Modified : /trunk/reactos/base/applications/sndvol32/Cz.rc Modified : /trunk/reactos/base/applications/sndvol32/De.rc Modified : /trunk/reactos/base/applications/sndvol32/En.rc Modified : /trunk/reactos/base/applications/sndvol32/Fr.rc Modified : /trunk/reactos/base/applications/sndvol32/Hu.rc Modified : /trunk/reactos/base/applications/sndvol32/Ja.rc Modified : /trunk/reactos/base/applications/sndvol32/Nl.rc Modified : /trunk/reactos/base/applications/sndvol32/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Cz.rc Modified : /trunk/reactos/base/applications/taskmgr/De.rc Modified : /trunk/reactos/base/applications/taskmgr/Dk.rc Modified : /trunk/reactos/base/applications/taskmgr/En.rc Modified : /trunk/reactos/base/applications/taskmgr/Es.rc Modified : /trunk/reactos/base/applications/taskmgr/Fr.rc Modified : /trunk/reactos/base/applications/taskmgr/Hu.rc Modified : /trunk/reactos/base/applications/taskmgr/Ja.rc Modified : /trunk/reactos/base/applications/taskmgr/Nl.rc Modified : /trunk/reactos/base/applications/taskmgr/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Uk.rc Modified : /trunk/reactos/base/applications/winefile/Sv.rc Modified : /trunk/reactos/base/applications/winefile/cs.rc Modified : /trunk/reactos/base/applications/winefile/de.rc Modified : /trunk/reactos/base/applications/winefile/en.rc Modified : /trunk/reactos/base/applications/winefile/es.rc Modified : /trunk/reactos/base/applications/winefile/fr.rc Modified : /trunk/reactos/base/applications/winefile/hu.rc Modified : /trunk/reactos/base/applications/winefile/it.rc Modified : /trunk/reactos/base/applications/winefile/nl.rc Modified : /trunk/reactos/base/applications/winefile/pl.rc Modified : /trunk/reactos/base/applications/winefile/pt.rc Modified : /trunk/reactos/base/applications/winefile/ru.rc Modified : /trunk/reactos/base/applications/winefile/si.rc Modified : /trunk/reactos/base/applications/winefile/zh.rc Modified : /trunk/reactos/base/applications/wordpad/En.rc
------------------------------------------------------------------------------
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Hi! Magnus Olsen wrote:
Sorry janderwald
- the problem was in the patch from EmuandCo commit to 22668
it has some other issuse as well. Please review a patch before commit a patch from others. EmuandCo patcher have always some issue minnor or biger issue. I am saying sorry to u.
DS_SHELLLFONT is a EXSTYLE EXSTYLE DS_SHELLFONT have same value as EXSTYLE WS_EX_TOPMOST | WS_EX_MDICHILD and posible some others types as well.
Yeah! There is a bug in ntuser/window.c alright!. I synced mdi.c and modified mtuser/window.c too. It does show the problem. The child window parent is the desktop and so its on the desktop. 8^) It works and you can select files and directories. I haven't seen anything like it since 1999.
Thanks, James
-
James Tabor -
Magnus Olsen