NDK

[dmex]

The NDK has allot of 64bit alignment issues mostly from omitted SIZE_T
fields, There's at least 20 or so other structures with issues but here's
two corrected structures below:

typedef struct _SYSTEM_VERIFIER_INFORMATION
{
   ULONG NextEntryOffset;
   ULONG Level;
   UNICODE_STRING DriverName;
   ULONG RaiseIrqls;
   ULONG AcquireSpinLocks;
   ULONG SynchronizeExecutions;
   ULONG AllocationsAttempted;
   ULONG AllocationsSucceeded;
   ULONG AllocationsSucceededSpecialPool;
   ULONG AllocationsWithNoTag;
   ULONG TrimRequests;
   ULONG Trims;
   ULONG AllocationsFailed;
   ULONG AllocationsFailedDeliberately;
   ULONG Loads;
   ULONG Unloads;
   ULONG UnTrackedPool;
   ULONG CurrentPagedPoolAllocations;
   ULONG CurrentNonPagedPoolAllocations;
   ULONG PeakPagedPoolAllocations;
   ULONG PeakNonPagedPoolAllocations;
   SIZE_T PagedPoolUsageInBytes;
   SIZE_T NonPagedPoolUsageInBytes;
   SIZE_T PeakPagedPoolUsageInBytes;
   SIZE_T PeakNonPagedPoolUsageInBytes;
} SYSTEM_VERIFIER_INFORMATION, *PSYSTEM_VERIFIER_INFORMATION;

// Class 22
typedef struct _SYSTEM_POOLTAG
{
    union
    {
        UCHAR Tag[4];	
        ULONG TagUlong;
    };
    ULONG PagedAllocs;
    ULONG PagedFrees;
    SIZE_T PagedUsed;
    ULONG NonPagedAllocs;
    ULONG NonPagedFrees;
    SIZE_T NonPagedUsed;
} SYSTEM_POOLTAG, *PSYSTEM_POOLTAG;

[Samuel Serapión]

Thanks a lot for the report! We accept patches(tm). I have a deep
interest in 64bit reactos. I would gladly help determine further
issues and commit fixes as necessary, but I don't have trunk access.
Hopefully, we can get some helpful dev to commit them.

On Thu, Sep 29, 2011 at 1:34 AM, dmex [e-mail] wrote:
> The NDK has allot of 64bit alignment issues mostly from omitted SIZE_T
> fields, There's at least 20 or so other structures with issues but here's
> two corrected structures below:
>
> typedef struct _SYSTEM_VERIFIER_INFORMATION
> {
>   ULONG NextEntryOffset;
>   ULONG Level;
>   UNICODE_STRING DriverName;
>   ULONG RaiseIrqls;
>   ULONG AcquireSpinLocks;
>   ULONG SynchronizeExecutions;
>   ULONG AllocationsAttempted;
>   ULONG AllocationsSucceeded;
>   ULONG AllocationsSucceededSpecialPool;
>   ULONG AllocationsWithNoTag;
>   ULONG TrimRequests;
>   ULONG Trims;
>   ULONG AllocationsFailed;
>   ULONG AllocationsFailedDeliberately;
>   ULONG Loads;
>   ULONG Unloads;
>   ULONG UnTrackedPool;
>   ULONG CurrentPagedPoolAllocations;
>   ULONG CurrentNonPagedPoolAllocations;
>   ULONG PeakPagedPoolAllocations;
>   ULONG PeakNonPagedPoolAllocations;
>   SIZE_T PagedPoolUsageInBytes;
>   SIZE_T NonPagedPoolUsageInBytes;
>   SIZE_T PeakPagedPoolUsageInBytes;
>   SIZE_T PeakNonPagedPoolUsageInBytes;
> } SYSTEM_VERIFIER_INFORMATION, *PSYSTEM_VERIFIER_INFORMATION;
>
> // Class 22
> typedef struct _SYSTEM_POOLTAG
> {
>    union
>    {
>        UCHAR Tag[4];
>        ULONG TagUlong;
>    };
>    ULONG PagedAllocs;
>    ULONG PagedFrees;
>    SIZE_T PagedUsed;
>    ULONG NonPagedAllocs;
>    ULONG NonPagedFrees;
>    SIZE_T NonPagedUsed;
> } SYSTEM_POOLTAG, *PSYSTEM_POOLTAG;
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

Am 29.09.2011 07:34, schrieb dmex:
> The NDK has allot of 64bit alignment issues mostly from omitted SIZE_T
> fields, There's at least 20 or so other structures with issues but here's
> two corrected structures below:

Could you provide the names of these structures (or even better fixed 
versions)?

Thanks
Timo

[dmex]

Process Hacker has all the correct definitions, Maybe over the weekend I'll
go through all the types and create a patch.

Kinda hoping Alex Ionescu will test/update the NDK though?

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Timo Kreuzer
Sent: Friday, 30 September 2011 6:51 PM
To: ReactOS Development List
Subject: Re: [ros-dev] NDK

Am 29.09.2011 07:34, schrieb dmex:
> The NDK has allot of 64bit alignment issues mostly from omitted SIZE_T 
> fields, There's at least 20 or so other structures with issues but 
> here's two corrected structures below:

Could you provide the names of these structures (or even better fixed
versions)?

Thanks
Timo

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Alex Ionescu]

Alex Ionescu will eventually merge the public, private, and ReactOS versions
of the NDK together to produce the most modern public copy.

ReactOS should use vendor import for the NDK to make this easier, after
that's done.

Best regards,
Alex Ionescu

On Fri, Sep 30, 2011 at 7:04 AM, dmex [e-mail] wrote:
> Process Hacker has all the correct definitions, Maybe over the weekend I'll
> go through all the types and create a patch.
>
> Kinda hoping Alex Ionescu will test/update the NDK though?
>
> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On
> Behalf Of Timo Kreuzer
> Sent: Friday, 30 September 2011 6:51 PM
> To: ReactOS Development List
> Subject: Re: [ros-dev] NDK
>
> Am 29.09.2011 07:34, schrieb dmex:
> > The NDK has allot of 64bit alignment issues mostly from omitted SIZE_T
> > fields, There's at least 20 or so other structures with issues but
> > here's two corrected structures below:
>
> Could you provide the names of these structures (or even better fixed
> versions)?
>
> Thanks
> Timo
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev