Re: [ros-dev] [ros-diffs] [vmikayelyan] 72388: usb: HUB: Add PnP state tracking Added PDO/FDO PnP state tracking, which is done according MSDN's "State Transitions for PnP Devices" topic.

[Hervé Poussineau]

Hi,

Le 19/08/2016 à 18:46, [e-mail] a écrit :
> Author: vmikayelyan
> Date: Fri Aug 19 16:46:18 2016
> New Revision: 72388
>
> URL: http://svn.reactos.org/svn/reactos?rev=72388&view=rev
> Log:
> usb: HUB: Add PnP state tracking
>
> Added PDO/FDO PnP state tracking, which is done according MSDN's
> "State Transitions for PnP Devices" topic.

[...]
> +#define INITIALIZE_PNP_STATE(Data) \
> +(Data).PnPState = NotStarted;\
> +(Data).PreviousPnPState = NotStarted;
>
> +#define SET_NEW_PNP_STATE(Data, state) \
> +(Data).PnPState = (Data).PnPState;\

You probably meant PreviousPnPState here...
> +(Data).PnPState = (state);
>
> +#define RESTORE_PREVIOUS_PNP_STATE(Data) \
> +(Data).PnPState = (Data).PreviousPnPState;

Hervé

[mvardan]

Hi Hervé,

Yes, this is copypasta. Thank you for review.

Vardan.

On Fri, Aug 19, 2016 at 11:27 PM, Hervé Poussineau [e-mail]
wrote:
> Hi,
>
> Le 19/08/2016 à 18:46, [e-mail] a écrit :
> > Author: vmikayelyan
> > Date: Fri Aug 19 16:46:18 2016
> > New Revision: 72388
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=72388&view=rev
> > Log:
> > usb: HUB: Add PnP state tracking
> >
> > Added PDO/FDO PnP state tracking, which is done according MSDN's
> > "State Transitions for PnP Devices" topic.
> >
> > [...]
>
> +#define INITIALIZE_PNP_STATE(Data) \
> > +(Data).PnPState = NotStarted;\
> > +(Data).PreviousPnPState = NotStarted;
> >
> > +#define SET_NEW_PNP_STATE(Data, state) \
> > +(Data).PnPState = (Data).PnPState;\
>
> You probably meant PreviousPnPState here...
>
> +(Data).PnPState = (state);
> > +#define RESTORE_PREVIOUS_PNP_STATE(Data) \
> > +(Data).PnPState = (Data).PreviousPnPState;
>
> Hervé
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev