Re: [ros-dev] [ros-diffs] [gschneider] 44543: [ntoskrnl] - The field ZeroInit should be initialized to zero - do that by assigning the message type directly - Fixes the hanging ntdll port winetest (it didn't get a CLIENT_DIED notification because the

[Gregor Schneider]

I'm pretty much sticking to the way it is done in most other places.
Ref:
http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&am...

2009/12/12 KJK::Hyperion [e-mail]
> [e-mail] wrote:
> > The field ZeroInit should be initialized to zero - do that by assigning
>
> the message type directly
>
> please do this by zero-initializing ZeroInit instead. Don't play with
> unions
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[KJK::Hyperion]

Gregor Schneider wrote:
> I'm pretty much sticking to the way it is done in most other places.

This is horrible

[Timo Kreuzer]

Gregor Schneider wrote:
> I'm pretty much sticking to the way it is done in most other places.
> Ref:
> http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&am...

I can only see
"ApiMessage.h.u2.ZeroInit = 0"

[Gregor Schneider]

After I changed all occurences to the wanted behaviour in r44549 - sure.
Thats how it looked like before the change:
http://git.reactos.org/?p=reactos.git&a=search&h=0fc25b028945a5595b9...
(the git link i first posted used head as reference)

2009/12/13 Timo Kreuzer [e-mail]
> Gregor Schneider wrote:
> > I'm pretty much sticking to the way it is done in most other places.
> > Ref:
> > http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&am...
>
> I can only see
> "ApiMessage.h.u2.ZeroInit = 0"
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev