patch for test/review

[Hartmut Birr]

Hi,

I've changed rbuild a little bit, that it can run on msys (on windows). 
The major changes are:
- The separator (slash or back slash), exepostfix and exeprefix are 
initialized from environment variables.
- The separators in the path for the system command are always converted 
for the host system.
- Our own build utilities must convert paths itself (bin2res).
It exist some problems with absolute paths on msys, because msys uses 
'/c/foo/bar' and windows 'c:\foo\bar' or 'c:/foo/bar'.

I've tested the patch on msys and on windows. I cannot test the patch on 
linux.

Currently, msys is the only way to use all cpus or cores for the build 
process on windows.

- Hartmut

[Filip Navara]

Hartmut Birr wrote:
> Currently, msys is the only way to use all cpus or cores for the build 
> process on windows.

Not correct, www.volny.cz/xnavara/mingw32-make.hyp.exe.bin (or 
www.volny.cz/xnavara/mingw32-make.exe, not sure which binary is the 
right one).

- Filip

[Hartmut Birr]

Filip Navara wrote:
> Hartmut Birr wrote:
> > Currently, msys is the only way to use all cpus or cores for the 
> > build process on windows.
>
> Not correct, www.volny.cz/xnavara/mingw32-make.hyp.exe.bin (or 
> www.volny.cz/xnavara/mingw32-make.exe, not sure which binary is the 
> right one).

mingw32-make can use multiple cpus or cores, if sh.exe is found on the 
path. Sh.exe (from msys) doesn't understand back slashes within paths. 
That is the reason why I try to use msys.

- Hartmut

PS: The date of your mail was the 1/1/2003.

[Filip Navara]

---- PŮVODNÍ ZPRÁVA -----
Od: "Hartmut Birr" [e-mail]
Komu: "ReactOS Development List" [e-mail]
Předmět: Re: [ros-dev] patch for test/review
Datum: 1.11.2005 - 13:34:19
> Filip Navara wrote:
> > Hartmut Birr wrote:
> > > Currently, msys is the only way to use all cpus or cores for
> > > the 
> > > build process on windows.
> >
> > Not correct, www.volny.cz/xnavara/mingw32-make.hyp.exe.bin
> > (or 
> > www.volny.cz/xnavara/mingw32-make.exe, not sure which binary
> > is the 
> > right one).
>
> mingw32-make can use multiple cpus or cores, if sh.exe is found
> on the 
> path. Sh.exe (from msys) doesn't understand back slashes within
> paths. 
> That is the reason why I try to use msys.

This is build of standard mingw make with -j option support.

- Filip
> PS: The date of your mail was the 1/1/2003.

Thanks for notifying, I just put a new motherboard into my computer
...

[KJKHyperion]

Hartmut Birr wrote:
> > > Currently, msys is the only way to use all cpus or cores for the 
> > > build process on windows.
> >
> > Not correct, www.volny.cz/xnavara/mingw32-make.hyp.exe.bin (or 
> > www.volny.cz/xnavara/mingw32-make.exe, not sure which binary is the 
> > right one).
>
> mingw32-make can use multiple cpus or cores, if sh.exe is found on the 
> path

I have written a patch to allow it to work with cmd.exe too. It 
currently sits in patch limbo while the GNU Make team finds [the time to 
care enough to find] a good enough way to make it handle the Windows 95 
family gracefully. Here:

http://savannah.gnu.org/patch/?func=detailitem&item_id=3678

[Hartmut Birr]

KJKHyperion wrote:
> Hartmut Birr wrote:
> > > > Currently, msys is the only way to use all cpus or cores for the 
> > > > build process on windows.
> > >
> > > Not correct, www.volny.cz/xnavara/mingw32-make.hyp.exe.bin (or 
> > > www.volny.cz/xnavara/mingw32-make.exe, not sure which binary is the 
> > > right one).
> >
> > mingw32-make can use multiple cpus or cores, if sh.exe is found on 
> > the path
>
> I have written a patch to allow it to work with cmd.exe too. It 
> currently sits in patch limbo while the GNU Make team finds [the time 
> to care enough to find] a good enough way to make it handle the 
> Windows 95 family gracefully. Here:
>
> http://savannah.gnu.org/patch/?func=detailitem&item_id=3678
> _______________________________________________

I didn't find the real patch. How can I download the patch?

- Hartmut

[KJKHyperion]

Hartmut Birr wrote:
> > http://savannah.gnu.org/patch/?func=detailitem&item_id=3678
>
> I didn't find the real patch. How can I download the patch?

"attached file" section. Or:

http://savannah.gnu.org/patch/download.php?item_id=3678&item_file_id=4086

[Royce Mitchell III]

This patch breaks building on non-msys windows:

C:\cvs\reactos>make
mkdir up/obj-i386
The syntax of the command is incorrect.
make: [up/obj-i386] Error 1 (ignored)
mkdir up/obj-i386\tools
The syntax of the command is incorrect.
make: [up/obj-i386\tools] Error 1 (ignored)
mkdir up/obj-i386\tools\rbuild
The syntax of the command is incorrect.
make: [up/obj-i386\tools\rbuild] Error 1 (ignored)
mkdir up/obj-i386\tools\rbuild\backend
The syntax of the command is incorrect.
make: [up/obj-i386\tools\rbuild\backend] Error 1 (ignored)
mkdir up/obj-i386\tools\rbuild\backend\mingw
The syntax of the command is incorrect.
make: [up/obj-i386\tools\rbuild\backend\mingw] Error 1 (ignored)
g++ -Itools\rbuild -Wall -Wpointer-arith -c 
tools\rbuild\backend\mingw\mingw.cpp
 -o up/obj-i386\tools\rbuild\backend\mingw\mingw.o
Assembler messages:
FATAL: can't create up/obj-i386\tools\rbuild\backend\mingw\mingw.o: No 
such file
 or directory
make: *** [up/obj-i386\tools\rbuild\backend\mingw\mingw.o] Error 1

Hartmut Birr wrote:
> Hi,
>
> I've changed rbuild a little bit, that it can run on msys (on 
> windows). The major changes are:
> The separator (slash or back slash), exepostfix and exeprefix are
>
> initialized from environment variables.
> The separators in the path for the system command are always
>
> converted for the host system.
> Our own build utilities must convert paths itself (bin2res).
>
> It exist some problems with absolute paths on msys, because msys uses 
> '/c/foo/bar' and windows 'c:\foo\bar' or 'c:/foo/bar'.
>
> I've tested the patch on msys and on windows. I cannot test the patch 
> on linux.
>
> Currently, msys is the only way to use all cpus or cores for the build 
> process on windows.
> Hartmut
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Hartmut Birr]

Royce Mitchell III wrote:
> This patch breaks building on non-msys windows:

Oops, can you please remove or change the path variables at the top of 
the makefile. They are always depend from the build system.

- Hartmut

[Royce Mitchell III]

I removed all the exports at the top of the makefile, and I was able to 
build a bootcd.

Hartmut Birr wrote:
> Royce Mitchell III wrote:
> > This patch breaks building on non-msys windows:
>
> Oops, can you please remove or change the path variables at the top of 
> the makefile. They are always depend from the build system.
> Hartmut
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> .

[Royce Mitchell III]

Hartmut Birr wrote:
> Royce Mitchell III wrote:
> > This patch breaks building on non-msys windows:
>
> Oops, can you please remove or change the path variables at the top of 
> the makefile. They are always depend from the build system.

I hear no other objections, may I commit your patch for you to clean up 
my tree, please?

[Ge van Geldorp]

> From: Royce Mitchell III
>
> Hartmut Birr wrote:
> > Royce Mitchell III wrote:
> > > This patch breaks building on non-msys windows:
> >
> > Oops, can you please remove or change the path variables at
>
> the top of
> > the makefile. They are always depend from the build system.
>
> I hear no other objections, may I commit your patch for you 
> to clean up my tree, please?

I haven't had time to test it on Linux yet. Did anyone else? If not, can you
wait a few more hours please.

Gé van Geldorp.

[Ge van Geldorp]

> From: Ge van Geldorp
> > From: Royce Mitchell III
> >
> > I hear no other objections, may I commit your patch for you 
> > to clean up my tree, please?
>
> I haven't had time to test it on Linux yet. Did anyone else? 
> If not, can you wait a few more hours please.

Builds and installs fine in Linux. No objections from my side.

Gé van Geldorp.

[KJKHyperion]

Royce Mitchell III wrote:
> This patch breaks building on non-msys windows:
>
> C:\cvs\reactos>make
> mkdir up/obj-i386

why do we use forward slashes at all? and BTW, aren't there GNU make 
functions to handle paths in a cross-platform way?

[Hartmut Birr]

KJKHyperion wrote:
> Royce Mitchell III wrote:
> > This patch breaks building on non-msys windows:
> >
> > C:\cvs\reactos>make
> > mkdir up/obj-i386
>
> why do we use forward slashes at all? and BTW, aren't there GNU make 
> functions to handle paths in a cross-platform way?
> _______________________________________________

Msys needs forward slashes. I didn't remove my path settings for msys on 
top of the makefile. Windows needs back slashes at this point.

- Hartmut