The point was made on IRC, if we are having issues, "I'll just have to use arwinss then". This was in reference to the region leak. We see the leak due to the compatibility of ReactOS. We use tools from the "Net" to examine the GDI handle counts. Might I add a point, these tools are written for Windows. ;^) How do we really know that the same leak does not occur with arwinss. Are there tools to measure this? Are there checks in wine to make sure wine does not exceed a limit? So far, from the patches added to arwinss from ReactOS, there are limitations to the use of wine. These same patches have been added to ReactOS after porting wine. Is it safe to assume, we have these same limitations in ReactOS? Can we help that we use wine 24/7 when we sync/port from wine? ReactOS has the same bugs if we do. Over and over this has been the issue in the past.
Pick on someone else for this leak, I'm not looking for it anymore, James
There was a leak before I started to fix it. Bug 4980
On Feb 18, 2010, at 5:14 AM, James Tabor wrote:
We see the leak due to the compatibility of ReactOS. We use tools from the "Net" to examine the GDI handle counts. Might I add a point, these tools are written for Windows. ;^) How do we really know that the same leak does not occur with arwinss. Are there tools to measure this?
Please tell me what apps are these, so I could test them. I really wonder if they are gonna work in arwinss too :).
WBR, Aleksey.
Well a quick overview, Arwinss is allocating from two places, Gdi32 and Win32k. Most likely based on what I read from the source, (wine) Gdi32. I'm not sure if you are passing everything to the ProcessEnvironmentBlock->GdiSharedHandleTable which originates in win32k, if not GDIView may not work. Both cases, it will not work or keep an accurate count of the object handles.
<Now Reading Again>
So in the case of (wine) Gdi32, the max allocations are about 16360, per process heap I guess, not sure. The check in win32k is still there in gdiobj.c but is that being used? DC, SURFACE and PALETTE as I can see. Regions are being allocated in (wine) Gdi32. Looking again, everything else too.
Example, For Dc; alloc_dc_ptr by alloc_gdi_handle in (wine) gdiobj.c. Region just calls alloc_gdi_handle.
Why GDIView? It is off the shelf and it is not ours! http://www.nirsoft.net/utils/gdi_handles.html
On Thu, Feb 18, 2010 at 5:52 AM, Aleksey Bragin aleksey@reactos.org wrote:
On Feb 18, 2010, at 5:14 AM, James Tabor wrote:
We see the leak due to the compatibility of ReactOS. We use tools from the "Net" to examine the GDI handle counts. Might I add a point, these tools are written for Windows. ;^) How do we really know that the same leak does not occur with arwinss. Are there tools to measure this?
Please tell me what apps are these, so I could test them. I really wonder if they are gonna work in arwinss too :).
WBR, Aleksey.
-
Aleksey Bragin -
James Tabor