Re: [ros-dev] [ros-diffs] [arty] 25028: Partially unregress python 2.4 installer.

[Alex Ionescu]

>   Modified:
> branches/arty-stable/reactos/ntoskrnl/ps/process.c
>  URL:
> http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ps…
>  ==============================================================================
>  --- branches/arty-stable/reactos/ntoskrnl/ps/process.c (original)
>  +++ branches/arty-stable/reactos/ntoskrnl/ps/process.c Sun Dec  3 13:42:35 2006
>  @@ -560,6 +560,8 @@
>       /* Create or Clone the Handle Table */
>       ObpCreateHandleTable(Parent, Process);
>   
>  +    memset(&Process->VadRoot, 0, sizeof(Process->VadRoot));
>  +
>       /* Set Process's Directory Base */
>       MmCopyMmInfo(Parent ? Parent : PsInitialSystemProcess,
>                    Process,
>  
>  
>   
Please use RtlZeroMemory in the kernel.
Please keep in mind the compartmentalization of the kernel for large
objects. Such a line should go somewhere like MmInitailizeXxx for the
process.


-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[art yerkes]

On Sun, 03 Dec 2006 12:23:30 -0500
Alex Ionescu <ionucu(a)videotron.ca> wrote:

> >   Modified:
> > branches/arty-stable/reactos/ntoskrnl/ps/process.c
> >  URL:
> > http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ps…
> >  ==============================================================================
> >  --- branches/arty-stable/reactos/ntoskrnl/ps/process.c (original)
> >  +++ branches/arty-stable/reactos/ntoskrnl/ps/process.c Sun Dec  3 13:42:35 2006
> >  @@ -560,6 +560,8 @@
> >       /* Create or Clone the Handle Table */
> >       ObpCreateHandleTable(Parent, Process);
> >   
> >  +    memset(&Process->VadRoot, 0, sizeof(Process->VadRoot));
> >  +
> >       /* Set Process's Directory Base */
> >       MmCopyMmInfo(Parent ? Parent : PsInitialSystemProcess,
> >                    Process,
> >  
> >  
> >   
>  
>  Please use RtlZeroMemory in the kernel.
>  Please keep in mind the compartmentalization of the kernel for large
>  objects. Such a line should go somewhere like MmInitailizeXxx for the
>  process. 
It isn't code anyone except me needs to be concerned about, but thanks
for the advice.
-- 
Discordant is the murmur at such treading down of lovely things while
god's most lordly gift to man is decency of mind.  Call that man only
blest who has in sweet tranquility brought his life to close.
If only I could act as such, my hope is good.
-- Aeschylus' Agamemnon (translated by H. W. Smyth)