Re: [ros-cvs] CVS Update: reactos

[Gunnar Dalsnes]

I saw Steven doing some dewineism commits also.

But why remove wineism?
It will be much easier to see differences with wine code when fixing 
bugs etc. if the code in question was taken from wine and wine for 
example has fixed a bug we are hunting. In kernel32 there are some files 
that i have taken from wine and the only thing changed is the include 
files, to make it possible to merge wine changes back.
> CVSROOT:	/CVS/ReactOS
> Module name:	reactos
> Repository:	reactos/lib/advapi32/crypt/
> Changes by:	[e-mail]	04/12/12 07:16:27
>
> Modified files:
>    reactos/lib/advapi32/crypt/: crypt.c crypt.h crypt_des.c 
>                                 crypt_lmhash.c crypt_md4.c 
>                                 crypt_md5.c crypt_sha.c
>
> Log message:
> Remove Wine-isms from advapi32 because it's a ReactOS DLL!

"because it's a ReactOS DLL"? So if we have to change one file out of 
many to adapt a wine dll as ours, we have to dewineism all other files 
also?
> Enforce a consistent coding style.
> Remove -D__REACTOS__
>
> Ros-cvs mailing list
> [e-mail]
> http://reactos.com/mailman/listinfo/ros-cvs

[Casper Hornstrup]

> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of Gunnar Dalsnes
> Sent: 12. december 2004 15:59
> To: [e-mail]
> Subject: [ros-dev] Re: [ros-cvs] CVS Update: reactos
>
> I saw Steven doing some dewineism commits also.
>
> But why remove wineism?
> It will be much easier to see differences with wine code when 
> fixing bugs etc. if the code in question was taken from wine 
> and wine for example has fixed a bug we are hunting. In 
> kernel32 there are some files that i have taken from wine and 
> the only thing changed is the include files, to make it 
> possible to merge wine changes back.

Readability.

[Steven Edwards]

Hi Gunnar,

--- Gunnar Dalsnes [e-mail] wrote:
> I saw Steven doing some dewineism commits also.

Yeah I have been doing this in msvcrt because the amount of code we can share 
is limited and the current import of the Wine code did not fit in the current
structure of the dll.
> But why remove wineism?

There are a few reasons to do this in a ReactOS dll

1. Enforce a consistent coding style
I don't really care if it differs slightly in each dll as long as each source file
maintains one style.

2. Debugging Macros
This is kind of a pain as ReactOS uses the DPRINT and friends while Wine users
FIXME,WARN,ERR,TRACE,etc. I would much rather ReactOS adopt Wine style debuggin accross the board
and a method for us to toggle debug messages at runtime rather than having to rebuild certain
files and change flags to enable debug levels.

3. Design and logic difference from ReactOS <-> Wine. 
In some cases we still have the issue of different ways to allocate memory as in the recent msvcrt
problems, the ongoing Win16/32 cleanups and other misc Wineisms which cause headaches.
> It will be much easier to see differences with wine code when fixing 
> bugs etc. if the code in question was taken from wine and wine for 
> example has fixed a bug we are hunting. In kernel32 there are some files 
> that i have taken from wine and the only thing changed is the include 
> files, to make it possible to merge wine changes back.

Yeah I agree but I thought Eric might have a problem with my changes in advapi32 due to the above
reasons which is why I did not merge it but left it up to Thomas. We thought there might be
dispute over this import but it was needed to get AbiWord going again.

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250