Re: [ros-dev] [ros-diffs] [hbelusca] 70674: [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" timeout problems of the t...

[Alex Ionescu]

I think you guys took more time to debug and mess with the DPRINT then
it would've taken to implement the function. Come on guys.
Best regards,
Alex Ionescu

On Mon, Feb 1, 2016 at 3:10 PM,  [e-mail] wrote:
> Author: hbelusca
> Date: Mon Feb  1 23:10:38 2016
> New Revision: 70674
>
> URL: http://svn.reactos.org/svn/reactos?rev=70674&view=rev
> Log:
> [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" timeout problems of the testbots due to spamming this dprint.
>
> Modified:
>     trunk/reactos/lib/cmlib/cmkeydel.c
>
> Modified: trunk/reactos/lib/cmlib/cmkeydel.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmkeydel.c?rev=70...
> ==============================================================================
> --- trunk/reactos/lib/cmlib/cmkeydel.c  [iso-8859-1] (original)
> +++ trunk/reactos/lib/cmlib/cmkeydel.c  [iso-8859-1] Mon Feb  1 23:10:38 2016
> @@ -215,7 +215,7 @@
>      }
>  /* FIXME: This leaks the security desriptor! */
> DPRINT1("Potentially leaking key security descriptor. Please call CmpFreeSecurityDescriptor\n");
>
> DPRINT("Potentially leaking key security descriptor. Please call CmpFreeSecurityDescriptor\n");
>
> /* Free the key body itself, and then return our status */
> if (!CmpFreeKeyBody(Hive, Cell)) return STATUS_INSUFFICIENT_RESOURCES;

[Hermès BÉLUSCA - MAÏTO]

I will have a look at this function when I'll have time.

Regards,
Hermès

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Alex Ionescu
Envoyé : mardi 2 février 2016 06:38
À : ReactOS Development List
Cc : Linda Wang
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70674: [CMLIB]: Demote the
DPRINT1 saying that we leak the security block descriptor to a DPRINT.
People (Alex & me) working on cmlib already know this. "Fixes" timeout
problems of the t...

I think you guys took more time to debug and mess with the DPRINT then it
would've taken to implement the function. Come on guys.
Best regards,
Alex Ionescu

On Mon, Feb 1, 2016 at 3:10 PM,  [e-mail] wrote:
> Author: hbelusca
> Date: Mon Feb  1 23:10:38 2016
> New Revision: 70674
>
> URL: http://svn.reactos.org/svn/reactos?rev=70674&view=rev
> Log:
> [CMLIB]: Demote the DPRINT1 saying that we leak the security block

descriptor to a DPRINT. People (Alex & me) working on cmlib already know
this. "Fixes" timeout problems of the testbots due to spamming this dprint.
> Modified:
>     trunk/reactos/lib/cmlib/cmkeydel.c
>
> Modified: trunk/reactos/lib/cmlib/cmkeydel.c
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmkeydel.c?
> rev=70674&r1=70673&r2=70674&view=diff
> ======================================================================
> ========
> --- trunk/reactos/lib/cmlib/cmkeydel.c  [iso-8859-1] (original)
> +++ trunk/reactos/lib/cmlib/cmkeydel.c  [iso-8859-1] Mon Feb  1 
> +++ 23:10:38 2016
> @@ -215,7 +215,7 @@
>      }
>  /* FIXME: This leaks the security desriptor! */
> DPRINT1("Potentially leaking key security descriptor. Please call

CmpFreeSecurityDescriptor\n");
> DPRINT("Potentially leaking key security descriptor. Please call
>
> CmpFreeSecurityDescriptor\n");
>
> /* Free the key body itself, and then return our status */
>    if (!CmpFreeKeyBody(Hive, Cell)) return
>
> STATUS_INSUFFICIENT_RESOURCES;

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev