the 3 partially duplicated NTSTATUS code copies

[art yerkes]

Does anybody object to consolidating all but one of the partial NTSTATUS_*
copies to:

#ifndef WIN32_NO_STATUS
#include <ddk/ntstatus.h>
#endif

And keeping the copy in ddk/ntstatus.h ?
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Ge van Geldorp]

> From: art yerkes
>
> Does anybody object to consolidating all but one of the 
> partial NTSTATUS_* copies to:
>
> #ifndef WIN32_NO_STATUS
> #include <ddk/ntstatus.h>
> #endif
>
> And keeping the copy in ddk/ntstatus.h ?

I assume you mean the other copies in <ntstatus.h> and <winnt.h>? The
problem is that those are not identical, <winnt.h> has them typecast as
DWORD while <ntstatus.h> has them typecast as NTSTATUS. This is the same as
in the PSDK.

GvG

[Royce Mitchell III]

Ge van Geldorp wrote:
> > From: art yerkes
> >
> > Does anybody object to consolidating all but one of the 
> > partial NTSTATUS_* copies to:
> >
> > #ifndef WIN32_NO_STATUS
> > #include <ddk/ntstatus.h>
> > #endif
> >
> > And keeping the copy in ddk/ntstatus.h ?
>
> I assume you mean the other copies in <ntstatus.h> and <winnt.h>? The
> problem is that those are not identical, <winnt.h> has them typecast as
> DWORD while <ntstatus.h> has them typecast as NTSTATUS. This is the same as
> in the PSDK.
>
> GvG

this could be handled with some creative #defines

[art yerkes]

On Mon, 5 Dec 2005 01:03:35 +0100
"Ge van Geldorp" [e-mail] wrote:
> > From: art yerkes
> >
> > Does anybody object to consolidating all but one of the 
> > partial NTSTATUS_* copies to:
> >
> > #ifndef WIN32_NO_STATUS
> > #include <ddk/ntstatus.h>
> > #endif
> >
> > And keeping the copy in ddk/ntstatus.h ?
>
> I assume you mean the other copies in <ntstatus.h> and <winnt.h>? The
> problem is that those are not identical, <winnt.h> has them typecast as
> DWORD while <ntstatus.h> has them typecast as NTSTATUS. This is the same as
> in the PSDK.
>
> GvG
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

what if I use a type that is either NTSTATUS or DWORD depending on whether
NTSTATUS is defined?

If the numeric values are different, then I think we have a deeper problem 
:-)

(and actually, I'm certain the numeric values are not different)
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman

[Ge van Geldorp]

> From: art yerkes
>
> what if I use a type that is either NTSTATUS or DWORD 
> depending on whether NTSTATUS is defined?

My only concern is that we stay True To The PSDK. If you can make it work
that way, I'm perfectly happy with it.
> If the numeric values are different, then I think we have a 
> deeper problem :-)

Indeed :-)

GvG