Vgal USB patches

[Hermès BÉLUSCA-MAÏTO]

Hi !

A proper code review may be in order, where/how can we do that?

Regards,

Hermès BÉLUSCA - MAÏTO

De : Ros-dev [mailto:[e-mail]] De la part de Alexander Rechitskiy
Envoyé : mardi 4 avril 2017 01:18
À : ReactOS Development List
Objet : [ros-dev] Vgal USB patches

Hello all!

Vgal showed significant progress in his USB patches. With his test images almost every sungle  usb keyboard and mouse works. We (russian community) have reached the top corner of our testing capabilities and we could not find any new bugs in his work anymore. So Vgal usb patches are now in very mature state.

Now we probably need to make the next step and put all his work or parts of it into trunk. But before  this Vgal said that it is important to test his drivers against Windows 2003 server to be sure in compatibilty. And this where russian community can not provide enough help with . I know that many developers are familiar with this procedure. So probably it is your turn now.

We need this patches in trunk in order to make our next release great again! And we have not so many but still enough time to finish this effort.

P.S. Here is the link to legal VHD-image of Microsoft Windows Server 2003 R2 Enterprise Edition for test purposes

https://www.microsoft.com/en-us/download/details.aspx?id=19727
-- 
Best regards,

Alexander Rechitskiy

[Javier Agustìn Fernàndez Arroyo]

"P.S. Here is the link to legal VHD-image of Microsoft Windows Server 2003
R2 Enterprise Edition for test purposes"

lol
1st time i`ve heard about this

On Tue, Apr 4, 2017 at 1:39 AM, Hermès BÉLUSCA-MAÏTO [e-mail]
wrote:
> Hi !
>
> A proper code review may be in order, where/how can we do that?
>
> Regards,
>
> Hermès BÉLUSCA - MAÏTO
>
> *De :* Ros-dev [mailto:[e-mail]] *De la part de*
> Alexander Rechitskiy
> *Envoyé :* mardi 4 avril 2017 01:18
> *À :* ReactOS Development List
> *Objet :* [ros-dev] Vgal USB patches
>
> Hello all!
>
> Vgal showed significant progress in his USB patches. With his test images
> almost every sungle  usb keyboard and mouse works. We (russian community)
> have reached the top corner of our testing capabilities and we could not
> find any new bugs in his work anymore. So Vgal usb patches are now in very
> mature state.
>
> Now we probably need to make the next step and put all his work or parts
> of it into trunk. But before  this Vgal said that it is important to test
> his drivers against Windows 2003 server to be sure in compatibilty. And
> this where russian community can not provide enough help with . I know that
> many developers are familiar with this procedure. So probably it is your
> turn now.
>
> We need this patches in trunk in order to make our next release great
> again! And we have not so many but still enough time to finish this effort.
>
> P.S. Here is the link to legal VHD-image of Microsoft Windows Server 2003
> R2 Enterprise Edition for test purposes
>
> https://www.microsoft.com/en-us/download/details.aspx?id=19727
>
> --
> Best regards,
>
> Alexander Rechitskiy
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Mark Jansen]

What kind of problems with github?
For his build problem: try completely deleting everything from that
build dir, and re-generating build files.

Regards,

Mark

On 4 April 2017 at 12:17, Alexander Rechitskiy [e-mail] wrote:
> Vgal told me that he still has major problems with github. So code  review
> at code.reactos.org is the only option. Also he is a bit tired with his
> local test builds and thinks that inclusion into trunk will speed up his
> developments
>
> And one more problem that he faced. He could not build proper VC bulds after
> new ISO format was adopted.
> https://pastebin.com/AtUqfGf9
>
> 04.04.2017, 02:41, "Hermès BÉLUSCA-MAÏTO" [e-mail]:
>
> Hi !
>
> A proper code review may be in order, where/how can we do that?
>
> Regards,
>
> Hermès BÉLUSCA - MAÏTO
>
> De : Ros-dev [mailto:[e-mail]] De la part de Alexander
> Rechitskiy
> Envoyé : mardi 4 avril 2017 01:18
> À : ReactOS Development List
> Objet : [ros-dev] Vgal USB patches
>
> Hello all!
>
> Vgal showed significant progress in his USB patches. With his test images
> almost every sungle  usb keyboard and mouse works. We (russian community)
> have reached the top corner of our testing capabilities and we could not
> find any new bugs in his work anymore. So Vgal usb patches are now in very
> mature state.
>
> Now we probably need to make the next step and put all his work or parts of
> it into trunk. But before  this Vgal said that it is important to test his
> drivers against Windows 2003 server to be sure in compatibilty. And this
> where russian community can not provide enough help with . I know that many
> developers are familiar with this procedure. So probably it is your turn
> now.
>
> We need this patches in trunk in order to make our next release great again!
> And we have not so many but still enough time to finish this effort.
>
> P.S. Here is the link to legal VHD-image of Microsoft Windows Server 2003 R2
> Enterprise Edition for test purposes
>
> https://www.microsoft.com/en-us/download/details.aspx?id=19727
>
> --
> Best regards,
>
> Alexander Rechitskiy
>
> ,
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> --
> Best regards,
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Hermès BÉLUSCA-MAÏTO]

And also use ninja with the option "-k 0" (dash k zero, without the quotes), so that he doesn't stop at the first compilation error it encounters & allows to continue compiling what's compilable.
At the next ninja -k 0 invocation, you can then better see which module(s) was failing compilation.
Also, I confirm that, for whatever reason in VS2010, which doesn't have inttypes.h, in its CRT headers, compilation might fail: here for me, for example, it succeeds when being done from the command-line, but fails when being done from within the VS IDE... It would be nice if compilation could use the inttypes.h provided in the mkisofs/shillytools, as this file is provided there indeed for a reason (and not to be not used).

Regards,
Hermès

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Mark Jansen
Envoyé : mardi 4 avril 2017 13:57
À : ReactOS Development List
Objet : Re: [ros-dev] Vgal USB patches

What kind of problems with github?
For his build problem: try completely deleting everything from that build dir, and re-generating build files.

Regards,

Mark

On 4 April 2017 at 12:17, Alexander Rechitskiy [e-mail] wrote:
> Vgal told me that he still has major problems with github. So code  
> review at code.reactos.org is the only option. Also he is a bit tired 
> with his local test builds and thinks that inclusion into trunk will 
> speed up his developments
>
> And one more problem that he faced. He could not build proper VC bulds 
> after new ISO format was adopted.
> https://pastebin.com/AtUqfGf9
>
> 04.04.2017, 02:41, "Hermès BÉLUSCA-MAÏTO" [e-mail]:
>
> Hi !
>
> A proper code review may be in order, where/how can we do that?
>
> Regards,
>
> Hermès BÉLUSCA - MAÏTO
>
> De : Ros-dev [mailto:[e-mail]] De la part de 
> Alexander Rechitskiy Envoyé : mardi 4 avril 2017 01:18 À : ReactOS 
> Development List Objet : [ros-dev] Vgal USB patches
>
> Hello all!
>
> Vgal showed significant progress in his USB patches. With his test images
> almost every sungle  usb keyboard and mouse works. We (russian community)
> have reached the top corner of our testing capabilities and we could not
> find any new bugs in his work anymore. So Vgal usb patches are now in very
> mature state.
>
> Now we probably need to make the next step and put all his work or parts of
> it into trunk. But before  this Vgal said that it is important to test his
> drivers against Windows 2003 server to be sure in compatibilty. And this
> where russian community can not provide enough help with . I know that many
> developers are familiar with this procedure. So probably it is your turn
> now.
>
> We need this patches in trunk in order to make our next release great again!
> And we have not so many but still enough time to finish this effort.
>
> P.S. Here is the link to legal VHD-image of Microsoft Windows Server 2003 R2
> Enterprise Edition for test purposes
>
> https://www.microsoft.com/en-us/download/details.aspx?id=19727
>
> --
> Best regards,
>
> Alexander Rechitskiy
>
> ,
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> --
> Best regards,
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Colin Finck]

Am 04.04.2017 um 14:05 schrieb Hermès BÉLUSCA-MAÏTO:
> Also, I confirm that, for whatever reason in VS2010, which doesn't have inttypes.h, in its CRT headers, compilation might fail: here for me, for example, it succeeds when being done from the command-line, but fails when being done from within the VS IDE...

Huh?? That sounds like MSVC-provided headers are mixed with our target
headers in sdk/include/crt for host tools, which mustn't happen!
> It would be nice if compilation could use the inttypes.h provided in the mkisofs/shillytools, as this file is provided there indeed for a reason (and not to be not used).

Actually, I put the schilytools headers into
sdk/tools/mkisofs/schilytools and not into e.g. sdk/tools/schilytools
for a reason:
I only imported the very subset that is required for mkisofs. Their
usability for any other purpose is not guaranteed.

If you just want a cheap fix for isohybrid, you should uncomment the
inttypes.h include and add the required <10 lines to reactos_support_code.h.

There may be merit in using schilytools headers for this if more than
just isohybrid and mkisofs would do so. Currently, every host tool we
have uses their own host-abstracting headers.
But unless you plan to work on this, I don't expect this to change any
time soon, and this is why I would go the cheap route myself :)

- Colin

[Hermès BÉLUSCA-MAÏTO]

The cheap route for isohybrid is ok (and it's not the only tool where we would do this modification :) )
For my local msvc-problem I don't know what it does...

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Colin Finck
Envoyé : mardi 4 avril 2017 18:16
À : [e-mail]
Objet : Re: [ros-dev] Vgal USB patches

Am 04.04.2017 um 14:05 schrieb Hermès BÉLUSCA-MAÏTO:
> Also, I confirm that, for whatever reason in VS2010, which doesn't have inttypes.h, in its CRT headers, compilation might fail: here for me, for example, it succeeds when being done from the command-line, but fails when being done from within the VS IDE...

Huh?? That sounds like MSVC-provided headers are mixed with our target headers in sdk/include/crt for host tools, which mustn't happen!
> It would be nice if compilation could use the inttypes.h provided in the mkisofs/shillytools, as this file is provided there indeed for a reason (and not to be not used).

Actually, I put the schilytools headers into sdk/tools/mkisofs/schilytools and not into e.g. sdk/tools/schilytools for a reason:
I only imported the very subset that is required for mkisofs. Their usability for any other purpose is not guaranteed.

If you just want a cheap fix for isohybrid, you should uncomment the inttypes.h include and add the required <10 lines to reactos_support_code.h.

There may be merit in using schilytools headers for this if more than just isohybrid and mkisofs would do so. Currently, every host tool we have uses their own host-abstracting headers.
But unless you plan to work on this, I don't expect this to change any time soon, and this is why I would go the cheap route myself :)

- Colin

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Colin Finck]

Am 04.04.2017 um 12:17 schrieb Alexander Rechitskiy:
> And one more problem that he faced. He could not build proper VC bulds
> after new ISO format was adopted.
> https://pastebin.com/AtUqfGf9

Thanks for pointing this out!
This bug is now tracked at https://jira.reactos.org/browse/CORE-13031

I may have a look in about a week, but this should be easy to fix for
anyone who has some time.

- Colin

[Jared Smudde]

I thought he has an SVN branch in our repo?

________________________________
From: Ros-dev [e-mail] on behalf of Colin Finck [e-mail]
Sent: Tuesday, April 04, 2017 7:20 AM
To: [e-mail]
Subject: Re: [ros-dev] Vgal USB patches

Am 04.04.2017 um 12:17 schrieb Alexander Rechitskiy:
> And one more problem that he faced. He could not build proper VC bulds
> after new ISO format was adopted.
> https://pastebin.com/AtUqfGf9

[https://pastebin.com/i/facebook.png]https://pastebin.com/AtUqfGf9

[C (WinAPI)] D:\reactos_trunk>configure Detected Visual Studio Environment VS10-i386 Creati - Pastebin.comhttps://pastebin.com/AtUqfGf9
pastebin.com

Thanks for pointing this out!
This bug is now tracked at https://jira.reactos.org/browse/CORE-13031

I may have a look in about a week, but this should be easy to fix for
anyone who has some time.

- Colin

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Michael Fritscher]

Hi,

hmm, he could upload a patchfile/set (svn or git) and upload this file
"somewhere" (e.g. in jira, or to a file service). Then it can be uploaded
to a (or his) SVN-branch for further review and testing. This part is I
think the smallest problem ;-)

Best regards,
Michael

[Robert Naumann]

Codereview is already ongoing. If everything goes well, USB will become
great again soon.

Am 05.04.2017 18:26 schrieb "Michael Fritscher" [e-mail]:

Hi,

hmm, he could upload a patchfile/set (svn or git) and upload this file
"somewhere" (e.g. in jira, or to a file service). Then it can be uploaded
to a (or his) SVN-branch for further review and testing. This part is I
think the smallest problem ;-)

Best regards,
Michael

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev