Re: [ros-dev] [ros-diffs] [dgorbachev] 27187: Improve FIXME comment. For future generations of developers. :)

[Alex Ionescu]

Is it really that hard to realize the line of code should've been:

LdrEntry->SectionPointer = Section;

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On Behalf Of [e-mail]
Sent: Friday, June 15, 2007 5:12 AM
To: [e-mail]
Subject: [ros-diffs] [dgorbachev] 27187: Improve FIXME comment. For future generations of developers. :)

Author: dgorbachev
Date: Fri Jun 15 16:11:48 2007
New Revision: 27187

URL: http://svn.reactos.org/svn/reactos?rev=27187&view=rev
Log:
Improve FIXME comment. For future generations of developers. :)

Modified:
    trunk/reactos/ntoskrnl/mm/sysldr.c

Modified: trunk/reactos/ntoskrnl/mm/sysldr.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/sysldr.c?rev=27...
==============================================================================
--- trunk/reactos/ntoskrnl/mm/sysldr.c (original)
+++ trunk/reactos/ntoskrnl/mm/sysldr.c Fri Jun 15 16:11:48 2007
@@ -1767,7 +1767,7 @@
                                    NtHeader->OptionalHeader.AddressOfEntryPoint);
     LdrEntry->SizeOfImage = DriverSize;
     LdrEntry->CheckSum = NtHeader->OptionalHeader.CheckSum;
-    LdrEntry->SectionPointer = NULL; // ?
+    LdrEntry->SectionPointer = NULL; // FIXME: Bug 2151.

/* Now write the DLL name */
     LdrEntry->BaseDllName.Buffer = (PVOID)(LdrEntry + 1);

Hi,
> Is it really that hard to realize the line of code should've been:

This bug has been reported more then 2 month ago, but nobody fixed it so 
far!
> LdrEntry->SectionPointer = Section;

Thanks.
> So the new ReactOS is all about adding hacks to the kernel
> and hiding existing bugs instead of finding solutions.

On the contrary.