Regressions and bugs

[Gabriel ilardi]

Hi team,

I don't know why, but it seems that bugzilla and ros-bugs is being ignored, except for
some exceptions where I've seen regressions fixed lately.

IMHO it's extremely important the perception people have about us when they test ros,
if ros improved overall but that's not noticeable to the end user
the final perception will be bad, now if we want a cooler release than 0.3.11 and older
revisions, people should feel the improvement.

I'm gonna make a short sum up of what I think it should be fixed or tried to at least
to accomplish that (this list contains not only regressions but bugs that would improve
the ros perception for the average user):

I hope we can all work as a team to try and fix these issues, I can only offer my help
testing as that's the thing I know best atm.

GUI perception:
642 hotkeys not supported:
Wouldn't it be cool to hit Win+R to run, Start menu appearing when hitting win, etc.?
copy paste files with the keyboard...
I'd also add here, we need to be able to switch applications with alt-tab, I remember
johannes did something related to this long ago.

969 Minimized windows are shown on the desktop, no need to mention that this reminds me of
win 3.11, good old times, but that was long ago...

1603 can't exit rename state

2320 clock doesn't show properly (partially shown), this exists since I remember too.

2322 Hide inactive icons doesn't work, please remove this... option :)

2328 Shell doesn't restart upon its failure

2428 non stop scrolling hangs entire gui, aka "if you do dir /s in real hardware go
have a good breakfast"

2788 unwanted multiple selection while doing a right click on the desktop, ugly when you
have multiple icons on your desktop and launch them because of this

3101 our remote dekstop can't be used, you can't change settings

3171 focus doesn't change back to parent window

3212 different keyboard responses, also keyboard doesn't work correctly with dinput
see bug 4405

4379 hovering the mouse over the start menu spoils the text

4847 File copying dialog is missing

4915 Control panel: Keyboard doesn't work after opening and closing an applet

4960 ReactOS restarts at the beginning of 2nd stage if you hit ESC

Explorer has all kind of visual glitches you can imagine and even more.
keyboard layout issues: it's language dependent when it shouldn't be, changing
keyboard layout doesn't work,
kb layout tools dont' work, wrong keyboard layout in cmd see 3317, 2132, 2133, 2178,
2952, see also profiles problems below
 
Visual/Graphic bugs:
There are tons of these, I'll name a few, luckily we have Arwinss.
3624 worksoft navigator can't be minimized.
3680 Blinking text while installing vc2008 redist package
4051 Command Prompt icon showed through a window

General:
Users need to save a file to the desktop and see it has been created, see bug 1249 and
also 2821.
Winamp main window is unclicable, this has existed since I rememer, bug 1239.
taskmgr shows still processes that have been killed, see bug 1567.
2393 you need to move the mouse to make firefox work (thanks arwinss for this too).
Profiles: They are messed, %TEMP% has some issues see bugs 2482, 2972, also 4008 and 4102,
all users desktop icons don't appear in user's desktop 4289, also bug 4444.
2622 console doesn't support scrolling at all.
2978 we can't search it regedit, it doesn't work and hangs the app.
3225 3dtext screensaver shows garbled text
3429 can't select any color in comdlg32 color dialog, since I remember too...
3559 Double-click on application icon does not close application.
3781 Tab Key does not work for "SysIPAddress32" controls
3883 screensaver doesn't start automatically
3966 can't hit enter on a selected item to open it
4049 changing screen resolutions requires restart, thanks Timo aka yaratows master! :)
4066 Notepad, uses two different fonts / highlighted text invisible
4106 Wrong text spacing in popup menus / icons after show a font in control applet /
Remote Desktop
4185 [PATCH] Netstat produces b*llshit, should we apply the patch ?
4377 Notepad: Find command doesn't work right.
4380 Real Hardware: mouse wheel doesn't work
4383 Can't delete many items from Desktop at once using the mouse
4501 When closing one window, Firefox gets restored if it was minimized
4560 explorer mouse rectangle doesn't work anymore (I'm not sure it ever worked,
it does work in arwinss)
4676 Unable to restore down a maximised window
4779 K-Meleon popup menus dont work
4835 Regression: Memory usage continuously decreases in task manager even though memory
usage doesn't change (HACKFIXED)
5005 Foxit reader, program starts automatically instead of the installation wizard
5030 Changing color depth resets the wallpaper to none
5059 mIRC 6.35 server list with unusable scrollbar
5066 PATCH : Incorrect sending of mouse messages, can someone take a look ?
5099 [metabug]ReactOS new loader doesnt work with more than 3584 MB of RAM, let's not
forget this one 5100 and 5101 too

Regressions:
3716 Livecd networking does not work in qemu
3727 Regression: roscalc problems with keyboard input etc.
4461 Regression: Notepad Lite
4568 Regression: Startup Folder stopped working (see profiles and environment vars too)
4677 Regression: Can't restore minimized windows
4811 Recent AbiWord toolbar regression: comctl32 sync r42706
4926 Regression: Tworld and DosBox don't work
4948 [Regression] Can't close locale settings dialog on 2nd stage of setup
4951 [Regression] 'whois' hangs
5035 Regression: Abiword - Fonts listbox isn't shown properly
5276 Regression: shell about dialog doesn't display header bitmap
5294 Regression: Device manager list is empty

x-chat used to work, it looked bad, now it doesn't even start, there's 
no specific regression bug filed for this, see bug 1176

Features needed:
USB keyboard and mouse are a must nowadays, ps/2 won't last much longer..., bug 1041,
also ps/2 doesn't work if you unplug it and replug it later bug 1395.

Installation/USetup needs to be able to handle bootmgrs, and other partitions when they
are present, at least give you the possibility to wipe everything up.
also 2564 ros doesn't mount logical units on extended partitions, see also 2733, 4368,
4614, 5270

VGA/VBE bug 2073 ros does not work on vga display. See also 2286, 4354, 4447, 4192
Several uniata issues in real hw 4591, 4995
We need drag & drop a wokring clipboard

Last but not least there's a regression not filed yet to my knowledge:

(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent is dead!
(subsystems/win32/win32k/ntuser/windc.c:738) Not POWNED or CLASSDC hwndCurrent ->
20168
Assertion 'FALSE' failed at subsystems/win32/win32k/ntuser/windc.c line 739
PuTTYEntered debugger on embedded INT3 at 0x0008:0x808e5e5e.
kdb:> bt
Eip:
<ntoskrnl.exe:e5e5f (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))>
Frames:
<win32k.sys:7b79e (subsystems/win32/win32k/ntuser/windc.c:739
(@DceFreeWindowDCE@4))>
<win32k.sys:7f69c (subsystems/win32/win32k/ntuser/window.c:488
(co_UserFreeWindow))>
<win32k.sys:7fab7 (subsystems/win32/win32k/ntuser/window.c:2747
(@co_UserDestroyWindow@4))>
<win32k.sys:7faed (subsystems/win32/win32k/ntuser/window.c:2771
(NtUserDestroyWindow@4))>
<ntoskrnl.exe:6fb7 (ntoskrnl/ke/i386/traphdlr.c:1564 (@KiSystemServiceHandler@8))>
<ntoskrnl.exe:e041d (ntoskrnl/ke/i386/trap.s:127 (KiInterruptTemplateDispatch))>
<ntdll.dll:7ac5>
<user32.dll:47ed1>
<user32.dll:48063>
<ntdll.dll:7a1d>
<explorer.exe:16ded>
<explorer.exe:436c6>
<user32.dll:47ed1>
<user32.dll:4851d>
<user32.dll:48768>
<user32.dll:2cf50>
<user32.dll:2dd16>
<user32.dll:2eaad>
<user32.dll:2eb70>
<user32.dll:3b92d>
<explorer.exe:16e2a>--- Press q to abort, any other key to continue ---

<explorer.exe:436c6>
<user32.dll:47ed1>
<user32.dll:4851d>
<user32.dll:48768>
<user32.dll:4bfa2>
<user32.dll:4c06b>
<user32.dll:2d5ed>
<user32.dll:2eaad>
<user32.dll:2eb70>
<user32.dll:3b92d>
<explorer.exe:16e2a>
<explorer.exe:436c6>
<user32.dll:47ed1>
<user32.dll:4851d>
<user32.dll:48a5b>
<explorer.exe:4296c>
<explorer.exe:4dd23>
<explorer.exe:51c4b>
<explorer.exe:60ad9>
<explorer.exe:60906>
<explorer.exe:60968>
<kernel32.dll:2ef7b>
--- Press q to abort, any other key to continue ---
<00000000>
kdb:>


I'll be back, promise ;).
 		 	   		  
_________________________________________________________________
Più di 20 giochi su Messenger. Scoprili tutti!
http://www.messenger.it/raccoltaGiochi.aspx

[James Tabor]

I know about this one! It was worse before and I removed the routine
due to the kernel changes and added it back when I thought it was
fixed. ATM just type "cont" at the debug prompt. I'm not sure how it
is reentering even after removing the DCE from the window. Thread lock
should have catch it and it's very random. Only pops up when exiting
explorer. Mixing owned with classed DCE?

On Thu, Apr 15, 2010 at 8:14 AM, Gabriel ilardi
<gabrielilardi(a)hotmail.it> wrote:
>   Last but not least there's a regression not filed
> yet to my knowledge:
>
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent
>  is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or Parent
>  is dead!
>  (subsystems/win32/win32k/ntuser/windc.c:738) Not POWNED or CLASSDC
>  hwndCurrent -> 20168
>  Assertion 'FALSE' failed at subsystems/win32/win32k/ntuser/windc.c line 739
>  PuTTYEntered debugger on embedded INT3 at 0x0008:0x808e5e5e.
>  kdb:> bt
>  Eip:
>  <ntoskrnl.exe:e5e5f (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))>
>  Frames:
>  <win32k.sys:7b79e (subsystems/win32/win32k/ntuser/windc.c:739
>  (@DceFreeWindowDCE@4))>
>  <win32k.sys:7f69c (subsystems/win32/win32k/ntuser/window.c:488
>  (co_UserFreeWindow))>
>  <win32k.sys:7fab7 (subsystems/win32/win32k/ntuser/window.c:2747
>  (@co_UserDestroyWindow@4))>
>  <win32k.sys:7faed (subsystems/win32/win32k/ntuser/window.c:2771
>  (NtUserDestroyWindow@4))>
>  <ntoskrnl.exe:6fb7 (ntoskrnl/ke/i386/traphdlr.c:1564
>  (@KiSystemServiceHandler@8))>
>  <ntoskrnl.exe:e041d (ntoskrnl/ke/i386/trap.s:127
>  (KiInterruptTemplateDispatch))>

[Gregor Schneider]

Looks like Gabriel did a bugzilla attack too.

I'd like to add some comments: i've also been working the bug list of a
humble 600 items up and down, mainly addressing the easy visual and
configuration issues. See http://cia.vc/stats/author/gschneider.

I've skipped generelly skipped big feature enhancements and avoided explorer
bugs (explorer_new) and win32 subsystem issues (arwinss).

Current explorer bugs are fixable, but the effort is wasted if explorer_new
ever replaces the current one. Any plans, suggestions, ideas concerning it's
completion?

Concerning open bugs: i got incomplete/experimental patches in my tree for
5045 Charmap.exe: Copy Field Uses Default font.
3148 Properties for display with monitor
4008 ProgramFiles environment variable is not set (Creation of environment
variables seems to be a big problem. We need some research who sets which at
which point in time)

Summed up: Bugzilla needs YOU!
In case you are in doubt: we've got 33 unattended bz patches and probably
more hiding in dark places.

[Aleksey Bragin]

Great work, thank you very much! That's exactly what I was speaking  
about yesterday.

I'm considering freezing trunk to only allow fixes for these  
regression. If noone objects, this is going to become reality tonight.


WBR,
Aleksey.

On Apr 15, 2010, at 5:14 PM, Gabriel ilardi wrote:

>   Hi team,
>
>  I don't know why, but it seems that bugzilla and ros-bugs is being  
>  ignored, except for some exceptions where I've seen regressions  
>  fixed lately.
>
>  IMHO it's extremely important the perception people have about us  
>  when they test ros, if ros improved overall but that's not  
>  noticeable to the end user
>  the final perception will be bad, now if we want a cooler release  
>  than 0.3.11 and older revisions, people should feel the improvement.
>
>  I'm gonna make a short sum up of what I think it should be fixed or  
>  tried to at least to accomplish that (this list contains not only  
>  regressions but bugs that would improve the ros perception for the  
>  average user):
>
>  I hope we can all work as a team to try and fix these issues, I can  
>  only offer my help testing as that's the thing I know best atm.
>
>  GUI perception:
>  642 hotkeys not supported:
>  Wouldn't it be cool to hit Win+R to run, Start menu appearing when  
>  hitting win, etc.? copy paste files with the keyboard...
>  I'd also add here, we need to be able to switch applications with  
>  alt-tab, I remember johannes did something related to this long ago.
>
>  969 Minimized windows are shown on the desktop, no need to mention  
>  that this reminds me of win 3.11, good old times, but that was long  
>  ago...
>
>  1603 can't exit rename state
>
>  2320 clock doesn't show properly (partially shown), this exists  
>  since I remember too.
>
>  2322 Hide inactive icons doesn't work, please remove this... option :)
>
>  2328 Shell doesn't restart upon its failure
>
>  2428 non stop scrolling hangs entire gui, aka "if you do dir /s in  
>  real hardware go have a good breakfast"
>
>  2788 unwanted multiple selection while doing a right click on the  
>  desktop, ugly when you have multiple icons on your desktop and  
>  launch them because of this
>
>  3101 our remote dekstop can't be used, you can't change settings
>
>  3171 focus doesn't change back to parent window
>
>  3212 different keyboard responses, also keyboard doesn't work  
>  correctly with dinput see bug 4405
>
>  4379 hovering the mouse over the start menu spoils the text
>
>  4847 File copying dialog is missing
>
>  4915 Control panel: Keyboard doesn't work after opening and closing  
>  an applet
>
>  4960 ReactOS restarts at the beginning of 2nd stage if you hit ESC
>
>  Explorer has all kind of visual glitches you can imagine and even  
>  more.
>  keyboard layout issues: it's language dependent when it shouldn't  
>  be, changing keyboard layout doesn't work,
>  kb layout tools dont' work, wrong keyboard layout in cmd see 3317,  
>  2132, 2133, 2178, 2952, see also profiles problems below
>
>  Visual/Graphic bugs:
>  There are tons of these, I'll name a few, luckily we have Arwinss.
>  3624 worksoft navigator can't be minimized.
>  3680 Blinking text while installing vc2008 redist package
>  4051 Command Prompt icon showed through a window
>
>  General:
>  Users need to save a file to the desktop and see it has been  
>  created, see bug 1249 and also 2821.
>  Winamp main window is unclicable, this has existed since I rememer,  
>  bug 1239.
>  taskmgr shows still processes that have been killed, see bug 1567.
>  2393 you need to move the mouse to make firefox work (thanks  
>  arwinss for this too).
>  Profiles: They are messed, %TEMP% has some issues see bugs 2482,  
>  2972, also 4008 and 4102, all users desktop icons don't appear in  
>  user's desktop 4289, also bug 4444.
>  2622 console doesn't support scrolling at all.
>  2978 we can't search it regedit, it doesn't work and hangs the app.
>  3225 3dtext screensaver shows garbled text
>  3429 can't select any color in comdlg32 color dialog, since I  
>  remember too...
>  3559 Double-click on application icon does not close application.
>  3781 Tab Key does not work for "SysIPAddress32" controls
>  3883 screensaver doesn't start automatically
>  3966 can't hit enter on a selected item to open it
>  4049 changing screen resolutions requires restart, thanks Timo aka  
>  yaratows master! :)
>  4066 Notepad, uses two different fonts / highlighted text invisible
>  4106 Wrong text spacing in popup menus / icons after show a font in  
>  control applet / Remote Desktop
>  4185 [PATCH] Netstat produces b*llshit, should we apply the patch ?
>  4377 Notepad: Find command doesn't work right.
>  4380 Real Hardware: mouse wheel doesn't work
>  4383 Can't delete many items from Desktop at once using the mouse
>  4501 When closing one window, Firefox gets restored if it was  
>  minimized
>  4560 explorer mouse rectangle doesn't work anymore (I'm not sure it  
>  ever worked, it does work in arwinss)
>  4676 Unable to restore down a maximised window
>  4779 K-Meleon popup menus dont work
>  4835 Regression: Memory usage continuously decreases in task  
>  manager even though memory usage doesn't change (HACKFIXED)
>  5005 Foxit reader, program starts automatically instead of the  
>  installation wizard
>  5030 Changing color depth resets the wallpaper to none
>  5059 mIRC 6.35 server list with unusable scrollbar
>  5066 PATCH : Incorrect sending of mouse messages, can someone take  
>  a look ?
>  5099 [metabug]ReactOS new loader doesnt work with more than 3584 MB  
>  of RAM, let's not forget this one 5100 and 5101 too
>
>  Regressions:
>  3716 Livecd networking does not work in qemu
>  3727 Regression: roscalc problems with keyboard input etc.
>  4461 Regression: Notepad Lite
>  4568 Regression: Startup Folder stopped working (see profiles and  
>  environment vars too)
>  4677 Regression: Can't restore minimized windows
>  4811 Recent AbiWord toolbar regression: comctl32 sync r42706
>  4926 Regression: Tworld and DosBox don't work
>  4948 [Regression] Can't close locale settings dialog on 2nd stage  
>  of setup
>  4951 [Regression] 'whois' hangs
>  5035 Regression: Abiword - Fonts listbox isn't shown properly
>  5276 Regression: shell about dialog doesn't display header bitmap
>  5294 Regression: Device manager list is empty
>
>  x-chat used to work, it looked bad, now it doesn't even start,  
>  there's no specific regression bug filed for this, see bug 1176
>
>  Features needed:
>  USB keyboard and mouse are a must nowadays, ps/2 won't last much  
>  longer..., bug 1041, also ps/2 doesn't work if you unplug it and  
>  replug it later bug 1395.
>
>  Installation/USetup needs to be able to handle bootmgrs, and other  
>  partitions when they are present, at least give you the possibility  
>  to wipe everything up.
>  also 2564 ros doesn't mount logical units on extended partitions,  
>  see also 2733, 4368, 4614, 5270
>
>  VGA/VBE bug 2073 ros does not work on vga display. See also 2286,  
>  4354, 4447, 4192
>  Several uniata issues in real hw 4591, 4995
>  We need drag & drop a wokring clipboard
>
>  Last but not least there's a regression not filed yet to my knowledge:
>
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or  
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or  
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/windc.c:738) Not POWNED or CLASSDC  
>  hwndCurrent -> 20168
>  Assertion 'FALSE' failed at subsystems/win32/win32k/ntuser/windc.c  
>  line 739
>  PuTTYEntered debugger on embedded INT3 at 0x0008:0x808e5e5e.
>  kdb:> bt
>  Eip:
>  <ntoskrnl.exe:e5e5f (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))>
>  Frames:
>  <win32k.sys:7b79e (subsystems/win32/win32k/ntuser/windc.c:739  
>  (@DceFreeWindowDCE@4))>
>  <win32k.sys:7f69c (subsystems/win32/win32k/ntuser/window.c:488  
>  (co_UserFreeWindow))>
>  <win32k.sys:7fab7 (subsystems/win32/win32k/ntuser/window.c:2747  
>  (@co_UserDestroyWindow@4))>
>  <win32k.sys:7faed (subsystems/win32/win32k/ntuser/window.c:2771  
>  (NtUserDestroyWindow@4))>
>  <ntoskrnl.exe:6fb7 (ntoskrnl/ke/i386/traphdlr.c:1564  
>  (@KiSystemServiceHandler@8))>
>  <ntoskrnl.exe:e041d (ntoskrnl/ke/i386/trap.s:127  
>  (KiInterruptTemplateDispatch))>
>  <ntdll.dll:7ac5>
>  <user32.dll:47ed1>
>  <user32.dll:48063>
>  <ntdll.dll:7a1d>
>  <explorer.exe:16ded>
>  <explorer.exe:436c6>
>  <user32.dll:47ed1>
>  <user32.dll:4851d>
>  <user32.dll:48768>
>  <user32.dll:2cf50>
>  <user32.dll:2dd16>
>  <user32.dll:2eaad>
>  <user32.dll:2eb70>
>  <user32.dll:3b92d>
>  <explorer.exe:16e2a>--- Press q to abort, any other key to continue  
>  ---
>
>  <explorer.exe:436c6>
>  <user32.dll:47ed1>
>  <user32.dll:4851d>
>  <user32.dll:48768>
>  <user32.dll:4bfa2>
>  <user32.dll:4c06b>
>  <user32.dll:2d5ed>
>  <user32.dll:2eaad>
>  <user32.dll:2eb70>
>  <user32.dll:3b92d>
>  <explorer.exe:16e2a>
>  <explorer.exe:436c6>
>  <user32.dll:47ed1>
>  <user32.dll:4851d>
>  <user32.dll:48a5b>
>  <explorer.exe:4296c>
>  <explorer.exe:4dd23>
>  <explorer.exe:51c4b>
>  <explorer.exe:60ad9>
>  <explorer.exe:60906>
>  <explorer.exe:60968>
>  <kernel32.dll:2ef7b>
>  --- Press q to abort, any other key to continue ---
>  <00000000>
>  kdb:>
>
>
>  I'll be back, promise ;).
>
>  Chiacchiera su Web Messenger, disponibile da qualunque PC!
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Eric Kohl]

Gabriel ilardi schrieb:
>   Explorer has all kind of visual glitches you can
> imagine and even more.
>  keyboard layout issues: it's language dependent when it shouldn't be, 
>  changing keyboard layout doesn't work,
>  kb layout tools dont' work, wrong keyboard layout in cmd see 3317, 2132, 
>  2133, 2178, 2952, see also profiles problems below 
>   Profiles: They are messed, %TEMP% has some issues see
> bugs 2482, 2972, 
>  also 4008 and 4102, all users desktop icons don't appear in user's 
>  desktop 4289, also bug 4444. 
>   4568 Regression: Startup Folder stopped working (see
> profiles and 
>  environment vars too) 
Hi!

I plan to fix the profile-related issues this weekend.

I'll start by adding support for localized strings to the hive*.inf 
files. This will enable ReactOS to set localized values in the registry 
upon its initialization in setup stage 1. This way the localized user 
shell folder names will be added to the registry.

Next I will fix userenv.dll so the localized user shell folder names 
will be retrieved from the registry rather than from a hardcoded list.

This will fix most of the profile-related bugs.


Regards,
Eric

[Samuel serapion]

Test bot is broken, I usually "tracked" regressions that way... please fix.