Re: [ros-dev] [ros-diffs] [tkreuzer] 39533: x64 version of ntoskrnl doesn't export ExInterlockedAddLargeStatistic

[Steven Edwards]

Does the pspec here use Winebuild? Sorry I can't check at the moment.
If it does, the current winebuild allows you to specify exports for a
given arch by passing

-arch=cpu

in the spec file.

On Tue, Feb 10, 2009 at 10:15 AM,  <tkreuzer(a)svn.reactos.org> wrote:
>   Author: tkreuzer
>  Date: Tue Feb 10 09:15:07 2009
>  New Revision: 39533
>
>  URL: http://svn.reactos.org/svn/reactos?rev=39533&view=rev
>  Log:
>  x64 version of ntoskrnl doesn't export ExInterlockedAddLargeStatistic
>
>  Modified:
>     branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec
>
>  Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec
>  URL:
> http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk…
>  ==============================================================================
>  --- branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] (original)
>  +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] Tue Feb 10
> 09:15:07 2009
>  @@ -104,7 +104,9 @@
>   @ stdcall ExInitializeRundownProtectionCacheAware(ptr long)
>   @ stdcall ExInitializeZone(ptr long ptr long)
>   @ stdcall ExInterlockedAddLargeInteger(ptr long long ptr)
>  +#ifndef __x86_64__
>   @ fastcall ExInterlockedAddLargeStatistic(ptr long)
>  +#endif
>   @ stdcall ExInterlockedAddUlong(ptr long ptr)
>   #ifndef __x86_64__
>   @ fastcall ExInterlockedCompareExchange64(ptr ptr ptr ptr)
>
>  


-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Timo Kreuzer]

Steven Edwards wrote:
>   Does the pspec here use Winebuild? Sorry I can't
> check at the moment.
>  If it does, the current winebuild allows you to specify exports for a
>  given arch by passing
>
>  -arch=cpu
>
>  in the spec file.
>     
Yes, it's a preprocessed spec file.
Cool, didn't know that feature. Will test later.

Thanks,
Timo

[Timo Kreuzer]

Ok, works nice for i386 and x86_64.
powerpc, sparc and alpha are also supported.
No luck for arm though.

So we could either send a patch to wine and hope it will be accepted or
continue to use #ifndef



Timo Kreuzer schrieb:
>   Steven Edwards wrote:
>    
> >   Does the pspec here use Winebuild? Sorry I
> > can't check at the moment.
> >  If it does, the current winebuild allows you to specify exports for a
> >  given arch by passing
> >
> >  -arch=cpu
> >
> >  in the spec file.
> >    
> >       
>  Yes, it's a preprocessed spec file.
>  Cool, didn't know that feature. Will test later.
>
>  Thanks,
>  Timo
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>

[Steven Edwards]

2009/2/10 Timo Kreuzer <timo.kreuzer(a)web.de>de>:
>   Ok, works nice for i386 and x86_64.
>  powerpc, sparc and alpha are also supported.
>  No luck for arm though.
>
>  So we could either send a patch to wine and hope it will be accepted or
>  continue to use #ifndef 
I expect arm would be accepted. The possibility of an arm port comes
up in discussion quite a bit on wine-devel and its been something I've
been meaning to take a look at for a while but never have had the
time. Patches are welcome

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo