Re: [ros-dev] rbuild auto generated resources

[Aleksey Bragin]

On Nov 12, 2007, at 1:56 AM, Timo Kreuzer wrote:

> >   Once again,
> > the data extracted from parsing is not TRUE metadata just
> >  meaningless strings that you can guess or interpret : "author :  
> >  jdoe" ,
> >  "author : jhondoe" , "author : jhon doe" are 3 different persons and
> >  Jhon Doe just one , I think it's obvious.
> >  
>  I disagree here. IMO information about developers and translators  
>  belong to svn. They should neither go into the sources nor into  
>  rbuild files. If you want to find out about it, ask svn and it will  
>  tell you the exact name. We also don't really have maintainers for  
>  most modules, so most rbuild files would be spammed with the names  
>  of lots of developers without saying anything about who wrote a  
>  paticular piece of code. 
There is standard per-file header for ReactOS source code (if it's  
not used everywhere, it's a temporary problem), which lists  
programmers, and it's usually (almost always) maintained. Whenever  
our code is indexed by systems like Google codesearch, everyone can  
clearly see the license and authorship from the source file.
Additionally, SVN holds exact per-line history of changes.

What's the benefit of storing authoship in .rbuild too? (I agree it  
is logical, but if there is no benefit, then...)

WBR,
Aleksey Bragin.

[Marc Piulachs]

>  There is standard per-file header for ReactOS source
> code (if it's  
> not used everywhere, it's a temporary problem), which lists  
> programmers, and it's usually (almost always) maintained.  
Yes Aleksey, I know, I never had the intention to replace author names in
headers, check my response to Timo for a brief explanation about it.

One thing though, One of the changes I introduced to rbuild is the
contributors.rbuild that has the following format :

	<contributor firstname="Aleksey" lastname="Bragin"
mail=&quot;aleksey(a)reactos.org&quot; alias="fireball" />
	<contributor firstname="Alex" lastname="Ionescu"
mail=&quot;alex.ionescu(a)reactos.org&quot; alias="ion" />
	<contributor firstname="Andrew" lastname="Greenwood"
mail=&quot;lists(a)silverblade.co.uk&quot; alias="silverblade" />

Every not occasional contributor gets an alias which is the unique name for
this author for rbuild , I would like to suggest adding this alias in
addition to the author name in the header comment to assist automatic
parsing at the same time is also human readable :

/*
/ (..)
/ Programers :
/				Jhon Doe (jdoe)
/				
/

It has the advantage of being easily automatizable as the author will use a
consistent ID despite string used to represent his name "J.Doe" sometimes
and "J Doe" others. You get the idea...

/Marc