Current build problem with ntoskrnl/io/disk.c

[Mike Lerwill]

Hi,

Following the most recent changes the build fails at present with the
following

ntoskrnl\io\disk.c:1614: error: conflicting types for 'IoReadPartitionTable'
w32api/include/ddk/win2k.h:67: error: previous declaration of
'IoReadPartitionTable' was here
ntoskrnl\io\disk.c:1614: error: conflicting types for 'IoReadPartitionTable'
w32api/include/ddk/win2k.h:67: error: previous declaration of
'IoReadPartitionTable' was here
ntoskrnl\io\disk.c:1641: error: conflicting types for
'IoWritePartitionTable'
w32api/include/ddk/win2k.h:86: error: previous declaration of
'IoWritePartitionTable' was here
ntoskrnl\io\disk.c:1641: error: conflicting types for
'IoWritePartitionTable'
w32api/include/ddk/win2k.h:86: error: previous declaration of
'IoWritePartitionTable' was here

regards

Mike Lerwill

[Steven Edwards]

Hi Mike,

--- Mike Lerwill <mlist(a)ml-solutions.co.uk> wrote:
>   ntoskrnl\io\disk.c:1614: error: conflicting types for
> 'IoReadPartitionTable'
>  w32api/include/ddk/win2k.h:67: error: previous declaration of
>  'IoReadPartitionTable' was here
>  ntoskrnl\io\disk.c:1614: error: conflicting types for 'IoReadPartitionTable'
>  w32api/include/ddk/win2k.h:67: error: previous declaration of
>  'IoReadPartitionTable' was here
>  ntoskrnl\io\disk.c:1641: error: conflicting types for
>  'IoWritePartitionTable'
>  w32api/include/ddk/win2k.h:86: error: previous declaration of
>  'IoWritePartitionTable' was here
>  ntoskrnl\io\disk.c:1641: error: conflicting types for
>  'IoWritePartitionTable'
>  w32api/include/ddk/win2k.h:86: error: previous declaration of
>  'IoWritePartitionTable' was here 
svn update and tell me your revision number and gcc version.

If you have gcc 3.4.1 or gcc4 and 16244 then its going to be broken.

Thanks
Steven



		
____________________________________________________ 
Yahoo! Sports 
Rekindle the Rivalries. Sign up for Fantasy Football 
http://football.fantasysports.yahoo.com

[Mike Lerwill]

Steven

svn update shows 16244
gcc -v shows gcc version 3.4.1 (mingw special)
os is w2k

commands run
	make ntoskrn_clean
	make ntoskrnl

build now fails at io/irq.c (passes io/disk.c with no problem)

	ntoskrnl\io\irq.c: In function `IoConnectInterrupt':
	ntoskrnl\io\irq.c:70: warning: 'Interrupt' might be used uninitialized in
this function
	make: *** [obj-i386\ntoskrnl\io\irq.o] Error 1

Which it is indeed correct to since Interrupt at line 98 should be replaced
with IoInterrupt

After this change the build completes successfully

Hope the abive is some help

Mike Lerwill

>   -----Original Message-----
>  From: ros-dev-bounces(a)reactos.com [mailto:[e-mail]]On
>  Behalf Of Steven Edwards
>  Sent: 23 June 2005 14:35
>  To: ReactOS Development List
>  Subject: Re: [ros-dev] Current build problem with ntoskrnl/io/disk.c
>
>
>  Hi Mike,
>
>  --- Mike Lerwill <mlist(a)ml-solutions.co.uk> wrote:
> >   ntoskrnl\io\disk.c:1614: error: conflicting types
> > for 
>  'IoReadPartitionTable'
>  > w32api/include/ddk/win2k.h:67: error: previous declaration of
>  > 'IoReadPartitionTable' was here
> >   ntoskrnl\io\disk.c:1614: error: conflicting types
> > for 
>  'IoReadPartitionTable'
> >   w32api/include/ddk/win2k.h:67: error: previous
> > declaration of
> >  'IoReadPartitionTable' was here
> >  ntoskrnl\io\disk.c:1641: error: conflicting types for
> >  'IoWritePartitionTable'
> >  w32api/include/ddk/win2k.h:86: error: previous declaration of
> >  'IoWritePartitionTable' was here
> >  ntoskrnl\io\disk.c:1641: error: conflicting types for
> >  'IoWritePartitionTable'
> >  w32api/include/ddk/win2k.h:86: error: previous declaration of
> >  'IoWritePartitionTable' was here 
>  svn update and tell me your revision number and gcc version.
>
>  If you have gcc 3.4.1 or gcc4 and 16244 then its going to be broken.
>
>  Thanks
>  Steven
>
>
>
>
>  ____________________________________________________
>  Yahoo! Sports
>  Rekindle the Rivalries. Sign up for Fantasy Football
>  http://football.fantasysports.yahoo.com
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>

[Rafal Kupiec]

I compiled ReactOS from SVN - revision: 16244. And it compiles correctly
for me. Let's find what are you doing wrong?

Mike Lerwill wrote:
>   Steven
>  
>  svn update shows 16244
>  gcc -v shows gcc version 3.4.1 (mingw special)
>  os is w2k
>  
>  commands run
>  	make ntoskrn_clean
>  	make ntoskrnl
>  
>  build now fails at io/irq.c (passes io/disk.c with no problem)
>  
>  	ntoskrnl\io\irq.c: In function `IoConnectInterrupt':
>  	ntoskrnl\io\irq.c:70: warning: 'Interrupt' might be used uninitialized in
>  this function
>  	make: *** [obj-i386\ntoskrnl\io\irq.o] Error 1
>  
>  Which it is indeed correct to since Interrupt at line 98 should be replaced
>  with IoInterrupt
>  
>  After this change the build completes successfully
>  
>  Hope the abive is some help
>  
>  Mike Lerwill
>  
>  
> >-----Original Message-----
> >From: ros-dev-bounces(a)reactos.com [mailto:[e-mail]]On
> >Behalf Of Steven Edwards
> >Sent: 23 June 2005 14:35
> >To: ReactOS Development List
> >Subject: Re: [ros-dev] Current build problem with ntoskrnl/io/disk.c
> >
> >
> >Hi Mike,
> >
> >--- Mike Lerwill <mlist(a)ml-solutions.co.uk> wrote:
> >
> >>ntoskrnl\io\disk.c:1614: error: conflicting types for
> >
> >'IoReadPartitionTable'
> >
> >>w32api/include/ddk/win2k.h:67: error: previous declaration of
> >>'IoReadPartitionTable' was here
> >>ntoskrnl\io\disk.c:1614: error: conflicting types for
> >
> >'IoReadPartitionTable'
> >
> >>w32api/include/ddk/win2k.h:67: error: previous declaration of
> >>'IoReadPartitionTable' was here
> >>ntoskrnl\io\disk.c:1641: error: conflicting types for
> >>'IoWritePartitionTable'
> >>w32api/include/ddk/win2k.h:86: error: previous declaration of
> >>'IoWritePartitionTable' was here
> >>ntoskrnl\io\disk.c:1641: error: conflicting types for
> >>'IoWritePartitionTable'
> >>w32api/include/ddk/win2k.h:86: error: previous declaration of
> >>'IoWritePartitionTable' was here
> >
> >svn update and tell me your revision number and gcc version.
> >
> >If you have gcc 3.4.1 or gcc4 and 16244 then its going to be broken.
> >
> >Thanks
> >Steven
> >
> >
> >
> >
> >____________________________________________________
> >Yahoo! Sports
> >Rekindle the Rivalries. Sign up for Fantasy Football
> >http://football.fantasysports.yahoo.com
> >_______________________________________________
> >Ros-dev mailing list
> >Ros-dev(a)reactos.com
> >http://reactos.com:8080/mailman/listinfo/ros-dev
> >

[Alex Ionescu]

Rafal Kupiec wrote:

>  I compiled ReactOS from SVN - revision: 16244. And it
> compiles correctly
> for me. Let's find what are you doing wrong?
>   
>  
Nothing, he found a bug.

Best regards,
Alex Ionescu