Re: [ros-dev] [ros-diffs] [sginsberg] 35822: - Fix build...

[Alex Ionescu]

Did you even TRY compiling your tree before committing? Clearly not...

Best regards,
Alex Ionescu



On Sun, Aug 31, 2008 at 1:06 AM,  <sginsberg(a)svn.reactos.org> wrote:
>   Author: sginsberg
>  Date: Sat Aug 30 18:06:13 2008
>  New Revision: 35822
>
>  URL: http://svn.reactos.org/svn/reactos?rev=35822&view=rev
>  Log:
>  - Fix build...
>
>  Modified:
>     trunk/reactos/include/psdk/winnt.h
>
>  Modified: trunk/reactos/include/psdk/winnt.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=3…
>  ==============================================================================
>  --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original)
>  +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Sat Aug 30 18:06:13 2008
>  @@ -4695,10 +4695,7 @@
>   MemoryBarrier(VOID)
>   {
>      LONG Barrier;
>  -    __asm__ __volatile__
>  -    {
>  -        xchg Barrier, eax
>  -    }
>  +    __asm__ __volatile__("xchgl %%eax, %[Barrier]" : : [Barrier] "m"
> (Barrier) : "memory");
>   }
>   #elif defined (_M_AMD64)
>   #define MemoryBarrier()
>
>

[Stefan Ginsberg]

Really sorry about the two build breakages.
>  From now on, always a full clean recompile before
> comitting any header changes... 
>   Date: Sun, 31 Aug 2008 13:22:43 +0200
>  From: ionucu(a)videotron.ca
>  To: ros-dev(a)reactos.org
>  CC: ros-diffs(a)reactos.org
>  Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35822: - Fix build...
>  
>  Did you even TRY compiling your tree before committing? Clearly not...
>  
>  Best regards,
>  Alex Ionescu
>  
>  
>  
>  On Sun, Aug 31, 2008 at 1:06 AM,  <sginsberg(a)svn.reactos.org> wrote:
> >   Author: sginsberg
> >  Date: Sat Aug 30 18:06:13 2008
> >  New Revision: 35822
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=35822&view=rev
> >  Log:
> >  - Fix build...
> >
> >  Modified:
> >     trunk/reactos/include/psdk/winnt.h
> >
> >  Modified: trunk/reactos/include/psdk/winnt.h
> >  URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=3…
> >  ==============================================================================
> >  --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original)
> >  +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Sat Aug 30 18:06:13 2008
> >  @@ -4695,10 +4695,7 @@
> >   MemoryBarrier(VOID)
> >   {
> >      LONG Barrier;
> >  -    __asm__ __volatile__
> >  -    {
> >  -        xchg Barrier, eax
> >  -    }
> >  +    __asm__ __volatile__("xchgl %%eax, %[Barrier]" : : [Barrier] "m"
> > (Barrier) : "memory");
> >   }
> >   #elif defined (_M_AMD64)
> >   #define MemoryBarrier()
> >
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 
_________________________________________________________________
Explore the seven wonders of the world
http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form…