Re: [ros-dev] [ros-diffs] [mjansen] 73180: [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049

[Thomas Faber]

APITests should be named after a function.
And in particular, they can't be named the same as a Wine test for the
same module. This is currently causing result submission on Testbot to
fail, so please rename this test.


On 2016-11-09 23:13, mjansen(a)svn.reactos.org wrote:
>   Author: mjansen
>  Date: Wed Nov  9 22:13:26 2016
>  New Revision: 73180
>
>  URL: http://svn.reactos.org/svn/reactos?rev=73180&view=rev
>  Log:
>  [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the
> App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049
>
>  Added:
>      trunk/rostests/apitests/shell32/shlexec.cpp   (with props)
>  Modified:
>      trunk/rostests/apitests/shell32/CMakeLists.txt
>      trunk/rostests/apitests/shell32/testlist.c

[Yarolslav Veremenko]

Hi Thomas,

I don't think mjansen is available today. It's my patch. I can update CORE-12049
with fixes, so you can commit or send it through mail list.

Yaroslav

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Thomas Faber
Sent: Wednesday, November 9, 2016 4:06 PM
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [mjansen] 73180: [SHELL32_APITEST] Add some tests for
ShellExecuteEx showing extension completion with the App Paths registry key. Patch by
Yaroslav Veremenko. CORE-12049

APITests should be named after a function.
And in particular, they can't be named the same as a Wine test for the same module.
This is currently causing result submission on Testbot to fail, so please rename this
test.


On 2016-11-09 23:13, mjansen(a)svn.reactos.org wrote:
>   Author: mjansen
>  Date: Wed Nov  9 22:13:26 2016
>  New Revision: 73180
>
>  URL: http://svn.reactos.org/svn/reactos?rev=73180&view=rev
>  Log:
>  [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension 
>  completion with the App Paths registry key. Patch by Yaroslav 
>  Veremenko. CORE-12049
>
>  Added:
>      trunk/rostests/apitests/shell32/shlexec.cpp   (with props)
>  Modified:
>      trunk/rostests/apitests/shell32/CMakeLists.txt
>      trunk/rostests/apitests/shell32/testlist.c 

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Mark Jansen]

Hey,

I just saw the email on my phone, I'll fix it.

On Thu, Nov 10, 2016 at 12:14 AM, Yarolslav Veremenko <
yaroslav(a)veremenko.info&gt; wrote:

>   Hi Thomas,
>
>  I don't think mjansen is available today. It's my patch. I can update
>  CORE-12049 with fixes, so you can commit or send it through mail list.
>
>  Yaroslav
>
>  -----Original Message-----
>  From: Ros-dev [mailto:[e-mail]] On Behalf Of Thomas
>  Faber
>  Sent: Wednesday, November 9, 2016 4:06 PM
>  To: ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] [ros-diffs] [mjansen] 73180: [SHELL32_APITEST] Add
>  some tests for ShellExecuteEx showing extension completion with the App
>  Paths registry key. Patch by Yaroslav Veremenko. CORE-12049
>
>  APITests should be named after a function.
>  And in particular, they can't be named the same as a Wine test for the
>  same module. This is currently causing result submission on Testbot to
>  fail, so please rename this test.
>
>
>  On 2016-11-09 23:13, mjansen(a)svn.reactos.org wrote:
> >   Author: mjansen
> >  Date: Wed Nov  9 22:13:26 2016
> >  New Revision: 73180
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=73180&view=rev
> >  Log:
> >  [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension
> >  completion with the App Paths registry key. Patch by Yaroslav
> >  Veremenko. CORE-12049
> >
> >  Added:
> >      trunk/rostests/apitests/shell32/shlexec.cpp   (with props)
> >  Modified:
> >      trunk/rostests/apitests/shell32/CMakeLists.txt
> >      trunk/rostests/apitests/shell32/testlist.c 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>