Re: [ros-diffs] [gvg] 18410: Terminate the new environment with a NULL pointer

[Gunnar Dalsnes]

There are probably dozens of bugs like that lurking around in crt, 
exposed by malloc not zeroing memory anymore...

gvg(a)svn.reactos.com wrote:
>   Terminate the new environment with a NULL pointer
>  
>  Modified: trunk/reactos/lib/crt/misc/environ.c
>  
>  ------------------------------------------------------------------------
>  *Modified: trunk/reactos/lib/crt/misc/environ.c*
>  
>  --- trunk/reactos/lib/crt/misc/environ.c	2005-10-12 08:38:45 UTC (rev 18409)
>  +++ trunk/reactos/lib/crt/misc/environ.c	2005-10-12 13:00:34 UTC (rev 18410)
>  @@ -178,6 +178,7 @@
>  
>            return original_environment;
>         }
>      }
>  
>  +   *newenvptr = NULL;
>  
>   
>      return newenv;
>   }
>

[Ge van Geldorp]

>   From: Gunnar Dalsnes
>  
>  There are probably dozens of bugs like that lurking around in 
>  crt, exposed by malloc not zeroing memory anymore... 
Yup. I suggest we put back the HEAP_ZERO_MEMORY flag in the 0.2.8 branch but
leave it out in trunk. That way these bugs won't be triggered in the 0.2.8
release, but we still can find and fix them in trunk.

Gé van Geldorp.