Re: [ros-svn] [mbosma] 16593: - Build failure

[Gge]

[e-mail] wrote:
> HUMA2000: Spanish translation
>
> Updated files:
> trunk/rosapps/packmgr/lib/es.rc

Building the Rosapps module fails with the following error :

D:\Reactos\Svn\rosapps>svn update
U  packmgr\lib\es.rc
Updated to revision 16597.

D:\Gerard\Reactos\Svn\rosapps>mingw32-make clean
mingw32-make: *** No rule to make target `clean'.  Stop.

Any idea ?

Best regards

[Martin Fuchs]

> Building the Rosapps module fails with the following error :
>
> D:\Reactos\Svn\rosapps>svn update
> U  packmgr\lib\es.rc
> Updated to revision 16597.
>
> D:\Gerard\Reactos\Svn\rosapps>mingw32-make clean
> mingw32-make: *** No rule to make target `clean'.  Stop.
>
> Any idea ?

Looking at the comment of commit 15920 (Makefiles have been deleted in
the next commit) shows the answer:

Created XML makefiles for rosapps. You need to checkout /rosapps in
your /reactos folder to use it. This projects do not build:
/lib/dflat32 and /welcome (I don't know if they did before). Winemine
does not work. (but it builds) /test makefiles are not done yet.

Regards,

Martin

[Gge]

Martin Fuchs wrote:
> > Building the Rosapps module fails with the following error :
> >
> > D:\Reactos\Svn\rosapps>svn update
> > U  packmgr\lib\es.rc
> > Updated to revision 16597.
> >
> > D:\Reactos\Svn\rosapps>mingw32-make clean
> > mingw32-make: *** No rule to make target `clean'.  Stop.
> Looking at the comment of commit 15920 (Makefiles have been deleted in
> the next commit) shows the answer:
>
> Created XML makefiles for rosapps. You need to checkout /rosapps in
> your /reactos folder to use it. This projects do not build:
> /lib/dflat32 and /welcome (I don't know if they did before). Winemine
> does not work. (but it builds) /test makefiles are not done yet.
>
> Regards,
>
> Martin

Thanks Martin,

I did checkout rosapps module from Reactos folder = ok
But still cannot build rosapps module = Same error

Regards
Gerard

[Martin Fuchs]

> Thanks Martin,
>
> I did checkout rosapps module from Reactos folder = ok
> But still cannot build rosapps module = Same error

Yes, seems it is not enough to move rosapps into the reactos folder.
You have also to include the following few lines into ReactOS.XML (for
example right at the end before the "</project>" line:

<directory name="rosapps">
    	<xi:include href="rosapps/directory.xml" />
    </directory>

After that you can go into the reactos directory, and start the build
with 'make'. The created binaries are placed into folder under
'output-i386\rosapps'.

Perhaps we should move the whole rosapps folder also in the repository
into the reactos tree, and add it permanently to ReactOS.XML ?

Regards,

Martin

[Casper Hornstrup]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Martin Fuchs
> Sent: 17. juli 2005 11:34
> To: Gge
> Cc: ReactOS Development List
> Subject: Re: [ros-dev] Re: [ros-svn] [mbosma] 16593: - Rosapps Build failure
> > Thanks Martin,
> >
> > I did checkout rosapps module from Reactos folder = ok
> > But still cannot build rosapps module = Same error
>
> Perhaps we should move the whole rosapps folder also in the repository
> into the reactos tree, and add it permanently to ReactOS.XML ?

That would mean you need to always checkout rosapps. I was thinking
we could checkout modules other than reactos into reactos/modules/ and
use xi:fallback to make it optional. E.g.

<xi:include href="rosapps/directory.xml">
    xi:fallback
    	<xi:include href="empty.xml" />
    </xi:fallback>
</xi:include>

If modules/rosapps/directory.xml does not exist, then empty.xml is included
instead, thus making rosapps an optional dependency.

Casper

[Martin Fuchs]

Hi Casper,
> > Perhaps we should move the whole rosapps folder also in the repository
> > into the reactos tree, and add it permanently to ReactOS.XML ?
>
> That would mean you need to always checkout rosapps. I was thinking
> we could checkout modules other than reactos into reactos/modules/ and
> use xi:fallback to make it optional. E.g.
>
> <xi:include href="rosapps/directory.xml">
>        xi:fallback
>                <xi:include href="empty.xml" />
>        </xi:fallback>
> </xi:include>
>
> If modules/rosapps/directory.xml does not exist, then empty.xml is included
> instead, thus making rosapps an optional dependency.

Good idea, but when moving rosapps into reactos/modules currently the
build failes for me with this error:

# Creating directories...done
# Unpacking WINE resources...done
# Generating test support code...done
# Generating proxy makefiles...done
# Checking automatic dependencies...File
'modules\cmdutils\mode\mode.c' not found.
# make.exe: *** [makefile.auto] Error 1

Somehow the build system seems to forget the 'rosapps' subfolder when
generating the paths in makefile.auto: It should be
"'modules\rosapps\cmdutils\mode\mode.c'", not
"'modules\cmdutils\mode\mode.c'".

Regards,

Martin

[Casper Hornstrup]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Martin Fuchs
> Sent: 17. juli 2005 12:31
> To: ReactOS Development List
> Subject: Re: [ros-dev] Re: [ros-svn] [mbosma] 16593: - Rosapps Build failure
>
> Hi Casper,
>
> Somehow the build system seems to forget the 'rosapps' subfolder when
> generating the paths in makefile.auto: It should be
> "'modules\rosapps\cmdutils\mode\mode.c'", not
> "'modules\cmdutils\mode\mode.c'".
>
> Regards,
>
> Martin

Try r16610.

[Martin Fuchs]

> > Somehow the build system seems to forget the 'rosapps' subfolder when
> > generating the paths in makefile.auto: It should be
> > "'modules\rosapps\cmdutils\mode\mode.c'", not
> > "'modules\cmdutils\mode\mode.c'".
> >
> > Regards,
> >
> > Martin
>
> Try r16610.

OK, thanks - this solves the problem.

Regards,

Martin