Re: [ros-dev] [ros-diffs] [hbelusca] 58016: [MSVCRT] Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are : int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src, int srclen, wcha...

[Jérôme Gardou]

I think that in the spec files semantics, destination strings are just 
buffers and should be considered as pointers.

hbelusca(a)svn.reactos.org a écrit :
>   Author: hbelusca
>  Date: Wed Dec 26 19:26:08 2012
>  New Revision: 58016
>
>  URL: http://svn.reactos.org/svn/reactos?rev=58016&view=rev
>  Log:
>  [MSVCRT]
>  Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are :
>
>  int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src,
>       int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int xflag)
>
>  and
>
>  int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src,
>       int srclen, char* dst, int dstlen, unsigned int codepage, int xflag)
>
>  Needed by SVN.
>
>  Modified:
>       trunk/reactos/dll/win32/msvcrt/msvcrt.spec
>
>  Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp…
>  ==============================================================================
>  --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Wed Dec 26 19:26:08 2012
>  @@ -143,8 +143,8 @@
>    @ cdecl __crtCompareStringW(long long wstr long wstr long) kernel32.CompareStringW
>    @ cdecl __crtGetLocaleInfoW(long long ptr long) kernel32.GetLocaleInfoW
>    @ cdecl __crtGetStringTypeW(long long wstr long ptr)
>  -@ cdecl __crtLCMapStringA(long long str long ptr long long long)
>  -# stub __crtLCMapStringW
>  +@ cdecl __crtLCMapStringA(long long str long str long long long)
>  +@ cdecl __crtLCMapStringW(long long wstr long wstr long long long)
>    @ cdecl __daylight() __p__daylight
>    @ cdecl __dllonexit(ptr ptr ptr)
>    @ cdecl __doserrno()
>
>

[Hermès BÉLUSCA - MAÏTO]

So why do 'str' and 'wstr' exist ?

Hermès.

-----Message d'origine-----
De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la part de Jérôme
Gardou
Envoyé : vendredi 28 décembre 2012 00:17
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 58016: [MSVCRT] Export __crtLCMapStringW and
correct __crtLCMapStringA: their prototypes are : int CDECL __crtLCMapStringW(LCID lcid,
DWORD mapflags, const wchar_t *src, int srclen, wcha...

I think that in the spec files semantics, destination strings are just buffers and should
be considered as pointers.

hbelusca(a)svn.reactos.org a écrit :
>   Author: hbelusca
>  Date: Wed Dec 26 19:26:08 2012
>  New Revision: 58016
>
>  URL: http://svn.reactos.org/svn/reactos?rev=58016&view=rev
>  Log:
>  [MSVCRT]
>  Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are :
>
>  int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src,
>       int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int 
>  xflag)
>
>  and
>
>  int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src,
>       int srclen, char* dst, int dstlen, unsigned int codepage, int 
>  xflag)
>
>  Needed by SVN.
>
>  Modified:
>       trunk/reactos/dll/win32/msvcrt/msvcrt.spec
>
>  Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec
>  URL: 
>  http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvc
>  rt.spec?rev=58016&r1=58015&r2=58016&view=diff
>  ======================================================================
>  ========
>  --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Wed Dec 26 
>  +++ 19:26:08 2012
>  @@ -143,8 +143,8 @@
>    @ cdecl __crtCompareStringW(long long wstr long wstr long) kernel32.CompareStringW
>    @ cdecl __crtGetLocaleInfoW(long long ptr long) kernel32.GetLocaleInfoW
>    @ cdecl __crtGetStringTypeW(long long wstr long ptr) -@ cdecl 
>  __crtLCMapStringA(long long str long ptr long long long) -# stub 
>  __crtLCMapStringW
>  +@ cdecl __crtLCMapStringA(long long str long str long long long) @ 
>  +cdecl __crtLCMapStringW(long long wstr long wstr long long long)
>    @ cdecl __daylight() __p__daylight
>    @ cdecl __dllonexit(ptr ptr ptr)
>    @ cdecl __doserrno()
>
>  
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Jérôme Gardou]

For input strings. I think that's not relevant to us anyway, as wine 
uses this for relay tracing, that we don't use nor have any 
implementation of.

Jérôme.

Hermès BÉLUSCA - MAÏTO a écrit :
>   So why do 'str' and 'wstr' exist ?
>
>  Hermès.
>
>  -----Message d'origine-----
>  De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la part de
> Jérôme Gardou
>  Envoyé : vendredi 28 décembre 2012 00:17
>  À : ros-dev(a)reactos.org
>  Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 58016: [MSVCRT] Export __crtLCMapStringW and
> correct __crtLCMapStringA: their prototypes are : int CDECL __crtLCMapStringW(LCID lcid,
> DWORD mapflags, const wchar_t *src, int srclen, wcha...
>
>  I think that in the spec files semantics, destination strings are just buffers and should
> be considered as pointers.
>
>  hbelusca(a)svn.reactos.org a écrit :
> >   Author: hbelusca
> >  Date: Wed Dec 26 19:26:08 2012
> >  New Revision: 58016
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=58016&view=rev
> >  Log:
> >  [MSVCRT]
> >  Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are :
> >
> >  int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src,
> >        int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int
> >  xflag)
> >
> >  and
> >
> >  int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src,
> >        int srclen, char* dst, int dstlen, unsigned int codepage, int
> >  xflag)
> >
> >  Needed by SVN.
> >
> >  Modified:
> >        trunk/reactos/dll/win32/msvcrt/msvcrt.spec
> >
> >  Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec
> >  URL:
> >  http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvc
> >  rt.spec?rev=58016&r1=58015&r2=58016&view=diff
> >  ======================================================================
> >  ========
> >  --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original)
> >  +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Wed Dec 26
> >  +++ 19:26:08 2012
> >  @@ -143,8 +143,8 @@
> >     @ cdecl __crtCompareStringW(long long wstr long wstr long) kernel32.CompareStringW
> >     @ cdecl __crtGetLocaleInfoW(long long ptr long) kernel32.GetLocaleInfoW
> >     @ cdecl __crtGetStringTypeW(long long wstr long ptr) -@ cdecl
> >  __crtLCMapStringA(long long str long ptr long long long) -# stub
> >  __crtLCMapStringW
> >  +@ cdecl __crtLCMapStringA(long long str long str long long long) @
> >  +cdecl __crtLCMapStringW(long long wstr long wstr long long long)
> >     @ cdecl __daylight() __p__daylight
> >     @ cdecl __dllonexit(ptr ptr ptr)
> >     @ cdecl __doserrno()
> >
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>