Re: [ros-svn] [ekohl] 14656: Support out-pointers to structs.

[Thomas Weidenmueller]

ekohl(a)svn.reactos.com wrote:
>   Support out-pointers to structs.
>  
>  
>  Updated files:
>  trunk/reactos/tools/widl/ChangeLog
>  trunk/reactos/tools/widl/server.c 
I believe these changes causes a crash when trying to compile 
subsys/system/services:

gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
-D_WIN32_WINNT=
0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
-I../../.
./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
rpcserver.
c | ..\..\..\tools\depends.exe . .rpcserver.d
rpcserver.c:13:22: svcctl_s.h: No such file or directory
gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
-D_WIN32_WINNT=
0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
-I../../.
./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
services.c
  | ..\..\..\tools\depends.exe . .services.d
gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
-D_WIN32_WINNT=
0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
-I../../.
./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
database.c
  | ..\..\..\tools\depends.exe . .database.d
../../../tools/widl/widl -o -h -H svcctl_s.h -s -S svcctl_s.c 
../../../include/i
dl/svcctl.idl

../../../include/idl/svcctl.idl:124: Oops, segment violation

This application has requested the Runtime to terminate it in an unusual 
way.
Please contact the application's support team for more information.
make: *** [svcctl_s.c] Error 3

[Eric Kohl]

Thomas Weidenmueller wrote:

>   I believe these changes causes a crash when trying to
> compile 
>  subsys/system/services:
>  
>  gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
>  -D_WIN32_WINNT=
>  0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
>  -I../../.
>  ./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
>  rpcserver.
>  c | ..\..\..\tools\depends.exe . .rpcserver.d
>  rpcserver.c:13:22: svcctl_s.h: No such file or directory
>  gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
>  -D_WIN32_WINNT=
>  0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
>  -I../../.
>  ./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
>  services.c
>   | ..\..\..\tools\depends.exe . .services.d
>  gcc -Wall -Werror -fno-builtin -D__USE_W32API -D_WIN32_IE=0x0500 
>  -D_WIN32_WINNT=
>  0x501 -DWINVER=0x600 -DUNICODE -D_UNICODE -I. -O2 -Wno-strict-aliasing 
>  -I../../.
>  ./include -I../../../w32api/include -pipe -march=i486 -D_M_IX86 -g -M 
>  database.c
>   | ..\..\..\tools\depends.exe . .database.d
>  ../../../tools/widl/widl -o -h -H svcctl_s.h -s -S svcctl_s.c 
>  ../../../include/i
>  dl/svcctl.idl
>  
>  ../../../include/idl/svcctl.idl:124: Oops, segment violation
>  
>  This application has requested the Runtime to terminate it in an unusual 
>  way.
>  Please contact the application's support team for more information.
>  make: *** [svcctl_s.c] Error 3 
I cannot reproduce this on my windows machine. Can you run 'make 
services_clean' and 'make services' again?


Regards,
Eric

[WaxDragon]

I get the same error.  Does the missing svcctl_s.h have anything to do with it?:

msiexec: [RSYM] msiexec.exe
regsvr32: [RC] regsvr32.rc
regsvr32: [CC] regsvr32.c
regsvr32: [AR] regsvr32.a
regsvr32: [LD] regsvr32.nostrip.exe
regsvr32: [OBJDUMP] regsvr32.map
regsvr32: [RSYM] regsvr32.exe
reporterror: [RC] reporterror.rc
reporterror.rc:19:17: Dk.rc: No such file or directory
reporterror: [CC] reporterror.c
reporterror: [AR] reporterror.a
reporterror: [LD] reporterror.nostrip.exe
reporterror: [OBJDUMP] reporterror.map
reporterror: [RSYM] reporterror.exe
services: [DEPENDS] .rpcserver.d
rpcserver.c:13:22: svcctl_s.h: No such file or directory
services: [DEPENDS] .services.d
services: [DEPENDS] .database.d

../../../include/idl/svcctl.idl:124: Oops, segment violation
make[1]: *** [svcctl_s.c] Aborted
make[1]: *** Deleting file `svcctl_s.c'
make: *** [services] Error 2



>   
>  I cannot reproduce this on my windows machine. Can you run 'make
>  services_clean' and 'make services' again?
>   
ford@phoenix:~/src/reactos$ make services_clean
services: [CLEAN]
ford@phoenix:~/src/reactos$ make services
services: [DEPENDS] .rpcserver.d
rpcserver.c:13:22: svcctl_s.h: No such file or directory
services: [DEPENDS] .services.d
services: [DEPENDS] .database.d

../../../include/idl/svcctl.idl:124: Oops, segment violation
make[1]: *** [svcctl_s.c] Aborted
make[1]: *** Deleting file `svcctl_s.c'
make: *** [services] Error 2



-- 
"<tinus_> and also win32k should be fixed up a bit"

[Eric Kohl]

WaxDragon wrote:
>   I get the same error.  Does the missing svcctl_s.h
> have anything to do with it?:
>  
>  msiexec: [RSYM] msiexec.exe
>  regsvr32: [RC] regsvr32.rc
>  regsvr32: [CC] regsvr32.c
>  regsvr32: [AR] regsvr32.a
>  regsvr32: [LD] regsvr32.nostrip.exe
>  regsvr32: [OBJDUMP] regsvr32.map
>  regsvr32: [RSYM] regsvr32.exe
>  reporterror: [RC] reporterror.rc
>  reporterror.rc:19:17: Dk.rc: No such file or directory
>  reporterror: [CC] reporterror.c
>  reporterror: [AR] reporterror.a
>  reporterror: [LD] reporterror.nostrip.exe
>  reporterror: [OBJDUMP] reporterror.map
>  reporterror: [RSYM] reporterror.exe
>  services: [DEPENDS] .rpcserver.d
>  rpcserver.c:13:22: svcctl_s.h: No such file or directory
>  services: [DEPENDS] .services.d
>  services: [DEPENDS] .database.d
>  
>  ../../../include/idl/svcctl.idl:124: Oops, segment violation
>  make[1]: *** [svcctl_s.c] Aborted
>  make[1]: *** Deleting file `svcctl_s.c'
>  make: *** [services] Error 2 
Yes, WIDL generates svcctl_s.h and svcctl_s.c from include/idl/svcctl.idl.

It definitely works on Windows using GNU make 2.79.1. Perhaps it doesn't 
work on Linux or with another versionof 'make'.


Eric

[Hartmut Birr]

Eric Kohl wrote:

>   WaxDragon wrote:
>
> >   I get the same error.  Does the missing
> > svcctl_s.h have anything to
> >  do with it?:
> >
> >  msiexec: [RSYM] msiexec.exe
> >  regsvr32: [RC] regsvr32.rc
> >  regsvr32: [CC] regsvr32.c
> >  regsvr32: [AR] regsvr32.a
> >  regsvr32: [LD] regsvr32.nostrip.exe
> >  regsvr32: [OBJDUMP] regsvr32.map
> >  regsvr32: [RSYM] regsvr32.exe
> >  reporterror: [RC] reporterror.rc
> >  reporterror.rc:19:17: Dk.rc: No such file or directory
> >  reporterror: [CC] reporterror.c
> >  reporterror: [AR] reporterror.a
> >  reporterror: [LD] reporterror.nostrip.exe
> >  reporterror: [OBJDUMP] reporterror.map
> >  reporterror: [RSYM] reporterror.exe
> >  services: [DEPENDS] .rpcserver.d
> >  rpcserver.c:13:22: svcctl_s.h: No such file or directory
> >  services: [DEPENDS] .services.d
> >  services: [DEPENDS] .database.d
> >
> >  ../../../include/idl/svcctl.idl:124: Oops, segment violation
> >  make[1]: *** [svcctl_s.c] Aborted
> >  make[1]: *** Deleting file `svcctl_s.c'
> >  make: *** [services] Error 2 
>
>  Yes, WIDL generates svcctl_s.h and svcctl_s.c from
>  include/idl/svcctl.idl.
>
>  It definitely works on Windows using GNU make 2.79.1. Perhaps it
>  doesn't work on Linux or with another versionof 'make'.
>
>  
It has nothing to do with the version of make. I'm using WinXP. Calling

..\..\..\tools\widl\widl -o -h -H svcctl_s.h -s -S svcctl_s.c
../../../include/idl/svcctl.idl

from within the service directory results in

../../../include/idl/svcctl.idl:124: Oops, segment violation

This application has requested the Runtime to terminate it in an unusual
way.
Please contact the application's support team for more information.

- Hartmut

[Thomas Weidenmueller]

Hartmut Birr wrote:
>   It has nothing to do with the version of make. I'm
> using WinXP. Calling
>  
>  ..\..\..\tools\widl\widl -o -h -H svcctl_s.h -s -S svcctl_s.c
>  ../../../include/idl/svcctl.idl
>  
>  from within the service directory results in
>  
>  ../../../include/idl/svcctl.idl:124: Oops, segment violation
>  
>  This application has requested the Runtime to terminate it in an unusual
>  way.
>  Please contact the application's support team for more information.
>  
>  - Hartmut 
I can confirm that, too. I'm compiling in WinXP as well, and i just 
checked out a new tree, the problem is still there.

Best Regards,
Thomas

[Mike Lerwill]

I'm seeing exactly the same message compiling under W2k


>   Hartmut Birr wrote:
>  > It has nothing to do with the version of make. I'm using WinXP. Calling
>  >
>  > ..\..\..\tools\widl\widl -o -h -H svcctl_s.h -s -S svcctl_s.c
>  > ../../../include/idl/svcctl.idl
>  >
>  > from within the service directory results in
>  >
>  > ../../../include/idl/svcctl.idl:124: Oops, segment violation
>  >
>  > This application has requested the Runtime to terminate it in an unusual
>  > way.
>  > Please contact the application's support team for more information.
>  >
>  > - Hartmut

[Eric Kohl]

Hartmut Birr wrote:

>   It has nothing to do with the version of make. I'm
> using WinXP. Calling
>  
>  ..\..\..\tools\widl\widl -o -h -H svcctl_s.h -s -S svcctl_s.c
>  ../../../include/idl/svcctl.idl
>  
>  from within the service directory results in
>  
>  ../../../include/idl/svcctl.idl:124: Oops, segment violation
>  
>  This application has requested the Runtime to terminate it in an unusual
>  way.
>  Please contact the application's support team for more information. 
Hartmut, you're right!

Windows 2000 shows the segment violation too; but it soesn't show up on 
Win98. I'll fix it ASAP.


Eric