Re: [ros-dev] [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources

[Andrew Faulds]

Isn't that just a audio driver regression not an Install wizard one?
"Starting a device node without DNF_ADDED"

On 22 April 2010 14:09, Gabriel ilardi <gabrielilardi(a)hotmail.it> wrote:

>    Hi,
>  Device installation wizard has regressed again, now if you try to install
>  the AC97 driver, it remains in a loop, and ros slows down at the point of
>  being unusabe,
>  the debug log shows:
>
>  (ntoskrnl/io/pnpmgr/pnpmgr.c:190) Warning: Starting a device node without
>  DNF_ADDED or DNF_ENUMERATED (Root\LEGACY_kmixer\0000)
>
>  Thanks,
>
>  Gabriel.
>
> >   Date: Wed, 21 Apr 2010 22:33:12 +0000
> >  To: ros-diffs(a)reactos.org
> >  From: cgutman(a)svn.reactos.org
> >  Subject: [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken 
> CM_RESOURCE_LIST_SIZE with a better function that actually works with
>  resource lists that have device-specific data in them (fixes missing device
>  specific data when resources are retrieved with IoGetDeviceProperty) -
>  Separate the resource code out of pnpmgr.c and into pnpres.c - Simplify
>  resource assigning to simply calling one function, IopAssignDeviceResources,
>  which takes care of the registry configuration, translation, etc. - Set the
>  DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not
>  before - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails - Fix a bug in
>  IoReportDetectedDevice that wrote the AllocConfig value to wrong place
> >  
> >  Author: cgutman
> >  Date: Thu Apr 22 00:33:11 2010
> >  New Revision: 46983
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=46983&view=rev
> >  Log:
> >  [NTOSKRNL]
> >  - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that 
>  actually
> works with resource lists that have device-specific data in them
>  (fixes missing device specific data when resources are retrieved with
>  IoGetDeviceProperty)
> >   - Separate the resource code out of pnpmgr.c and
> > into pnpres.c
> >  - Simplify resource assigning to simply calling one function, 
> IopAssignDeviceResources, which takes care of the registry configuration,
>  translation, etc.
> >   - Set the DNF_NEED_ENUMERATION_ONLY flag only
> > AFTER the device is 
>  actually started not before
> >   - Set DNF_START_FAILED if IRP_MN_START_DEVICE
> > fails
> >  - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to 
>  wrong
> place
> >  
> >  Added:
> >  trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c (with props)
> >  Modified:
> >  trunk/reactos/ntoskrnl/include/internal/io.h
> >  trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
> >  trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c
> >  trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild 
>  ------------------------------
>  Condividi le tue emozioni e proteggi la tua privacy. Chiacchiera su
>  Messenger <http://www.windowslive.it/importaAmici.aspx>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  


-- 
Andrew Faulds (andrewros)
http://ajf.me/