Re: [ros-dev] [ros-diffs] [tkreuzer] 47295: [WIN32K / USER32] Convert the window text string from UNICODE_STRING to LARGE_STRING and fix NtUserCreateWindowEx parameters. We currently still pass UNICODE only LARGE_STRINGs, as the rest of the code in win32k expects this. Fixes display of large text windows, like the winzip license. See issue #2900 for more details.

[Aleksey Bragin]

Shouldn't the LARGE_UNICODE_STRING be used there instead?

WBR,
Aleksey.

On May 22, 2010, at 5:05 AM, tkreuzer(a)svn.reactos.org wrote:

>   Author: tkreuzer
>  Date: Sat May 22 03:05:31 2010
>  New Revision: 47295
>
>  URL: http://svn.reactos.org/svn/reactos?rev=47295&view=rev
>  Log:
>  [WIN32K / USER32]
>  Convert the window text string from UNICODE_STRING to LARGE_STRING  
>  and fix NtUserCreateWindowEx parameters. We currently still pass  
>  UNICODE only LARGE_STRINGs, as the rest of the code in win32k  
>  expects this.
>  Fixes display of large text windows, like the winzip license.
>  See issue #2900 for more details.
>
>  Modified:
>      trunk/reactos/dll/win32/user32/windows/window.c
>      trunk/reactos/include/reactos/win32k/ntuser.h
>      trunk/reactos/subsystems/win32/win32k/include/window.h
>      trunk/reactos/subsystems/win32/win32k/ntuser/desktop.c
>      trunk/reactos/subsystems/win32/win32k/ntuser/message.c
>      trunk/reactos/subsystems/win32/win32k/ntuser/painting.c
>      trunk/reactos/subsystems/win32/win32k/ntuser/window.c

[Timo Kreuzer]

Aleksey Bragin wrote:
>   Shouldn't the LARGE_UNICODE_STRING be used there
> instead?
>  
On Windows the window name is ANSI for an ANSI caller and UNICODE for a
UNICODE caller.
The class name is always in UNICODE though.

See also http://www.reactos.org/wiki/Techwiki:Win32k/LARGE_UNICODE_STRING