RE: [ros-dev] State of the 0.2.9 branch

[Murphy, Ged (Bolton)]

Ge van Geldorp wrote:
> Last item is perhaps a bit controversial. I don't like the huge icons in

the
> start menu. It also makes the start menu not fit in 640x480. Can we please
> go back to smaller icons?

If my memory serves me correctly, (I don't have the code in front of me),
this change was intended to support 24x24 icons in the start menu as per
Windows. However as we don't have any 24x24 icons, it defaults to 32x32 (the
huge ones we see now)

I have this reverted in my tree. I was going to revert it in HEAD until we
have 24x24 icons to allow the change to work as it should. However I haven't
been able to get hold of Martin and didn't want to revert without his say
so.

I think reverting in the 0.2.9 branch would be ok though and I'll do it
later if no one objects.

Ged.

************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
[e-mail] 
mailto:[e-mail] and then delete this message.

Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com

[Martin Fuchs]

> I have this reverted in my tree. I was going to revert it in HEAD until we
> have 24x24 icons to allow the change to work as it should. However I haven't
> been able to get hold of Martin and didn't want to revert without his say
> so.

Did you try to reach me by mail?
If you want to switch back to small icons in the start menu for now,
just apply the following patch:

Index: D:/ros/explorer/taskbar/startmenu.cpp
===================================================================
--- D:/ros/explorer/taskbar/startmenu.cpp (revision 20099)
+++ D:/ros/explorer/taskbar/startmenu.cpp (working copy)
@@ -1546,7 +1546,7 @@

StartMenuRoot::StartMenuRoot(HWND hwnd)
- : super(hwnd, true) ///@todo big icons in start menu root
+ : super(hwnd, false) ///@todo small icons in start menu root
{
#ifndef __MINGW32__ // SHRestricted() missing in MinGW (as of 29.10.2003)
if (!g_Globals._SHRestricted || !SHRestricted(REST_NOCOMMONGROUPS))

Regards,

Martin

[Ged Murphy]

Martin Fuchs wrote:
> > I have this reverted in my tree. I was going to revert it in HEAD until we
> > have 24x24 icons to allow the change to work as it should. However I haven't
> > been able to get hold of Martin and didn't want to revert without his say
> > so.
>
> Did you try to reach me by mail?

Hi martin,
Yeah I tried to reach you by mail. I'm sure it wasn't a gmail account 
which I used though. ???
Perhaps I got it wrong.
> If you want to switch back to small icons in the start menu for now,
> just apply the following patch:
> Index: D:/ros/explorer/taskbar/startmenu.cpp
>
> --- D:/ros/explorer/taskbar/startmenu.cpp (revision 20099)
> +++ D:/ros/explorer/taskbar/startmenu.cpp (working copy)
> @@ -1546,7 +1546,7 @@
>
> StartMenuRoot::StartMenuRoot(HWND hwnd)
> : super(hwnd, true) ///@todo big icons in start menu root
> : super(hwnd, false) ///@todo small icons in start menu root
>
> {
> #ifndef __MINGW32__ // SHRestricted() missing in MinGW (as of 29.10.2003)
> if (!g_Globals._SHRestricted || !SHRestricted(REST_NOCOMMONGROUPS))

Thanks for the patch. I hadn't realised it was such a simple change.

Ged.

[WaxDragon]

Blockers have been adjusted in Bugzilla.  The start menu icons have
been set back to the smaller ones.  If I can pin down the csrss crash
I see when shutting down, I will file a bug on it too.

WD
--
<Russell> argh
<Russell> iterator shenanigans :/