Re: [ros-dev] [ros-diffs] [ekohl] 58326: [MSGINA] - Fix a typo in the german lock dialog. - Store the user name and domain in the gina context and use them in the lock dialog. - Initialize the LOGONSERVER environment variable.

[Thomas Faber]

Hey Eric,

On 2013-02-17 02:06, ekohl(a)svn.reactos.org wrote:
>   Modified: trunk/reactos/dll/win32/msgina/msgina.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?…
>  ==============================================================================
>  --- trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] (original)
>  +++ trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] Sun Feb 17 01:06:24 2013
>  @@ -456,13 +469,15 @@
>   	pProfile->dwType = WLX_PROFILE_TYPE_V2_0;
>   	pProfile->pszProfile = ProfilePath;
>   
>  -	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 32 * sizeof(WCHAR));
>  +	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
>  +	                          (wcslen(pgContext->Domain)+ 14) * sizeof(WCHAR)); 
This needs to be 15 (or sizeof L"LOGONSERVER\\\\" / sizeof(WCHAR)). I
assume the resulting heap corruption is what causes the VMWare failures:

http://build.reactos.org:8010/builders/Linux_AMD64_2%20VMWPlayer-Test/build…

err:user32:IntCallWindowProcW Got exception when calling unicode WndProc 00402B6C Msg 1625

(1625=WLX_WM_SAS)

Not fixing it myself so as not to cause any conflicts for you.
Thanks.

-Thomas

>    	if (!lpEnvironment)
>   	{
>   		WARN("HeapAlloc() failed\n");
>   		goto cleanup;
>   	}
>  -	wcscpy(lpEnvironment, L"LOGONSERVER=\\\\Test");
>  +
>  +	wsprintfW(lpEnvironment, L"LOGONSERVER=\\\\%s", pgContext->Domain);
>   
>   	pProfile->pszEnvironment = lpEnvironment;
>

[Eric Kohl]

Hello Thomas,

I just stubled upon this bug myself and fixed it immediately. See 
r58329. Unfortunately, this does not seem to fix the exception.

Regards
Eric


Am 17.02.2013 13:12, schrieb Thomas Faber:
>   Hey Eric,
>
>  On 2013-02-17 02:06, ekohl(a)svn.reactos.org wrote:
> >   Modified:
> > trunk/reactos/dll/win32/msgina/msgina.c
> >  URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?…
> >  ==============================================================================
> >  --- trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] (original)
> >  +++ trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] Sun Feb 17 01:06:24 2013
> >  @@ -456,13 +469,15 @@
> >    	pProfile->dwType = WLX_PROFILE_TYPE_V2_0;
> >    	pProfile->pszProfile = ProfilePath;
> >
> >  -	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 32 * sizeof(WCHAR));
> >  +	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> >  +	                          (wcslen(pgContext->Domain)+ 14) * sizeof(WCHAR)); 
>  This needs to be 15 (or sizeof L"LOGONSERVER\\\\" / sizeof(WCHAR)). I
>  assume the resulting heap corruption is what causes the VMWare failures:
>
>
> http://build.reactos.org:8010/builders/Linux_AMD64_2%20VMWPlayer-Test/build…
>
>  err:user32:IntCallWindowProcW Got exception when calling unicode WndProc 00402B6C Msg
> 1625
>  (1625=WLX_WM_SAS)
>
>  Not fixing it myself so as not to cause any conflicts for you.
>  Thanks.
>
>  -Thomas
>
> >     	if (!lpEnvironment)
> >    	{
> >    		WARN("HeapAlloc() failed\n");
> >    		goto cleanup;
> >    	}
> >  -	wcscpy(lpEnvironment, L"LOGONSERVER=\\\\Test");
> >  +
> >  +	wsprintfW(lpEnvironment, L"LOGONSERVER=\\\\%s", pgContext->Domain);
> >
> >    	pProfile->pszEnvironment = lpEnvironment;
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Eric Kohl]

Hello Thomas,

r58329 fixes the VMPlayer-Test but the VBox-Test still fails. 
Unfortunately, the stdio log of the VBox-Test does not provied any 
useful information.

Regards
Eric

Am 17.02.2013 13:12, schrieb Thomas Faber:
>   Hey Eric,
>
>  On 2013-02-17 02:06, ekohl(a)svn.reactos.org wrote:
> >   Modified:
> > trunk/reactos/dll/win32/msgina/msgina.c
> >  URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?…
> >  ==============================================================================
> >  --- trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] (original)
> >  +++ trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] Sun Feb 17 01:06:24 2013
> >  @@ -456,13 +469,15 @@
> >    	pProfile->dwType = WLX_PROFILE_TYPE_V2_0;
> >    	pProfile->pszProfile = ProfilePath;
> >
> >  -	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 32 * sizeof(WCHAR));
> >  +	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> >  +	                          (wcslen(pgContext->Domain)+ 14) * sizeof(WCHAR)); 
>  This needs to be 15 (or sizeof L"LOGONSERVER\\\\" / sizeof(WCHAR)). I
>  assume the resulting heap corruption is what causes the VMWare failures:
>
>
> http://build.reactos.org:8010/builders/Linux_AMD64_2%20VMWPlayer-Test/build…
>
>  err:user32:IntCallWindowProcW Got exception when calling unicode WndProc 00402B6C Msg
> 1625
>  (1625=WLX_WM_SAS)
>
>  Not fixing it myself so as not to cause any conflicts for you.
>  Thanks.
>
>  -Thomas
>
> >     	if (!lpEnvironment)
> >    	{
> >    		WARN("HeapAlloc() failed\n");
> >    		goto cleanup;
> >    	}
> >  -	wcscpy(lpEnvironment, L"LOGONSERVER=\\\\Test");
> >  +
> >  +	wsprintfW(lpEnvironment, L"LOGONSERVER=\\\\%s", pgContext->Domain);
> >
> >    	pProfile->pszEnvironment = lpEnvironment;
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Thomas Faber]

Indeed, the VMWare builder still had a lot of backlog to run (I had it
redoing some of the failed test runs to check whether the failure was
persistent).
The VBox issue seems to be a problem with the builder/VM itself. Amine
and Olaf should hopefully have it fixed soon.

On 2013-02-17 14:33, Eric Kohl wrote:
>   Hello Thomas,
>  
>  r58329 fixes the VMPlayer-Test but the VBox-Test still fails. 
>  Unfortunately, the stdio log of the VBox-Test does not provied any 
>  useful information.
>  
>  Regards
>  Eric
>  
>  Am 17.02.2013 13:12, schrieb Thomas Faber:
> > Hey Eric,
> >
> > On 2013-02-17 02:06, ekohl(a)svn.reactos.org wrote:
> >> Modified: trunk/reactos/dll/win32/msgina/msgina.c
> >> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?…
> >> ==============================================================================
> >> --- trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] (original)
> >> +++ trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] Sun Feb 17 01:06:24
> 2013
> >> @@ -456,13 +469,15 @@
> >>   	pProfile->dwType = WLX_PROFILE_TYPE_V2_0;
> >>   	pProfile->pszProfile = ProfilePath;
> >>
> >> -	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 32 *
> sizeof(WCHAR));
> >> +	lpEnvironment = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> >> +	                          (wcslen(pgContext->Domain)+ 14) * sizeof(WCHAR));
> >
> > This needs to be 15 (or sizeof L"LOGONSERVER\\\\" / sizeof(WCHAR)). I
> > assume the resulting heap corruption is what causes the VMWare failures:
> >
> >
> http://build.reactos.org:8010/builders/Linux_AMD64_2%20VMWPlayer-Test/build…
> >
> > err:user32:IntCallWindowProcW Got exception when calling unicode WndProc 00402B6C Msg
> 1625
> > (1625=WLX_WM_SAS)
> >
> > Not fixing it myself so as not to cause any conflicts for you.
> > Thanks.
> >
> > -Thomas
> >
> >>   	if (!lpEnvironment)
> >>   	{
> >>   		WARN("HeapAlloc() failed\n");
> >>   		goto cleanup;
> >>   	}
> >> -	wcscpy(lpEnvironment, L"LOGONSERVER=\\\\Test");
> >> +
> >> +	wsprintfW(lpEnvironment, L"LOGONSERVER=\\\\%s",
> pgContext->Domain);
> >>
> >>   	pProfile->pszEnvironment = lpEnvironment;
> >>