rbuild broken?

[Hartmut Birr]

Hi,

all drivers do export its internal functions.

- Hartmut

 Exp Addr Hint   Ord Export Name by vfatfs.sys - Wed Nov 30 23:05:54 2005
 -------- ---- -----
---------------------------------------------------------
 000059FC    0     1 ClusterToSector
 000053DE    1     2 CountAvailableClusters
 00009DD0    2     3 DriverEntry@8
 0000514B    3     4 FAT12FindAndMarkAvailableCluster
 00004F59    4     5 FAT12GetNextCluster
 000056DF    5     6 FAT12WriteCluster
 00004FF9    6     7 FAT16FindAndMarkAvailableCluster
 00004E9A    7     8 FAT16GetNextCluster
 00004C5D    8     9 FAT16OffsetToCluster
 000057C8    9    10 FAT16WriteCluster
 0000527D    A    11 FAT32FindAndMarkAvailableCluster
 00004DD4    B    12 FAT32GetNextCluster
 00004AE0    C    13 FAT32OffsetToCluster
 000058A5    D    14 FAT32WriteCluster
 00003137    E    15 FATGetNextDirEntry
 000035B3    F    16 FATXGetNextDirEntry
 0000E000   10    17 FileInformationClassNames
 000019A7   11    18 FindFile
 000024B0   12    19 FsdDosDateTimeToSystemTime
 0000254D   13    20 FsdSystemTimeToDosDateTime
 00005A26   14    21 GetNextCluster
 00005A69   15    22 GetNextClusterExtend
 0000E0C0   16    23 MajorFunctionNames
 0000A620   17    24 NextCluster
 0000A65C   18    25 OffsetToCluster
 00001801   19    26 ReadVolumeLabel
 00005B9D   1A    27 VfatAcquireForLazyWrite@8
 00005C15   1B    28 VfatAcquireForReadAhead@8
 00003B7E   1C    29 VfatAddEntry
 0000A1C3   1D    30 VfatAllocateIrpContext
 0000138C   1E    31 VfatBlockDeviceIoControl
 0000A3D4   1F    32 VfatBuildRequest@8
 00001430   20    33 VfatCleanup
 000015F3   21    34 VfatClose
 00001550   22    35 VfatCloseFile
 00001D14   23    36 VfatCreate
 0000477B   24    37 VfatDelEntry
 00002630   25    38 VfatDirectoryControl
 00008EEF   26    39 VfatFileSystemControl
 0000831D   27    40 VfatFlush
 000081B9   28    41 VfatFlushVolume
 00009FF0   29    42 VfatFreeIrpContext
 0000A558   2A    43 VfatGetUserBuffer
 00011010   2B    44 VfatGlobalData
 00005C8D   2C    45 VfatInitFastIoRoutines
 00002FC2   2D    46 VfatIsDirectoryEmpty
 0000A5B1   2E    47 VfatLockUserBuffer
 00007897   2F    48 VfatQueryInformation
 0000C230   30    49 VfatQueryVolumeInformation
 0000A4D2   31    50 VfatQueueRequest
 0000AD85   32    51 VfatRead
 00001070   33    52 VfatReadDisk
 000010F4   34    53 VfatReadDiskPartial
 00005BE3   35    54 VfatReleaseFromLazyWrite@4
 00005C5B   36    55 VfatReleaseFromReadAhead@4
 00007474   37    56 VfatSetAllocationSizeInformation
 00004AD0   38    57 VfatSetExtendedAttributes
 00007D3D   39    58 VfatSetInformation
 0000C4C5   3A    59 VfatSetVolumeInformation
 0000BFC0   3B    60 VfatShutdown@8
 000037C0   3C    61 VfatUpdateEntry
 0000B301   3D    62 VfatWrite
 00001240   3E    63 VfatWriteDiskPartial
 00005974   3F    64 WriteCluster
 0000E140   40    65 long_illegals
 00001690   41    66 vfat8Dot3ToString
 00006316   42    67 vfatAddFCBToTable
 00006AA7   43    68 vfatAttachFCBToFileObject
 0000615B   44    69 vfatDestroyCCB
 000061A4   45    70 vfatDestroyFCB
 00002F90   46    71 vfatDirEntryGetFirstCluster
 00006B10   47    72 vfatDirFindFile
 00006204   48    73 vfatFCBIsDirectory
 00006215   49    74 vfatFCBIsRoot
 00003919   4A    75 vfatFindDirSpace
 00006CCA   4B    76 vfatGetFCBForFile
 000063B6   4C    77 vfatGrabFCBFromTable
 0000C210   4D    78 vfatIsLongIllegal
 000066F0   4E    79 vfatMakeFCBFromDirEntry
 0000653C   4F    80 vfatMakeRootFCB
 00005E8B   50    81 vfatNewFCB
 000066B8   51    82 vfatOpenRootFCB
 00006236   52    83 vfatReleaseFCB
 00005DC7   53    84 vfatSplitPathName

[Casper Hornstrup]

Is the command line wrong?

Casper

>   -----Original Message-----
>  From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
> Hartmut Birr
>  Sent: 30. november 2005 23:10
>  To: ReactOS Development List
>  Subject: [ros-dev] rbuild broken?
>  
>  Hi,
>  
>  all drivers do export its internal functions.
>  
>  - Hartmut
>  
>   Exp Addr Hint   Ord Export Name by vfatfs.sys - Wed Nov 30 23:05:54 2005
>   -------- ---- -----
>  ---------------------------------------------------------
>   000059FC    0     1 ClusterToSector
>   000053DE    1     2 CountAvailableClusters
>   00009DD0    2     3 DriverEntry@8
>   0000514B    3     4 FAT12FindAndMarkAvailableCluster
>   00004F59    4     5 FAT12GetNextCluster
>   000056DF    5     6 FAT12WriteCluster
>   00004FF9    6     7 FAT16FindAndMarkAvailableCluster
>   00004E9A    7     8 FAT16GetNextCluster
>   00004C5D    8     9 FAT16OffsetToCluster
>   000057C8    9    10 FAT16WriteCluster
>   0000527D    A    11 FAT32FindAndMarkAvailableCluster
>   00004DD4    B    12 FAT32GetNextCluster
>   00004AE0    C    13 FAT32OffsetToCluster
>   000058A5    D    14 FAT32WriteCluster
>   00003137    E    15 FATGetNextDirEntry
>   000035B3    F    16 FATXGetNextDirEntry
>   0000E000   10    17 FileInformationClassNames
>   000019A7   11    18 FindFile
>   000024B0   12    19 FsdDosDateTimeToSystemTime
>   0000254D   13    20 FsdSystemTimeToDosDateTime
>   00005A26   14    21 GetNextCluster
>   00005A69   15    22 GetNextClusterExtend
>   0000E0C0   16    23 MajorFunctionNames
>   0000A620   17    24 NextCluster
>   0000A65C   18    25 OffsetToCluster
>   00001801   19    26 ReadVolumeLabel
>   00005B9D   1A    27 VfatAcquireForLazyWrite@8
>   00005C15   1B    28 VfatAcquireForReadAhead@8
>   00003B7E   1C    29 VfatAddEntry
>   0000A1C3   1D    30 VfatAllocateIrpContext
>   0000138C   1E    31 VfatBlockDeviceIoControl
>   0000A3D4   1F    32 VfatBuildRequest@8
>   00001430   20    33 VfatCleanup
>   000015F3   21    34 VfatClose
>   00001550   22    35 VfatCloseFile
>   00001D14   23    36 VfatCreate
>   0000477B   24    37 VfatDelEntry
>   00002630   25    38 VfatDirectoryControl
>   00008EEF   26    39 VfatFileSystemControl
>   0000831D   27    40 VfatFlush
>   000081B9   28    41 VfatFlushVolume
>   00009FF0   29    42 VfatFreeIrpContext
>   0000A558   2A    43 VfatGetUserBuffer
>   00011010   2B    44 VfatGlobalData
>   00005C8D   2C    45 VfatInitFastIoRoutines
>   00002FC2   2D    46 VfatIsDirectoryEmpty
>   0000A5B1   2E    47 VfatLockUserBuffer
>   00007897   2F    48 VfatQueryInformation
>   0000C230   30    49 VfatQueryVolumeInformation
>   0000A4D2   31    50 VfatQueueRequest
>   0000AD85   32    51 VfatRead
>   00001070   33    52 VfatReadDisk
>   000010F4   34    53 VfatReadDiskPartial
>   00005BE3   35    54 VfatReleaseFromLazyWrite@4
>   00005C5B   36    55 VfatReleaseFromReadAhead@4
>   00007474   37    56 VfatSetAllocationSizeInformation
>   00004AD0   38    57 VfatSetExtendedAttributes
>   00007D3D   39    58 VfatSetInformation
>   0000C4C5   3A    59 VfatSetVolumeInformation
>   0000BFC0   3B    60 VfatShutdown@8
>   000037C0   3C    61 VfatUpdateEntry
>   0000B301   3D    62 VfatWrite
>   00001240   3E    63 VfatWriteDiskPartial
>   00005974   3F    64 WriteCluster
>   0000E140   40    65 long_illegals
>   00001690   41    66 vfat8Dot3ToString
>   00006316   42    67 vfatAddFCBToTable
>   00006AA7   43    68 vfatAttachFCBToFileObject
>   0000615B   44    69 vfatDestroyCCB
>   000061A4   45    70 vfatDestroyFCB
>   00002F90   46    71 vfatDirEntryGetFirstCluster
>   00006B10   47    72 vfatDirFindFile
>   00006204   48    73 vfatFCBIsDirectory
>   00006215   49    74 vfatFCBIsRoot
>   00003919   4A    75 vfatFindDirSpace
>   00006CCA   4B    76 vfatGetFCBForFile
>   000063B6   4C    77 vfatGrabFCBFromTable
>   0000C210   4D    78 vfatIsLongIllegal
>   000066F0   4E    79 vfatMakeFCBFromDirEntry
>   0000653C   4F    80 vfatMakeRootFCB
>   00005E8B   50    81 vfatNewFCB
>   000066B8   51    82 vfatOpenRootFCB
>   00006236   52    83 vfatReleaseFCB
>   00005DC7   53    84 vfatSplitPathName
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Hartmut Birr]

Casper Hornstrup wrote:
>   Is the command line wrong?
>
>  Casper
>
>     
I don't see this problem on an old cache manager branch. On the trunk,
it is running dlltool and ld. On the cache manager branch, it is running
ld, dlltool and ld.

trunk:
dlltool --dllname atapi.sys --def tools\rbuild\empty.def --output-exp
atapi.temp.exp --kill-at
gcc -Wl,--subsystem,native -Wl,--entry,_DriverEntry@8
-Wl,--image-base,0x00010000 -Wl,--file-alignment,0x1000
-Wl,--section-alignment,0x1000 -nostartfiles -shared  atapi.temp.exp -o
.\up\output-i386\drivers\storage\atapi\atapi.sys
.\up\obj-i386\drivers\storage\atapi\atapi.o
.\up\obj-i386\drivers\storage\atapi\atapi.coff
.\up\obj-i386\ntoskrnl\libntoskrnl.a .\up\obj-i386\hal\hal\libhal.a
.\up\obj-i386\drivers\storage\scsiport\libscsiport.a  -g -nostartfiles
-nostdlib

old cache manager branch:
gcc -Wl,--subsystem,native -Wl,--entry,_DriverEntry@8
-Wl,--image-base,0x00010000 -Wl,--file-alignment,0x1000
-Wl,--section-alignment,0x1000 -nostartfiles -mdll --dll
-Wl,--base-file,atapi.base.tmp -o atapi.junk.tmp
obj-i386\drivers\storage\atapi\atapi.o
obj-i386\drivers\storage\atapi\atapi.coff
obj-i386\ntoskrnl\libntoskrnl.a obj-i386\hal\hal\libhal.a
obj-i386\drivers\storage\scsiport\libscsiport.a  -g -nostartfiles -nostdlib
dlltool --dllname atapi.sys --base-file atapi.base.tmp --def
tools\rbuild\empty.def --output-exp atapi.temp.exp --kill-at
gcc -Wl,--subsystem,native -Wl,--entry,_DriverEntry@8
-Wl,--image-base,0x00010000 -Wl,--file-alignment,0x1000
-Wl,--section-alignment,0x1000 -nostartfiles -mdll --dll atapi.temp.exp
-o output-i386\drivers\storage\atapi\atapi.sys
obj-i386\drivers\storage\atapi\atapi.o
obj-i386\drivers\storage\atapi\atapi.coff
obj-i386\ntoskrnl\libntoskrnl.a obj-i386\hal\hal\libhal.a
obj-i386\drivers\storage\scsiport\libscsiport.a  -g -nostartfiles -nostdlib

It seems, that the old cache manager branch does use an additional
base-file. I don't know, what a base-file is. There is a difference on
the last ld command. The trunk uses '-shared' and the branch '-mdll
--dll'.

- Hartmut

[Filip Navara]

Hartmut Birr wrote:

>  Casper Hornstrup wrote:
>   
>
> >  Is the command line wrong?
> >
> > Casper
> >
> >   
> >     
> >  
> I don't see this problem on an old cache manager branch. On the trunk,
> it is running dlltool and ld. On the cache manager branch, it is running
> ld, dlltool and ld.
>
> trunk:
> dlltool --dllname atapi.sys --def tools\rbuild\empty.def --output-exp
> atapi.temp.exp --kill-at
> gcc -Wl,--subsystem,native -Wl,--entry,_DriverEntry@8
> -Wl,--image-base,0x00010000 -Wl,--file-alignment,0x1000
> -Wl,--section-alignment,0x1000 -nostartfiles -shared  atapi.temp.exp -o
> .\up\output-i386\drivers\storage\atapi\atapi.sys
> .\up\obj-i386\drivers\storage\atapi\atapi.o
> .\up\obj-i386\drivers\storage\atapi\atapi.coff
> .\up\obj-i386\ntoskrnl\libntoskrnl.a .\up\obj-i386\hal\hal\libhal.a
> .\up\obj-i386\drivers\storage\scsiport\libscsiport.a  -g -nostartfiles
> -nostdlib
>   
>  
What version of binutils are you using? (for reference)

I guess this is result of one of my old attempt to simplify the three 
step linking ... Ideally DLLTOOL shouldn't be used at all and then 
everything works fine, but that depends on patch to LD that isn't part 
of the official bintutils yet (I've been waiting few months for getting 
the copyright assignment papers sorted out :/). I'll probably look at it 
on the weekend.

- Filip

[Hartmut Birr]

Filip Navara wrote:
>   What version of binutils are you using? (for
> reference)
>
>  I guess this is result of one of my old attempt to simplify the three
>  step linking ... Ideally DLLTOOL shouldn't be used at all and then
>  everything works fine, but that depends on patch to LD that isn't part
>  of the official bintutils yet (I've been waiting few months for
>  getting the copyright assignment papers sorted out :/). I'll probably
>  look at it on the weekend.
>  
M:\Sandbox\ros_work\reactos>ld --version
GNU ld version 2.16.91 20050827
Copyright 2005 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License.  This program has absolutely no warranty.

- Hartmut