This should work! It's just writing zero into a place holder in TEB but it throws a exception and kills boot!
Index: win32k/ntuser/misc.c =================================================================== --- win32k/ntuser/misc.c (revision 40892) +++ win32k/ntuser/misc.c (working copy) @@ -550,6 +550,7 @@ // ci->pClientThreadInfo = &ti->ClientThreadInfo; // FIXME! ci->pClientThreadInfo = NULL; ci->ppi = ti->ppi; + ci->pDeskInfo = NULL; } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) {
Looks like the CSRSS bug in Windows -- by setting this to NULL, something is probably trying to dereference it and crashes.
What is the original value? Probably some bogus uninitialized variable that happens to be valid memory...
Best regards, Alex Ionescu
On Tue, May 12, 2009 at 7:03 AM, James Tabor jimtabor.rosdev@gmail.comwrote:
This should work! It's just writing zero into a place holder in TEB but it throws a exception and kills boot!
Index: win32k/ntuser/misc.c
--- win32k/ntuser/misc.c (revision 40892) +++ win32k/ntuser/misc.c (working copy) @@ -550,6 +550,7 @@ // ci->pClientThreadInfo = &ti->ClientThreadInfo; // FIXME! ci->pClientThreadInfo = NULL; ci->ppi = ti->ppi;
ci->pDeskInfo = NULL; } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) {
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Hi, You can write anything to it. ATM it is not used. Thanks, James
On Tue, May 12, 2009 at 3:36 AM, Alex Ionescu ionucu@videotron.ca wrote:
Looks like the CSRSS bug in Windows -- by setting this to NULL, something is probably trying to dereference it and crashes. What is the original value? Probably some bogus uninitialized variable that happens to be valid memory... Best regards, Alex Ionescu
Hi,
as many ppl already found out, we have some problems with RosBE 1.4.2 for Windows on some machines. Most problems are a result of the idea to keep the Original Path Variable + extending it. Before that we fully replaced it. Well If there are () in the Paths, we have a problem. Batch thinks the ) is for it to interpret and closes the right now open block. This is really bad as you might imagine. Well. Colin ran through the scripts these days and heavily cleaned up the mess we had resulting from being modified by several ppl over the last years. He reduced the code lines of some scripts by ~60%. But before I release anything, I want it to be tested FULLY and by MORE than one person (me). I got some not that nice and partially insulting EMails because RosBE failed for the ppl. The consequence is that 1.4.2 will be the latest Version until ~10 ppl tested the FULL functionality of the Scripts and report bugs and requests. Here or in the Forums, I don't care.
I post all news in the Forums and paste the Reports written in here to there too. http://www.reactos.org/forum/viewtopic.php?f=2&t=6898
Thx for reading.
Don't feel so guilty, RosBE is the highest quality product out of all things we do in ReactOS now. And releases are actually for wider testing, so if you've got complaints, it's a nice reason to release 1.4.3 soon!
WBR, Aleksey Bragin.
On May 12, 2009, at 2:11 PM, Daniel Reimer wrote:
Hi,
as many ppl already found out, we have some problems with RosBE 1.4.2 for Windows on some machines. Most problems are a result of the idea to keep the Original Path Variable + extending it. Before that we fully replaced it. Well If there are () in the Paths, we have a problem. Batch thinks the ) is for it to interpret and closes the right now open block. This is really bad as you might imagine. Well. Colin ran through the scripts these days and heavily cleaned up the mess we had resulting from being modified by several ppl over the last years. He reduced the code lines of some scripts by ~60%. But before I release anything, I want it to be tested FULLY and by MORE than one person (me). I got some not that nice and partially insulting EMails because RosBE failed for the ppl. The consequence is that 1.4.2 will be the latest Version until ~10 ppl tested the FULL functionality of the Scripts and report bugs and requests. Here or in the Forums, I don't care.
I post all news in the Forums and paste the Reports written in here to there too. http://www.reactos.org/forum/viewtopic.php?f=2&t=6898
Thx for reading.
Without your suite it would be too much difficult for all of us to build ReactOS. So, thanks for all. Bugs are normal in software development, so, as Aleksey has just said, dont feel guilty :)
On Tue, May 12, 2009 at 3:21 PM, Aleksey Bragin aleksey@reactos.org wrote:
Don't feel so guilty, RosBE is the highest quality product out of all things we do in ReactOS now. And releases are actually for wider testing, so if you've got complaints, it's a nice reason to release 1.4.3 soon!
WBR, Aleksey Bragin.
On May 12, 2009, at 2:11 PM, Daniel Reimer wrote:
Hi,
as many ppl already found out, we have some problems with RosBE 1.4.2 for Windows on some machines. Most problems are a result of the idea to keep the Original Path Variable + extending it. Before that we fully replaced it. Well If there are () in the Paths, we have a problem. Batch thinks the ) is for it to interpret and closes the right now open block. This is really bad as you might imagine. Well. Colin ran through the scripts these days and heavily cleaned up the mess we had resulting from being modified by several ppl over the last years. He reduced the code lines of some scripts by ~60%. But before I release anything, I want it to be tested FULLY and by MORE than one person (me). I got some not that nice and partially insulting EMails because RosBE failed for the ppl. The consequence is that 1.4.2 will be the latest Version until ~10 ppl tested the FULL functionality of the Scripts and report bugs and requests. Here or in the Forums, I don't care.
I post all news in the Forums and paste the Reports written in here to there too. http://www.reactos.org/forum/viewtopic.php?f=2&t=6898
Thx for reading.
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Javier Agustìn Fernàndez Arroyo wrote:
Without your suite it would be too much difficult for all of us to build ReactOS. So, thanks for all. Bugs are normal in software development, so, as Aleksey has just said, dont feel guilty :)
On Tue, May 12, 2009 at 3:21 PM, Aleksey Bragin <aleksey@reactos.org mailto:aleksey@reactos.org> wrote:
Don't feel so guilty, RosBE is the highest quality product out of all things we do in ReactOS now. And releases are actually for wider testing, so if you've got complaints, it's a nice reason to release 1.4.3 soon! WBR, Aleksey Bragin. On May 12, 2009, at 2:11 PM, Daniel Reimer wrote: > Hi, > > as many ppl already found out, we have some problems with RosBE 1.4.2 > for Windows on some machines. Most problems are a result of the > idea to > keep the Original Path Variable + extending it. Before that we fully > replaced it. Well If there are () in the Paths, we have a problem. > Batch > thinks the ) is for it to interpret and closes the right now open > block. > This is really bad as you might imagine. Well. Colin ran through the > scripts these days and heavily cleaned up the mess we had resulting > from > being modified by several ppl over the last years. He reduced the code > lines of some scripts by ~60%. But before I release anything, I > want it > to be tested FULLY and by MORE than one person (me). I got some not > that > nice and partially insulting EMails because RosBE failed for the ppl. > The consequence is that 1.4.2 will be the latest Version until ~10 ppl > tested the FULL functionality of the Scripts and report bugs and > requests. Here or in the Forums, I don't care. > > I post all news in the Forums and paste the Reports written in here to > there too. http://www.reactos.org/forum/viewtopic.php?f=2&t=6898 <http://www.reactos.org/forum/viewtopic.php?f=2&t=6898> > > Thx for reading. _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org <mailto:Ros-dev@reactos.org> http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Thx for your and Aleksey's words. But keep in mind its not just my work. Credits go to Colin Finck, Peter Ward, Pierre Schweitzer and all Testers and Users out there. Btw my dear Users ;-) Wanna become Testers maybe? http://www.reactos.org/forum/viewtopic.php?f=2&t=6898 http://www.reactos.org/forum/viewtopic.php?f=2&t=6898
Thx for reading and hopefully testing :-D Don't forget to write about your positive and negative experiences you have with the updated Scripts.
-
Aleksey Bragin -
Alex Ionescu -
Daniel Reimer -
James Tabor -
Javier Agustìn Fernàndez Arroyo