Re: [ros-svn] [gvg] 13652: Import Wine Resource Compiler and use it for winedll's

[Eric Kohl]

[e-mail] wrote:
> Import Wine Resource Compiler and use it for winedll's

Gé,

wouldn't it be better to import the wpp and unicode libraries into 
separate directories within the tools directory? This way wmc could also 
use the unicode library and support all known codepages.

I also have a modified widl in my source tree which can build simple 
client and server stub files. Widl requires wpp, so sharing wpp and 
unicode would be useful.

Could you also create a vendor drop of widl in tools/widl?

Regards,
Eric

[Ge van Geldorp]

> From: Eric Kohl
>
> wouldn't it be better to import the wpp and unicode libraries into 
> separate directories within the tools directory? This way wmc 
> could also use the unicode library and support all known codepages.

Yeah, makes sense. Done. I haven't (and don't plan to...) fix wmc to use the
lib though.
> I also have a modified widl in my source tree which can build simple 
> client and server stub files. Widl requires wpp, so sharing wpp and 
> unicode would be useful.
>
> Could you also create a vendor drop of widl in tools/widl?

Done. It's just a "raw" drop, haven't added it to the default build (or even
tried to build it for that matter).
The procedure for importing stuff from Wine is documented at
http://reactos.com/wiki/index.php/Using_code_from_other_projects BTW. (Not
that I don't want to import it, but you won't have to wait for me if you do
it yourself)

Gé van Geldorp.

[Eric Kohl]

Ge van Geldorp wrote:
> > wouldn't it be better to import the wpp and unicode libraries into 
> > separate directories within the tools directory? This way wmc 
> > could also use the unicode library and support all known codepages.
>
> Yeah, makes sense. Done. I haven't (and don't plan to...) fix wmc to use the
> lib though.

I can fix wmc to use the unicode lib because I imported wmc years ago 
and made it work without the unicode lib.
> Done. It's just a "raw" drop, haven't added it to the default build (or even
> tried to build it for that matter).
> The procedure for importing stuff from Wine is documented at
> http://reactos.com/wiki/index.php/Using_code_from_other_projects BTW. (Not
> that I don't want to import it, but you won't have to wait for me if you do
> it yourself)

Great! I could have done this myself but I have been busy with some 
family chores this afternoon. I'll get widl working as soon as possible.

Regards,
Eric