Re: [ros-dev] [ros-diffs] [tkreuzer] 52496: [FAT32] Add some code that does ... nothing, but fixes 2nd stage boot with msvc. To figure out why this is needed, is left as an excercise to the reader :)

[Alex Ionescu]

I know why this is "needed", but this is a temporary hack, right?

Best regards,
Alex Ionescu



On Thu, Jun 30, 2011 at 9:06 PM,  <tkreuzer(a)svn.reactos.org> wrote:
>   Author: tkreuzer
>  Date: Fri Jul  1 01:06:19 2011
>  New Revision: 52496
>
>  URL: http://svn.reactos.org/svn/reactos?rev=52496&view=rev
>  Log:
>  [FAT32]
>  Add some code that does ... nothing, but fixes 2nd stage boot with msvc. To figure out
> why this is needed, is left as an excercise to the reader :)
>
>  Modified:
>     trunk/reactos/boot/freeldr/bootsect/fat32.S
>
>  Modified: trunk/reactos/boot/freeldr/bootsect/fat32.S
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/bootsect/fat3…
>  ==============================================================================
>  --- trunk/reactos/boot/freeldr/bootsect/fat32.S [iso-8859-1] (original)
>  +++ trunk/reactos/boot/freeldr/bootsect/fat32.S [iso-8859-1] Fri Jul  1 01:06:19 2011
>  @@ -194,6 +194,13 @@
>      mov  dl, byte ptr BP_REL(BootDrive)                // Drive number
>      mov  ah, HEX(42)                                // Int 13h, AH = 42h - Extended Read
>      int  HEX(13)                                // Call BIOS
>  +
>  +    /* This code "fixes" loading the MSVC built kernel */
>  +    pushad
>  +    mov  si, offset msgNull
>  +    call PutChars
>  +    popad
>  +
>      jc   PrintDiskError                        // If the read failed then abort
>
>      add  sp, 16                            // Remove disk address packet from stack
>  @@ -302,6 +309,8 @@
>      .ascii "File system error", CR, LF, NUL
>   msgAnyKey:
>      .ascii "Press any key to restart", CR, LF, NUL
>  +msgNull:
>  +    .ascii NUL
>
>   .org 509 // Pad to 509 bytes
>
>  @@ -527,7 +536,7 @@
>   filename:
>      .ascii "FREELDR SYS"
>   msgLoading:
>  -    .ascii "Loading FreeLoader...\r\n", CR, LF, NUL
>  +    .ascii "Loading FreeLoader...", CR, LF, NUL
>
>   .org 1022   // Pad to 1022 bytes
>
>
>
>

[Timo Kreuzer]

Am 01.07.2011 14:19, schrieb Alex Ionescu:
>   I know why this is "needed", but this is a
> temporary hack, right?
>  
yeah, until i figured out whats really going wrong