Re: [ros-dev] [ros-diffs] [hbelusca] 60250: [KERNEL32]: Reenable two dprints to be able to know how programs are launched with which parameters and so on...

[Alex Ionescu]

Please don't do this. There's no reason this has to be on for all
applications, and it wasn't before. Use DbgPrintEx for this and setup your
filter in the debugger/KDBG appropriately.

Best regards,
Alex Ionescu


On Fri, Sep 20, 2013 at 6:12 PM, <hbelusca(a)svn.reactos.org> wrote:

>   Author: hbelusca
>  Date: Fri Sep 20 22:12:08 2013
>  New Revision: 60250
>
>  URL: http://svn.reactos.org/svn/reactos?rev=60250&view=rev
>  Log:
>  [KERNEL32]: Reenable two dprints to be able to know how programs are
>  launched with which parameters and so on...
>
>  Modified:
>      trunk/reactos/dll/win32/kernel32/client/proc.c
>
>  Modified: trunk/reactos/dll/win32/kernel32/client/proc.c
>  URL:
>
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
>
>  ==============================================================================
>  --- trunk/reactos/dll/win32/kernel32/client/proc.c      [iso-8859-1]
>  (original)
>  +++ trunk/reactos/dll/win32/kernel32/client/proc.c      [iso-8859-1] Fri
>  Sep 20 22:12:08 2013
>  @@ -629,10 +629,10 @@
>
>       /* Create the Parameter Block */
>       ProcessParameters = NULL;
>  -    DPRINT("ImageName: '%wZ'\n", &ImageName);
>  +    DPRINT1("ImageName: '%wZ'\n", &ImageName);
>       DPRINT("DllPath  : '%wZ'\n", &DllPath);
>       DPRINT("CurDir   : '%wZ'\n", &CurrentDirectory);
>  -    DPRINT("CmdLine  : '%wZ'\n", &CommandLine);
>  +    DPRINT1("CmdLine  : '%wZ'\n", &CommandLine);
>       DPRINT("Title    : '%wZ'\n", &Title);
>       DPRINT("Desktop  : '%wZ'\n", &Desktop);
>       DPRINT("Shell    : '%wZ'\n", &Shell);
>
>
>

[Hermès BÉLUSCA - MAÏTO]

Well, it’s to check something on the test bots (both the linux and the
windows ones)… (the two dprints will be disabled again after).

 

De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la
part de Alex Ionescu
Envoyé : samedi 21 septembre 2013 01:00
À : ReactOS Development List
Cc : Linda Wang
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 60250: [KERNEL32]: Reenable two
dprints to be able to know how programs are launched with which parameters
and so on...

 

Please don't do this. There's no reason this has to be on for all
applications, and it wasn't before. Use DbgPrintEx for this and setup your
filter in the debugger/KDBG appropriately.




Best regards,
Alex Ionescu

 

On Fri, Sep 20, 2013 at 6:12 PM, <hbelusca(a)svn.reactos.org> wrote:

Author: hbelusca
Date: Fri Sep 20 22:12:08 2013
New Revision: 60250

URL: http://svn.reactos.org/svn/reactos?rev=60250
<http://svn.reactos.org/svn/reactos?rev=60250&view=rev> &view=rev
Log:
[KERNEL32]: Reenable two dprints to be able to know how programs are
launched with which parameters and so on...

Modified:
    trunk/reactos/dll/win32/kernel32/client/proc.c

Modified: trunk/reactos/dll/win32/kernel32/client/proc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/p
roc.c?rev=60250
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/
proc.c?rev=60250&r1=60249&r2=60250&view=diff>
&r1=60249&r2=60250&view=diff
============================================================================
==
--- trunk/reactos/dll/win32/kernel32/client/proc.c      [iso-8859-1]
(original)
+++ trunk/reactos/dll/win32/kernel32/client/proc.c      [iso-8859-1] Fri Sep
20 22:12:08 2013
@@ -629,10 +629,10 @@

     /* Create the Parameter Block */
     ProcessParameters = NULL;
-    DPRINT("ImageName: '%wZ'\n", &ImageName);
+    DPRINT1("ImageName: '%wZ'\n", &ImageName);
     DPRINT("DllPath  : '%wZ'\n", &DllPath);
     DPRINT("CurDir   : '%wZ'\n", &CurrentDirectory);
-    DPRINT("CmdLine  : '%wZ'\n", &CommandLine);
+    DPRINT1("CmdLine  : '%wZ'\n", &CommandLine);
     DPRINT("Title    : '%wZ'\n", &Title);
     DPRINT("Desktop  : '%wZ'\n", &Desktop);
     DPRINT("Shell    : '%wZ'\n", &Shell);