Patch to get ROS Building under Linux

[Quandary]

I kept getting build errors related to wcsdup being
multiply defined, so I went in and removed what
appeared to be the offending code.

A make clean + make resulted in a complete build for
me; I run Linux, so if a Windows user could run a
build to verify that this didn't break anything on
-that- platform, that would be great.

(my build errors can be found at
http://www.nomorepasting.com/paste.php?pasteID=27171 )

Thanks,

-- Travis

Index: include/msvcrt/string.h
===================================================================
RCS file:
/CVS/ReactOS/reactos/include/msvcrt/string.h,v
retrieving revision 1.6
diff -u -r1.6 string.h
--- include/msvcrt/string.h     25 Aug 2003 01:37:47
-0000      1.6
+++ include/msvcrt/string.h     19 Dec 2004 15:56:57
-0000
@@ -166,7 +166,6 @@

/* NOTE: There is no _wcscmpi, but this is for
compatibility. */
 int wcscmpi(const wchar_t* ws1, const wchar_t* ws2);
-wchar_t* wcsdup(const wchar_t* wsToDuplicate);
 int wcsicmp(const wchar_t* ws1, const wchar_t* ws2);
 int wcsicoll(const wchar_t* ws1, const wchar_t* ws2);
 wchar_t* wcslwr(wchar_t* wsToConvert);

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

[David Kredba]

I am building ROS on linux every day.

I don`t see any problem.

I am using gcc-3.4.1.

What gcc/binutils versions are You using ?

David

[Steven Edwards]

--- David Kredba [e-mail] wrote:
> I am using gcc-3.4.1.

I see this issue with 3.4.2.

__________________________________ 
Do you Yahoo!? 
All your favorites on one personal page � Try My Yahoo!
http://my.yahoo.com

[Hartmut Birr]

Steven Edwards schrieb:
> --- David Kredba [e-mail] wrote:
> > I am using gcc-3.4.1.
>
> I see this issue with 3.4.2.

Hi,

I thing that is a problem of mingw-runtime-3.5. The definition of wcsdup 
in string.h is:

_CRTIMP wchar_t* __cdecl wcsdup (wchar_t*);

But it must be:

_CRTIMP wchar_t* __cdecl wcsdup (const wchar_t*);

- Hartmut

[David Kredba]

You are right :

In file included from ../../include/tchar.h:41,
                  from getopt.c:10,
                  from _wgetopt.c:13:
../../include/msvcrt/string.h:169: error: conflicting types for 'wcsdup'
/home/dave2/local/xmingw32-3.4.2/lib/gcc/mingw32/3.4.2/../../../../mingw32/include/wchar.h:241: 
error: previous declaration of 'wcsdup' was here
../../include/msvcrt/string.h:169: error: conflicting types for 'wcsdup'
/home/dave2/local/xmingw32-3.4.2/lib/gcc/mingw32/3.4.2/../../../../mingw32/include/wchar.h:241: 
error: previous declaration of 'wcsdup' was here
make[1]: *** [_wgetopt.o] Error 1
make: *** [tgetopt] Error 2

David