Msi.dll

[James Tabor]

Hi,
Is it okay to commit a broken port of wine Msi.dll source to our cvs? 8^P
I'm working on avdpack.dll with msiexec.exe.

I have bison working with building the port, that was not the problem.

It's this;

i386-mingw32-gcc -Wl,--base-file,base.tmp \
         -Wl,--entry,_DllMain@12 \
           -mdll -Wl,--image-base,0x777c0000 \
         -o junk.tmp \
         version.coff action.o create.o distinct.o handle.o insert.o msi.o msiquery.o order.o 
package.o record.o regsvr.o select.o string.o suminfo.o table.o tokenize.o update.o where.o 
sql.tab.o cond.tab.o ../../dk/w32/lib/shell32.a ../../dk/w32/lib/cabinet.a 
../../dk/w32/lib/oleaut32.a ../../dk/w32/lib/ole32.a ../../dk/w32/lib/version.a 
../../dk/w32/lib/user32.a ../../dk/w32/lib/advapi32.a ../../dk/w32/lib/kernel32.a 
../../dk/w32/lib/libwine.a ../../dk/w32/lib/wine_uuid.a ../../dk/w32/lib/ntdll.a
Warning: resolving _MsiGetFileVersionW by linking to _MsiGetFileVersionW@20
Use --enable-stdcall-fixup to disable these warnings
Use --disable-stdcall-fixup to disable these fixups

action.o(.text+0x879e):action.c: undefined reference to `LoadTypeLib@8'
action.o(.text+0x8830):action.c: undefined reference to `RegisterTypeLib@12'
action.o(.text+0x88c6):action.c: undefined reference to `ITypeLib_Release'

suminfo.o(.text+0x3e):suminfo.c: undefined reference to `IPropertyStorage_Release'
suminfo.o(.text+0x324):suminfo.c: undefined reference to `IPropertySetStorage_Open'
suminfo.o(.text+0x396):suminfo.c: undefined reference to `IPropertyStorage_AddRef'
suminfo.o(.text+0x3e9):suminfo.c: undefined reference to `IPropertyStorage_Release'
suminfo.o(.text+0x3fd):suminfo.c: undefined reference to `IPropertySetStorage_Release'
suminfo.o(.text+0x569):suminfo.c: undefined reference to `IPropertyStorage_ReadMultiple'

make: *** [msi.nostrip.dll] Error 1

Thanks,
James

[Casper Hornstrup]

I think it is better that you send small patches to WINE to eventually
get it to compile for ReactOS and WINE. Msi.dll is such a highlevel
component that I see no reason we couldn't share all of it with WINE.

Casper
> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of James Tabor
> Sent: 28. oktober 2004 03:52
> To: ReactOS Development List
> Subject: [ros-dev] Msi.dll
>
> Hi,
> Is it okay to commit a broken port of wine Msi.dll source to 
> our cvs? 8^P I'm working on avdpack.dll with msiexec.exe.
>
> I have bison working with building the port, that was not the problem.
>
> It's this;
>
> i386-mingw32-gcc -Wl,--base-file,base.tmp \
>          -Wl,--entry,_DllMain@12 \
>            -mdll -Wl,--image-base,0x777c0000 \
>          -o junk.tmp \
>          version.coff action.o create.o distinct.o handle.o 
> insert.o msi.o msiquery.o order.o package.o record.o regsvr.o 
> select.o string.o suminfo.o table.o tokenize.o update.o 
> where.o sql.tab.o cond.tab.o ../../dk/w32/lib/shell32.a 
> ../../dk/w32/lib/cabinet.a ../../dk/w32/lib/oleaut32.a 
> ../../dk/w32/lib/ole32.a ../../dk/w32/lib/version.a 
> ../../dk/w32/lib/user32.a ../../dk/w32/lib/advapi32.a 
> ../../dk/w32/lib/kernel32.a ../../dk/w32/lib/libwine.a 
> ../../dk/w32/lib/wine_uuid.a ../../dk/w32/lib/ntdll.a
> Warning: resolving _MsiGetFileVersionW by linking to 
> _MsiGetFileVersionW@20 Use --enable-stdcall-fixup to disable 
> these warnings Use --disable-stdcall-fixup to disable these fixups
>
> action.o(.text+0x879e):action.c: undefined reference to 
> `LoadTypeLib@8'
> action.o(.text+0x8830):action.c: undefined reference to 
> `RegisterTypeLib@12'
> action.o(.text+0x88c6):action.c: undefined reference to 
> `ITypeLib_Release'
>
> suminfo.o(.text+0x3e):suminfo.c: undefined reference to 
> `IPropertyStorage_Release'
> suminfo.o(.text+0x324):suminfo.c: undefined reference to 
> `IPropertySetStorage_Open'
> suminfo.o(.text+0x396):suminfo.c: undefined reference to 
> `IPropertyStorage_AddRef'
> suminfo.o(.text+0x3e9):suminfo.c: undefined reference to 
> `IPropertyStorage_Release'
> suminfo.o(.text+0x3fd):suminfo.c: undefined reference to 
> `IPropertySetStorage_Release'
> suminfo.o(.text+0x569):suminfo.c: undefined reference to 
> `IPropertyStorage_ReadMultiple'
>
> make: *** [msi.nostrip.dll] Error 1
>
> Thanks,
> James
> _______________________________________________
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[Filip Navara]

James Tabor wrote:
> action.o(.text+0x879e):action.c: undefined reference to `LoadTypeLib@8'
> action.o(.text+0x8830):action.c: undefined reference to 
> `RegisterTypeLib@12'

Missing prototypes in headers.
> action.o(.text+0x88c6):action.c: undefined reference to 
> `ITypeLib_Release'
> suminfo.o(.text+0x3e):suminfo.c: undefined reference to 
> `IPropertyStorage_Release'
> suminfo.o(.text+0x324):suminfo.c: undefined reference to 
> `IPropertySetStorage_Open'
> suminfo.o(.text+0x396):suminfo.c: undefined reference to 
> `IPropertyStorage_AddRef'
> suminfo.o(.text+0x3e9):suminfo.c: undefined reference to 
> `IPropertyStorage_Release'
> suminfo.o(.text+0x3fd):suminfo.c: undefined reference to 
> `IPropertySetStorage_Release'
> suminfo.o(.text+0x569):suminfo.c: undefined reference to 
> `IPropertyStorage_ReadMultiple'

Missing macros in headers (search for COBJMACROS in W32API to see how to 
implement).

Regards,
Filip

[Filip Navara]

Filip Navara wrote:
> James Tabor wrote:
> > action.o(.text+0x879e):action.c: undefined reference to `LoadTypeLib@8'
> > action.o(.text+0x8830):action.c: undefined reference to 
> > `RegisterTypeLib@12'
>
> Missing prototypes in headers.

Oops, sorry. This is actually because our oleaut32 is broken. Some of 
the parts aren't compiled in and so these functions aren't present in 
the DLL and import lib. In order to compile these parts we need to all 
lots of macros and interfaces to the W32API headers...

Regards,
Filip

[James Tabor]

Hi!
I managed to get it to compile.

Filip Navara wrote:
> James Tabor wrote:
> > action.o(.text+0x879e):action.c: undefined reference to `LoadTypeLib@8'
> > action.o(.text+0x8830):action.c: undefined reference to 
> > `RegisterTypeLib@12'
>
> Missing prototypes in headers.
> > action.o(.text+0x88c6):action.c: undefined reference to 
> > `ITypeLib_Release'

I commented them out.
> > suminfo.o(.text+0x3e):suminfo.c: undefined reference to 
> > `IPropertyStorage_Release'
> > suminfo.o(.text+0x324):suminfo.c: undefined reference to 
> > `IPropertySetStorage_Open'
> > suminfo.o(.text+0x396):suminfo.c: undefined reference to 
> > `IPropertyStorage_AddRef'
> > suminfo.o(.text+0x3e9):suminfo.c: undefined reference to 
> > `IPropertyStorage_Release'
> > suminfo.o(.text+0x3fd):suminfo.c: undefined reference to 
> > `IPropertySetStorage_Release'
> > suminfo.o(.text+0x569):suminfo.c: undefined reference to 
> > `IPropertyStorage_ReadMultiple'

I added changes that do not effect the building process that fixes this
problem. In reactos/include/wine/objidl.h.
> Missing macros in headers (search for COBJMACROS in W32API to see how to 
> implement).
>
> Regards,
> Filip

I think it is safe to commit my changes in that header, I did not see any
errors or warnings after making the changes.

Let me know other wise,
James