Re: [ros-dev] [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt

[Gabriel ilardi]

Wouldn't it be advisable besides the commit message also to add a comment to the code
as why stuff is commented out ?


>   Date: Sun, 24 Jul 2011 10:29:53 +0000
>  To: ros-diffs(a)reactos.org
>  From: jgardou(a)svn.reactos.org
>  Subject: [ros-diffs] [jgardou] 52831: [LIBWINE] - new tentative to fix build : get rid of
> libwine's stricmp, we have it in our crt
>  
>  Author: jgardou
>  Date: Sun Jul 24 10:29:52 2011
>  New Revision: 52831
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=52831&view=rev
>  Log:
>  [LIBWINE]
>  - new tentative to fix build : get rid of libwine's stricmp, we have it in our crt
>  
>  Modified:
>      trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt
>      trunk/reactos/lib/3rdparty/libwine/libwine.rbuild
>  
>  Modified: trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libwine/CMake…
>  ==============================================================================
>  --- trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt [iso-8859-1] (original)
>  +++ trunk/reactos/lib/3rdparty/libwine/CMakeLists.txt [iso-8859-1] Sun Jul 24 10:29:52
> 2011
>  @@ -6,7 +6,7 @@
>       config.c
>       debug_ros.c
>       loader.c
>  -    string.c)
>  +#    string.c)
>   
>   add_library(wine ${SOURCE})
>   
>  
>  Modified: trunk/reactos/lib/3rdparty/libwine/libwine.rbuild
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libwine/libwi…
>  ==============================================================================
>  --- trunk/reactos/lib/3rdparty/libwine/libwine.rbuild [iso-8859-1] (original)
>  +++ trunk/reactos/lib/3rdparty/libwine/libwine.rbuild [iso-8859-1] Sun Jul 24 10:29:52
> 2011
>  @@ -7,7 +7,7 @@
>   	<file>config.c</file>
>   	<file>debug_ros.c</file>
>   	<file>loader.c</file>
>  -	<file>string.c</file>
>  +	<!--file>string.c</file-->
>   </module>
>   <module name="wineldr" type="staticlibrary">
>   	<include base="ReactOS">include/reactos/wine</include>
>  
>