Re: [ros-dev] [ros-diffs] [fireball] 44348: [ntoskrnl/se] - Add a hack which prints an annoying message and grants access when it should not be. Callers/bugs should be fixed and this commit reverted after that. See issue #4169 for more details.

[Alex Ionescu]

This is stupid!!! We had this discussion countless times!
It's not a bug to get back access denied! In many situations this is
normal, and the application will try again! (Ie: Writing to a
read-only file)
Best regards,
Alex Ionescu
On Tue, Dec 1, 2009 at 10:26 PM,  <fireball(a)svn.reactos.org> wrote:
>   Author: fireball
>  Date: Tue Dec  1 22:26:40 2009
>  New Revision: 44348
>  URL: http://svn.reactos.org/svn/reactos?rev=44348&view=rev
>  Log:
>  [ntoskrnl/se]
>  - Add a hack which prints an annoying message and grants access when it should not be.
> Callers/bugs should be fixed and this commit reverted after that.
>  See issue #4169 for more details.
>  Modified:
>     trunk/reactos/ntoskrnl/se/semgr.c
>  Modified: trunk/reactos/ntoskrnl/se/semgr.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/semgr.c?rev=44…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] Tue Dec  1 22:26:40 2009
>  @@ -608,10 +608,12 @@
>      }
>      else
>      {
>  -        DPRINT1("Denying access for caller: granted 0x%lx, desired 0x%lx (generic
> mapping %p)\n",
>  +        DPRINT1("HACK: Should deny access for caller: granted 0x%lx, desired 0x%lx
> (generic mapping %p).\n",
>                  *GrantedAccess, DesiredAccess, GenericMapping);
>  -        *AccessStatus = STATUS_ACCESS_DENIED;
>  -        return FALSE;
>  +        //*AccessStatus = STATUS_ACCESS_DENIED;
>  +        //return FALSE;
>  +        *AccessStatus = STATUS_SUCCESS;
>  +        return TRUE;
>      }
>   }
>