Re: [ros-dev] [ros-diffs] [hbelusca] 65337: [NTOS:PNPMGR] - Remove an unneeded ExFreePool(DeviceInstance.Buffer); call in IopGetInterfaceDeviceList because at this point DeviceInstance is not yet initialized. Fixes MSVC bui...

[Timo Kreuzer]

You add parentheses to conform to coding style (our coding style 
guidelines do not require it) and on the other hand you convert a 2 line 
if statement into one line, which does not conform to our coding style?

Am 09.11.2014 03:26, schrieb hbelusca(a)svn.reactos.org:
>   Author: hbelusca
>  Date: Sun Nov  9 02:26:49 2014
>  New Revision: 65337
>
>  URL: http://svn.reactos.org/svn/reactos?rev=65337&view=rev
>  Log:
>  [NTOS:PNPMGR]
>  - Remove an unneeded ExFreePool(DeviceInstance.Buffer); call in IopGetInterfaceDeviceList
> because at this point DeviceInstance is not yet initialized. Fixes MSVC build.
>  - No need to check for DeviceInstance.Buffer being NULL or not (in IopDeviceStatus),
> because in case it was NULL the IopCaptureUnicodeString call already failed.
>  - Add some brackets to conform to code style.
>
>  Modified:
>       trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
>
>  Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c	[iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c	[iso-8859-1] Sun Nov  9 02:26:49 2014
>  @@ -199,8 +199,7 @@
>        }
>        _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
>        {
>  -        if (Name.Buffer)
>  -            ExFreePool(Name.Buffer);
>  +        if (Name.Buffer) ExFreePool(Name.Buffer);
>            Status = _SEH2_GetExceptionCode();
>        }
>        _SEH2_END;
>