Re: [ros-dev] [ros-diffs] [jgardou] 57909: [INCLUDE/CRT] - _CRT_NON_CONFORMING_SWPRINTFS is not relevant for us.

[Timo Kreuzer]

The reason for this define is to allow swprintf etc., wich is then an 
alias for _swprintf, which we do implement.
I don't see why this should be disabled.



Am 13.12.2012 20:21, schrieb jgardou(a)svn.reactos.org:
>   Author: jgardou
>  Date: Thu Dec 13 19:21:30 2012
>  New Revision: 57909
>
>  URL: http://svn.reactos.org/svn/reactos?rev=57909&view=rev
>  Log:
>  [INCLUDE/CRT]
>    - _CRT_NON_CONFORMING_SWPRINTFS is not relevant for us.
>
>  Modified:
>       trunk/reactos/include/crt/stdio.h
>       trunk/reactos/include/crt/wchar.h
>
>  Modified: trunk/reactos/include/crt/stdio.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/stdio.h?rev=57…
>  ==============================================================================
>  --- trunk/reactos/include/crt/stdio.h [iso-8859-1] (original)
>  +++ trunk/reactos/include/crt/stdio.h [iso-8859-1] Thu Dec 13 19:21:30 2012
>  @@ -322,12 +322,14 @@
>    #include <vadefs.h>
>    #endif
>    
>  +#if 0 //this is for MSVCRT80 and higher, which we don't use nor implement
>    #ifdef _CRT_NON_CONFORMING_SWPRINTFS
>    #ifndef __cplusplus
>    #define swprintf _swprintf
>    #define vswprintf _vswprintf
>    #define _swprintf_l __swprintf_l
>    #define _vswprintf_l __vswprintf_l
>  +#endif
>    #endif
>    #endif
>    
>
>  Modified: trunk/reactos/include/crt/wchar.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/wchar.h?rev=57…
>  ==============================================================================
>  --- trunk/reactos/include/crt/wchar.h [iso-8859-1] (original)
>  +++ trunk/reactos/include/crt/wchar.h [iso-8859-1] Thu Dec 13 19:21:30 2012
>  @@ -561,12 +561,14 @@
>      _CRTIMP int __cdecl __swprintf_l(wchar_t *_Dest,const wchar_t *_Format,_locale_t
> _Plocinfo,...);
>      _CRTIMP int __cdecl __vswprintf_l(wchar_t *_Dest,const wchar_t *_Format,_locale_t
> _Plocinfo,va_list _Args);
>    
>  +#if 0 //this is for MSVCRT80 and higher, which we don't use nor implement
>    #ifdef _CRT_NON_CONFORMING_SWPRINTFS
>    #ifndef __cplusplus
>    #define swprintf _swprintf
>    #define vswprintf _vswprintf
>    #define _swprintf_l __swprintf_l
>    #define _vswprintf_l __vswprintf_l
>  +#endif
>    #endif
>    #endif
>    
>
>
>

[Jérôme Gardou]

Windows XP and windows 2k3 msvcrt.dll don't export _swprintf, making
any test compiled with this define unusable on them and using swprintf
unusable on this platforms.

Also, from a pure testing point of view, we'd better test functions
that we should export ;-)


Le Fri, 14 Dec 2012 21:33:47 +0100,
Timo Kreuzer <timo.kreuzer(a)web.de> a écrit :

>   
>  The reason for this define is to allow swprintf etc., wich is then an 
>  alias for _swprintf, which we do implement.
>  I don't see why this should be disabled.
>  
>  
>  
>  Am 13.12.2012 20:21, schrieb jgardou(a)svn.reactos.org:
> >   Author: jgardou
> >  Date: Thu Dec 13 19:21:30 2012
> >  New Revision: 57909
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=57909&view=rev
> >  Log:
> >  [INCLUDE/CRT]
> >    - _CRT_NON_CONFORMING_SWPRINTFS is not relevant for us.
> >
> >  Modified:
> >       trunk/reactos/include/crt/stdio.h
> >       trunk/reactos/include/crt/wchar.h
> >
> >  Modified: trunk/reactos/include/crt/stdio.h
> >  URL:
> >
> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/stdio.h?rev=57…
> >  ==============================================================================
> >  --- trunk/reactos/include/crt/stdio.h [iso-8859-1] (original) +++
> >  trunk/reactos/include/crt/stdio.h [iso-8859-1] Thu Dec 13 19:21:30
> >  2012 @@ -322,12 +322,14 @@ #include <vadefs.h>
> >    #endif
> >    
> >  +#if 0 //this is for MSVCRT80 and higher, which we don't use nor
> >  implement #ifdef _CRT_NON_CONFORMING_SWPRINTFS
> >    #ifndef __cplusplus
> >    #define swprintf _swprintf
> >    #define vswprintf _vswprintf
> >    #define _swprintf_l __swprintf_l
> >    #define _vswprintf_l __vswprintf_l
> >  +#endif
> >    #endif
> >    #endif
> >    
> >
> >  Modified: trunk/reactos/include/crt/wchar.h
> >  URL:
> >
> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/wchar.h?rev=57…
> >  ==============================================================================
> >  --- trunk/reactos/include/crt/wchar.h [iso-8859-1] (original) +++
> >  trunk/reactos/include/crt/wchar.h [iso-8859-1] Thu Dec 13 19:21:30
> >  2012 @@ -561,12 +561,14 @@ _CRTIMP int __cdecl __swprintf_l(wchar_t
> >  *_Dest,const wchar_t *_Format,_locale_t _Plocinfo,...); _CRTIMP int
> >  __cdecl __vswprintf_l(wchar_t *_Dest,const wchar_t
> >  *_Format,_locale_t _Plocinfo,va_list _Args); +#if 0 //this is for
> >  MSVCRT80 and higher, which we don't use nor implement #ifdef
> >  _CRT_NON_CONFORMING_SWPRINTFS #ifndef __cplusplus
> >    #define swprintf _swprintf
> >    #define vswprintf _vswprintf
> >    #define _swprintf_l __swprintf_l
> >    #define _vswprintf_l __vswprintf_l
> >  +#endif
> >    #endif
> >    #endif
> >    
> >
> >
> >  
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev